Uh oh!
There was an error while loading. Please reload this page.
perf(liquid-glass): static large surfaces and true intensity-0 early-out - #183
Open
yanhenrique-dev wants to merge 1 commit into
Open
Conversation
The control panel (the scrollport) carried a full-sheet backdrop-filter plus SVG displacement map, re-sampled on every scroll frame; the sidebar carried a full-height refraction layer with a near-static backdrop. Both become static materials (gradients, hairlines) while live refraction survives on small floating surfaces only. Also adds .is-glass-min (set when the intensity slider hits 0): fading blur radius to 0 still pays the backdrop snapshot + url() + saturate passes, so every live filter layer is display:none'd instead. Removes the now-unreferenced lg-sheet-filter SVG def and the sidebar's box-shadow transition / hover sheen travel (full-height repaints).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Liquid Glass theme janks, especially on scroll. Two full-size live filters are responsible: the control panel (the scrollport itself) carries a full-sheet backdrop-filter + SVG displacement map re-sampled every scroll frame, and the sidebar carries a full-height refraction layer over an almost entirely static backdrop. Additionally, dragging Glass intensity to 0 only shrinks blur radius to 0 — the backdrop snapshot, url() displacement and saturate passes keep running.
Changes
Verification