Uh oh!
There was an error while loading. Please reload this page.
Elaborate object query feature - #1631
Merged
Merged
Conversation
Factor out utility class for tracking expression nesting. Modify parsing state setup and teardown: - Finish "AND" expression after search term and after right paren. - Finish object query expression on hitting "OR".
While it was already possible to construct ObjectQuery for nullptr Symbol tests, this was neither tested nor handled in toString() (nullptr dereference). By fixing this particular type of query, we get the cheapest possible valid ObjectQuery (no allocation), suitable for serving as placeholder where needed.
Support the form which is already used by ObjectQuery::toString(): SYMBOL "Code"
Together with AND and OR, we now implement all basic operations of Boolean algebra. Round brackets allow to express secondary operations. Resolves sub-issue discussed in GH-1512.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add negation and symbol expressions. Document language in BNF.