Uh oh!
There was an error while loading. Please reload this page.
OcdFileExport: Fix map notes export to .ocd version 8 - #2041
Merged
Conversation
dl3sdo
commented
Feb 18, 2022
MemberAuthor
I attach a map (.omap) with 32776 bytes of map notes that I used for testing. |
If the size of the map notes exceeded 32768 the map notes were truncated when saving as OCAD 8. However, instead of truncating to 32767 (the terminating 0 will be appended) it was truncated to 23767. When testing the fix with OCAD12 it turned out that it was necessary to truncate to 32766, otherwise OCAD12 would not open the map.
dl3sdo
commented
Mar 22, 2022
MemberAuthor
I modified the commit message to better meet the guidelines for commit messages. |
dg0yt
commented
Mar 23, 2022
Member
Thanks @dl3sdo ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the size of the map notes exceeded 32768 the map notes were truncated when saving as OCAD 8.
However, instead of truncating to 32767 (the terminating 0 will be appended) it was truncated to 23767.
When testing the fix with OCAD12 it turned out that it was necessary to truncate to 32766, otherwise OCAD12 would not open the map.