Uh oh!
There was an error while loading. Please reload this page.
OcdFileImport: Fix import of Rectangle symbols and objects - #2043
Merged
Conversation
dl3sdo
commented
Feb 22, 2022
MemberAuthor
Please find attached an .ocd12 sample file and a screenshot how it appears in OCAD12: |
The 'GridFlags' field consists of 3 bits: 1=Grid On, 2=Numbering On, 4=Numbered from the bottom The symbol import previously only considered 'Grid On' and mapped 'Numbered from the bottom' to Bit 1 instead. When importing Rectangle objects the 'Numbered from the bottom' property was applied just the other way around.
dl3sdoforce-pushed
the
rectanglesymbolimport
branch
from
March 1, 2022 17:30
46959ef to
14ba4daComparelpechacek
commented
Mar 16, 2022
Member
Close/reopen to trigger CI run. |
dg0yt
approved these changes
Mar 22, 2022
dg0yt
left a comment
Member
There was a problem hiding this comment.
I didn't test myself, but the code changes LGTM.
dg0yt
commented
Mar 23, 2022
Member
We should give names to the flags, but I don't want to deal with this now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'GridFlags' field consists of 3 bits: 1=Grid On, 2=Numbering On, 4=Numbered from the bottom
The symbol import previously only considered Grid On and mapped 'Numbered from the bottom' to Bit 1 instead.
When importing Rectangle objects the 'Numbered from the bottom' property was applied just the other way around.