Map information tool: Information about the map properties

[dl3sdo]

The map information tool informs about the number of map objects, templates and undo-/redo-steps.
It informs about the number and names of map parts, symbols, colors, and fonts.
It shows for each color the symbol(s) using the color.
For each symbol in use the tools shows the used color(s) and the number of related objects.

[dl3sdo]

Any proposals for additional features?

[dg0yt]

For consistent naming, this should probably come as class MapInformationDialog, in map_information_dialog files.

[dl3sdo]

The PR needs to be adapted due to changes in #2158, thus the merge of #2158 shall be done first.

[dl3sdo]

Reminder to me: Add new .cpp file to code-check-wrapper.sh

[dl3sdo]

Now with possibility to export the report as text file.

[dl3sdo]

As #2158 is not scheduled for the upcoming release I propose to assess whether this PR could be merged before #2158. An update due to #2158 is straightforward.

[krticka]

Hi, I really appreciate the implementation of Map information tool. I have comments only on the information about the coordinate system, when the info "by EPSG code" is shown. I think this is rather insufficient information and EPSG value + Coordinate system name (zone) should be shown.

[dl3sdo]

@krticka: thank you for your feedback. I extended the information about the CRS. However, I don't know how I can easily derive the UTM zone from the EPSG code so I just added the zone or code for UTM, GK and EPSG:

[krticka]

@dl3sdo Thank you for this improvement. Every zone usually has its own EPSG code, so there is no need to bother with it. Information about coordinate system can be easily extended if the code will be active hyperlink to the web EPSG database, e.g. https://epsg.io/25832

[lpechacek]

My style would be
auto* tree_widget_item = new QTreeWidgetItem(tree_depth ? tree_widget_itemtree_item_hierarchy.back() : map_info_tree);

And yes, not everyone likes it. :-)

[dl3sdo]

Especially the compiler does not like it ;-)
I tried that before but had to learn that the compiler apparently wants to know at compile time which constructor to use.
This variation is accepted:
auto* tree_widget_item = tree_depth ? new QTreeWidgetItem(tree_item_hierarchy.back()) : new QTreeWidgetItem(map_info_tree);

[dg0yt]

Is that equivalent:

Suggested change

	QTreeWidgetItem* tree_widget_item;
	if (tree_depth)
	tree_widget_item = new QTreeWidgetItem(tree_item_hierarchy.back());
	else
	tree_widget_item = new QTreeWidgetItem(map_info_tree);
	auto* tree_widget_item = new QTreeWidgetItem (tree_depth ? tree_item_hierarchy.back() : map_info_tree.invisibleRootItem());

[dl3sdo]

I incorporated all review comments, please review.

[dl3sdo]

Mapper uses default type-specific symbols for objects without specific symbols. Commit 0d2cd01 counts and shows the usage of these default symbols below their symbol category:

Testfile:
undefined_defined_objects.zip

Maybe we should not show the 'Undefined symbols' category if there are no really 'undefined symbols' as the current output is confusing.

[dl3sdo]

The Custom PROJ.4 change was triggered by testing with a map that has this Crs:
<georeferencing scale="10000" auxiliary_scale_factor="1.000271" declination="1.13"><projected_crs><spec language="PROJ.4">PROJCS[&quot;ETRS89 / UTM zone 32N&quot;,GEOGCS[&quot;ETRS89&quot;,DATUM[&quot;European_Terrestrial_Reference_System_1989&quot;,SPHEROID[&quot;GRS 1980&quot;,6378137,298.257222101,AUTHORITY[&quot;EPSG&quot;,&quot;7019&quot;]],AUTHORITY[&quot;EPSG&quot;,&quot;6258&quot;]],PRIMEM[&quot;Greenwich&quot;,0,AUTHORITY[&quot;EPSG&quot;,&quot;8901&quot;]],UNIT[&quot;degree&quot;,0.0174532925199433,AUTHORITY[&quot;EPSG&quot;,&quot;9122&quot;]],AUTHORITY[&quot;EPSG&quot;,&quot;4258&quot;]],PROJECTION[&quot;Transverse_Mercator&quot;],PARAMETER[&quot;latitude_of_origin&quot;,0],PARAMETER[&quot;central_meridian&quot;,9],PARAMETER[&quot;scale_factor&quot;,0.9996],PARAMETER[&quot;false_easting&quot;,500000],PARAMETER[&quot;false_northing&quot;,0],UNIT[&quot;metre&quot;,1,AUTHORITY[&quot;EPSG&quot;,&quot;9001&quot;]],AXIS[&quot;Easting&quot;,EAST],AXIS[&quot;Northing&quot;,NORTH],AUTHORITY[&quot;EPSG&quot;,&quot;25832&quot;]]</spec><ref_point x="602627.558" y="5631240.258"/></projected_crs><geographic_crs id="Geographic coordinates"><spec language="PROJ.4">+proj=latlong +datum=WGS84</spec><ref_point_deg lat="50.82377724" lon="10.45708359"/></geographic_crs></georeferencing>

[dl3sdo]

I successfully reviewed the code and tested the Windows build as well as my development version with various maps.
Right now there are no further changes planned by me and I consider this PR mature enough to be merged.

[dg0yt]

Okay, I will "squash and merge" this tonight.