Uh oh!
There was an error while loading. Please reload this page.
Consider dash symbols in combined symbols - #2154
Merged
dg0yt merged 4 commits intoDec 9, 2024
Merged
Conversation
dl3sdoforce-pushed
the
dash-points-combined-symbols
branch
from
June 26, 2023 21:18
676d238 to
044165aCompare
Closed
dg0yt
self-requested a review
April 14, 2024 15:47
dl3sdoforce-pushed
the
dash-points-combined-symbols
branch
from
August 22, 2024 12:43
044165a to
165bf3dComparedg0yt
reviewed
Aug 23, 2024
| * Function is used by DrawPathTool::updateDashPointDrawing() and | ||
| * EditPointTool::addDashPointDefault() in relation to setting and changing dash points. | ||
| */ | ||
| bool symbolContainsDashSymbol(const Symbol* symbol) |
Member
There was a problem hiding this comment.
I think this should become a virtual member function Symbol::containsDashSymbol, with suitable overrides in subclasses.
dl3sdo
marked this pull request as draft
August 23, 2024 08:09
dl3sdoforce-pushed
the
dash-points-combined-symbols
branch
from
August 23, 2024 15:43
165bf3d to
acaa4a5Comparedl3sdo
marked this pull request as ready for review
August 23, 2024 15:45
|
Azure Pipelines successfully started running 1 pipeline(s). |
For line symbols and combined symbols determine if the symbol contains a dash symbol.
When drawing line objects for symbols with dash symbols, no dash points were set automatically if the symbol was a combined symbol. When editing line objects for symbols with dash symbols, additional points were not added as dash points if the symbol was a combined symbol. These deviations were known and marked as TODO. This change treats line symbols with dash symbols and combined symbols containing line symbols with dash symbols equally.
dl3sdoforce-pushed
the
dash-points-combined-symbols
branch
from
November 29, 2024 15:50
acaa4a5 to
f5011a4Comparedl3sdo
commented
Nov 29, 2024
MemberAuthor
Rebased to solve merge conflicts. |
There is no benefit from the inline definition, and all other implementations are in the cpp files.
dl3sdo
commented
Dec 8, 2024
MemberAuthor
@dg0yt: I agree to your proposed changes, thank you. |
lpechacek pushed a commit
to lpechacek/mapper
that referenced
this pull request
Oct 15, 2025
Dash symbols may occur in line symbols but also in combined symbols. The editors only considered line symbols. This change adds a virtual property to the Symbol class and corresponding overrides in derived classes. DrawPathTool and EditPointTool are updated to make use of the new property. Co-authored-by: Kai Pastor <dg0yt@darc.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When drawing line objects for symbols with dash symbols, no dash points were set automatically if the symbol was a combined symbol.
When editing line objects for symbols with dash symbols, additional points were not added as dash points if the symbol was a combined symbol.
These deviations were known and marked as TODO.
This commit treats line symbols with dash symbols and combined symbols containing line symbols with dash symbols equally.