Uh oh!
There was an error while loading. Please reload this page.
OcdFileExport: Fix OCD v8 object size calculation - #2290
Merged
dg0yt merged 2 commits intoOct 31, 2024
Conversation
Objects with a large number of coordinates overflown the 16-bit integer allocated for the object size. As a result, Mapper produced invalid entries for these objects. The actual number of object coordinates is limited by the object's num_items data entry which is indeed a signed short integer. We are now checking for this condition and refusing to export these objects as they are invalid in the context of this file format.
dg0yt
commented
Oct 31, 2024
Member
macOS CI: Flaky CPack step, unrelated. Re-run must wait while I try to integrate the general CI updates. |
dl3sdo
commented
Oct 31, 2024
Member
Will close #291 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although OCD v8 is an old one, Mapper is the only software left to support writing these files. In my opinion, bugs are worth fixing in this part of the code.
ClosesGH-291.