Uh oh!
There was an error while loading. Please reload this page.
TextSymbolSettings: Fix initial state of standard buttons - #2308
Merged
Conversation
When entering the text symbol settings dialog the 'OK' and 'Reset' buttons where initially enabled. Don't misuse the framingCheckClicked() function to enable/disable the framing_widget tab in updateGeneralContents() as framingCheckClicked() will signal modified properties.
dg0yt
commented
Jan 10, 2025
Member
IWYU is somewhat sensitive to versions. I tried to reflect the actual usage. IMO the problematic pattern was restoring |
dg0yt
approved these changes
Jan 10, 2025
lpechacek pushed a commit
to lpechacek/mapper
that referenced
this pull request
Oct 15, 2025
…eering#2308) When entering the text symbol settings dialog the 'OK' and 'Reset' buttons where initially enabled. Don't misuse the framingCheckClicked() function to enable/disable the framing_widget tab in updateGeneralContents() as framingCheckClicked() will signal modified properties.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When entering the text symbol settings dialog the 'OK' and 'Reset' buttons where initially enabled.
Don't misuse the
framingCheckClicked()function to enable/disable theframing_widgettab inupdateGeneralContents()asframingCheckClicked()will signal modified properties.