Uh oh!
There was an error while loading. Please reload this page.
TagSelectWidget: Change column width - #2338
Merged
Merged
Conversation
dl3sdo
commented
Feb 21, 2025
MemberAuthor
Example (Windows): |
dl3sdo
marked this pull request as draft
February 21, 2025 21:31
dl3sdo
commented
Feb 22, 2025
MemberAuthor
The first commit fixes the issue that the beginning of Key and Values fields may be hidden permanently. 22-02-_2025_13-29-04.mp4 |
Member
What we have in master is that newly added lines look better than previously added lines. You can test in plain English if temporarily shorten the source strings. - setHorizontalHeaderLabels(QStringList() << tr("Relation") << tr("Key") << tr("Comparison") << tr("Value"));+ setHorizontalHeaderLabels(QStringList() << tr("R") << tr("Key") << tr("C") << tr("Value")); |
dl3sdo
commented
Feb 22, 2025
MemberAuthor
I notice that this issue does not occur on my Linux development build (which is based on QT 5.15). |
dl3sdoforce-pushed
the
tag-select-resize
branch
2 times, most recently
from
February 23, 2025 18:20
55ef84f to
4e67d1eCompareThe 'Find objects' dialog contains a table which is shown in the 'Query editor' view. The 'Relation' and 'Comparision' labeled columns were set up with a fixed width based on its translations. The result looks good for English but not for other languages, e.g., German or Czech. Set up both columns to automatically resize based on its contents.
dl3sdoforce-pushed
the
tag-select-resize
branch
from
February 24, 2025 17:23
6bff2f4 to
779b952Compare|
Azure Pipelines successfully started running 1 pipeline(s). |
dl3sdo
marked this pull request as ready for review
February 24, 2025 18:41
dg0yt
approved these changes
Mar 16, 2025
dl3sdo
commented
Mar 16, 2025
MemberAuthor
@dg0yt: thank you for refactoring the code. I tested it successfully under Windows. |
lpechacek pushed a commit
to lpechacek/mapper
that referenced
this pull request
Oct 15, 2025
The 'Relation' and 'Comparison' columns must be wide enough to hold the translated combobox items. --------- Co-authored-by: Kai Pastor <dg0yt@darc.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'Find objects' dialog contains a table which is shown in the 'Query editor' view.
The 'Relation' and 'Comparision' columns were set up with a fixed width based on the width of the translated labels 'Relation' and 'Comparision'. The result looks good for English but not for other languages, e.g., German or Czech.
Set up both columns to automatically resize based on its contents.