Uh oh!
There was an error while loading. Please reload this page.
TagsWidget: Disable editor if multiple objects are selected - #2353
Merged
Conversation
If multiple objects were selected the tag editor would just operate on the so-called 'first selected object'. If a group of objects is selected the user does not know which of them is the first selected object.
dl3sdo
commented
Mar 24, 2025
MemberAuthor
Allowing tag editing when multiple objects are selected also could give the user the false impression that bulk editing of tags is supported by Mapper. |
dg0yt
reviewed
Apr 1, 2025
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Kai Pastor <dg0yt@darc.de>
dl3sdo
commented
Apr 1, 2025
MemberAuthor
@dg0yt: thank you for the review and proposed changes. My thought of keeping the |
dg0yt
approved these changes
Apr 1, 2025
dg0yt
left a comment
Member
There was a problem hiding this comment.
When we have selected objects, there must exist a first selected object.
lpechacek pushed a commit
to lpechacek/mapper
that referenced
this pull request
Oct 15, 2025
…nteeringGH-2353) If multiple objects were selected the tag editor would operate on the so-called 'first selected object' which the user does not know. --------- Co-authored-by: Kai Pastor <dg0yt@darc.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If multiple objects were selected the tag editor would just operate on the so-called 'first selected object'.
If a group of objects is selected the user does not know which of them is the first selected object.