Skip to content

First shot at code style stuff - #77

Open
uberlinuxguy wants to merge 3 commits into
mainfrom
uberlinuxguy/code-style
Open

First shot at code style stuff#77
uberlinuxguy wants to merge 3 commits into
mainfrom
uberlinuxguy/code-style

Conversation

@uberlinuxguy

Copy link
Copy Markdown
Member

This is a first start at some code style stuff, until we codify something. Probably want a README update too.

@uberlinuxguy

Copy link
Copy Markdown
MemberAuthor

References #75

Comment thread.editorconifg
Comment thread.editorconifg
Comment thread.gitattributes Outdated
Comment thread.gitattributes Outdated
@slime73

Copy link
Copy Markdown
Contributor

I just wanna test this out locally (later today hopefully) to make sure it doesn't cause any unexpected issues for me

Comment thread.gitattributes Outdated
@uberlinuxguy

Copy link
Copy Markdown
MemberAuthor

Are we good to merge this as a starting point?

@slime73

Copy link
Copy Markdown
Contributor

Go ahead and merge it IMO, if we run into any issues we can figure things out from there

@tribad

Copy link
Copy Markdown
Contributor

Why not use end_of_line = auto
?

Comment thread.editorconifg
Comment on lines +6 to +8
# Unix-style newlines with a newline ending every file
[*]
end_of_line = lf

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Unix-style newlines with a newline ending every file
[*]
end_of_line = lf

Remove local enforcement of line endings in favor of enforcing what goes into the repo via .gitattributes

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@uberlinuxguy@slime73@tribad@Cheeseness