UI: Fix spinner scaling issues and standardize sizes across GTK themes - #462
Closed
SinghCod3r wants to merge 9 commits into
Closed
SinghCod3r wants to merge 9 commits into
SinghCod3r wants to merge 9 commits into
Conversation
alexpevzner
self-requested a review
September 12, 2026 21:02
- Fix SIGSEGV by wrapping OpenPrinting signal emissions in GLib.idle_add - Fix GTK-CRITICAL layout errors by deferring search dialog destruction - Prevent PackageKit DBus activation from blocking the main GTK loop - Prevent PackageKit DBus polling from freezing the GUI by using select - Replace deprecated modal searching dialogs with inline spinners
…oss all the distors
Key improvements in this PR: 1. Fixed Gtk crash, caused by calling Gtk methods from the wrong threading context 2. Fixed GUI freezing, caused by blocking synchronous PackageKit calls via D-Bus 3. Modal dialogs (like Searching for Drivers) replaced with the rolling spinner 4. Spinner size and position adjusted to look nice (for this purpose, GtkSpinner replaced with the custom spinner)
Member
|
Looks like it was included into #463 and merged, correct? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
58x58bounding area.