Update to .NET 8.0 and refactor tests - #29
Merged
Merged
Conversation
Updated target frameworks to .NET 8.0 in `launch.json`, `IntelOrca.OpenLauncher.Core.csproj`, `openlauncher.csproj`, and `IntelOrca.OpenLauncher.Tests.csproj`. Upgraded various NuGet packages to their latest Minor versions. Refactored `BuildServiceTests.cs` to use `[Theory]` with `InlineData` and introduced a helper method for asset matching.
IntelOrca
reviewed
Sep 24, 2024
TommyKolodziejczyk
force-pushed
the
dotnet8
branch
from
September 27, 2024 17:25
0669a0a to
895a869
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated target frameworks to .NET 8.0 in
launch.json,IntelOrca.OpenLauncher.Core.csproj,openlauncher.csproj, andIntelOrca.OpenLauncher.Tests.csproj. v6 will be deprecated soon. v7 is already deprecated since May 14, 2024Upgraded various NuGet packages to their latest Minor versions. to not introduced regression i've upgraded only dotnet 8 files and few minor hotfix versions
Refactored
BuildServiceTests.csto use[Theory]withInlineDataand introduced a helper method for asset matching. -> to fix tests on local machine