Install binaries in local appdata - #37
Merged
Merged
Conversation
The launcher currently tries to put the binaries in a subfolder
of the user’s game files, which causes problems with OneDrive
and isn’t really a good place to store these to begin with.
This makes the code uses %LOCALAPPDATA% instead. This seems to be
the best place, as the binaries can be machine-specific, which is
why I didn’t pick %APPDATA%. (This is only relevant to roaming
profiles, but we might as well do it right while we’re at it.)
On Linux, this puts the files in ~/.local/share/Open{RCT2,Loco}
AaronVanGeffen
approved these changes
May 11, 2025
AaronVanGeffen
left a comment
Member
There was a problem hiding this comment.
Changes look good to me. Players will have to remove old bin folders manually after upgrading, but I think that can't easily be helped. Let's go with this as-is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The launcher currently tries to put the binaries in a subfolder of the user’s game files, which causes problems with OneDrive and isn’t really a good place to store these to begin with.
This makes the code uses %LOCALAPPDATA% instead. This seems to be the best place, as the binaries can be machine-specific, which is why I didn’t pick %APPDATA%. (This is only relevant to roaming profiles, but we might as well do it right while we’re at it.)
On Linux, this puts the files in ~/.local/share/Open{RCT2,Loco}/bin