Skip to content

Close #31: Add option to auto-update game - #45

Merged
Gymnasiast merged 6 commits into
masterfrom
feature/auto-update-game
May 24, 2025
Merged

Gymnasiast merged 6 commits into
masterfrom
feature/auto-update-game

Conversation

@Gymnasiast

Copy link
Copy Markdown
Member

No description provided.

@Gymnasiast Gymnasiast linked an issue May 18, 2025 that may be closed by this pull request
@733737

733737 commented May 18, 2025

Copy link
Copy Markdown

I posted a few bugs in the discord.

@733737

733737 commented May 18, 2025

Copy link
Copy Markdown

when you have a development build installed and automatically install updates checked, then you uncheck show development versions, it downloads the release build but does not install the release build. So you are left with the development build until you uncheck automatically install updates and click download.

@Gymnasiast

Copy link
Copy Markdown
Member Author

@733737 Is that the only remaining bug? (If any of the things you mentioned on Discord are still applicable, please mention them as well.)

@733737

733737 commented May 19, 2025

Copy link
Copy Markdown

I don't like how automatic downloads are universal. Also, it instantly downloads the latest build when you click off to openloco and back so if it could detect a new build a little faster that would be good.

@IntelOrca IntelOrca left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove async from autoUpdateGameCheckbox_Changed too to get rid of the warnings.

Typically methods that are async should return Task instead of void. But UI events must return void and therefore can't do this. Instead we wrap everything in a try catch so that we can handle exceptions if they get raised.

Since the DownloadBuild method does wrap everything in a try catch, this can remain a return void function, and the events don't need to await it and can just be non-async void themselves.

Comment thread src/openlauncher/MainWindow.axaml.cs Outdated
@Gymnasiast
Gymnasiast force-pushed the feature/auto-update-game branch from 68df38c to 72e73fb Compare May 19, 2025 22:15
@Gymnasiast
Gymnasiast force-pushed the feature/auto-update-game branch from 72e73fb to 8d61352 Compare May 19, 2025 22:17
@733737

733737 commented May 20, 2025

Copy link
Copy Markdown

all of the bugs I reported seem to be fixed! 👍

@Manticore-007

Manticore-007 commented May 20, 2025

Copy link
Copy Markdown

image

this doesn't look good, the weird symbols at the start of the messages I mean.

@Gymnasiast

Gymnasiast commented May 20, 2025

Copy link
Copy Markdown
Member Author

Those are colour codes to make the text in the terminal look nice. It’s not related to this PR anyway - it will also happen if you install OpenLoco manually and then try to start it without Locomotion installed.

Comment thread src/openlauncher/MainWindow.axaml.cs Outdated
@Gymnasiast
Gymnasiast requested a review from IntelOrca May 22, 2025 09:40
@Gymnasiast
Gymnasiast merged commit e7e73e0 into master May 24, 2025
@Gymnasiast
Gymnasiast deleted the feature/auto-update-game branch May 24, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option to auto-update game

4 participants