Uh oh!
There was an error while loading. Please reload this page.
fix: show signal names instead of 'code null' when scripts are killed - #1014
Merged
Conversation
When a spawn script is killed by a signal (SIGKILL, SIGTERM, SIGHUP, etc.), Node.js returns exit code null. Previously this produced the confusing message "Script exited with code null". Now detects the actual signal and shows signal-specific guidance: OOM suggestions for SIGKILL, terminal reconnection tips for SIGHUP, spot instance warnings for SIGTERM. Fixes#1011 Agent: ux-engineer Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
5 tasks
louisgv
approved these changes
Feb 13, 2026
louisgv
left a comment
Collaborator
There was a problem hiding this comment.
Security Review
Verdict: APPROVED
Findings
No security issues found. All changes are well-scoped:
getSignalGuidance()is a pure function returning static string arrays — no injection surface- The regex
SIG\w+constrains captured signal names to word characters only - Signal values originate from Node.js
child_processinternals (NodeJS.Signalstype), not user input - Template literal interpolation of signal names is only used in console error output (no HTML/shell/SQL context)
- New test coverage is thorough (19 new test cases covering all signal branches and edge cases)
- Version bump (0.2.76 → 0.2.77) is appropriate for the scope of changes
Tests
- bash -n: N/A (no .sh files changed)
- bun test: PASS (81/81 in script-failure-guidance.test.ts)
- curl|bash pattern: N/A (no .sh files changed)
- macOS compat: N/A (no .sh files changed)
-- security/pr-reviewer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
null. Previously this produced the confusing message "Script exited with code null" with generic troubleshooting guidancegetSignalGuidance()with 13 tests covering all handled signals (SIGKILL, SIGTERM, SIGINT, SIGHUP) plus unknown signal fallbackBefore
After
Fixes#1011
Test plan
-- refactor/ux-engineer