refactor: decompose latitude and contabo create_server into focused helpers

[la14-1]

Summary

• Extract validation, error handling, and response parsing from create_server in both latitude/lib/common.sh and contabo/lib/common.sh into dedicated helper functions
• Follows the same decomposition pattern established in PR refactor: decompose webdock create_server and koyeb ensure_koyeb_cli into focused helpers #1016 (Webdock/Koyeb)
• Each provider gets 3 new focused helpers: input validation, create-error checking, and response ID extraction

Latitude helpers

• _latitude_validate_inputs — validates plan, site, and OS resource names
• _latitude_check_create_error — checks response and reports failure details
• _latitude_extract_server_id — extracts and exports server ID from response

Contabo helpers

• _contabo_validate_inputs — validates product ID, region, image ID, and period
• _contabo_check_create_error — checks response and reports failure details
• _contabo_extract_instance_id — extracts and exports instance ID from response

Test plan

• bash -n latitude/lib/common.sh passes
• bash -n contabo/lib/common.sh passes
• bash test/mock.sh latitude — same results as main (15 passed, 45 failed — pre-existing SSH key mock issue)
• Contabo has no mock fixtures — no test regression possible

Agent: complexity-hunter

🤖 Generated with Claude Code

[louisgv]

Security Review

Verdict: APPROVED

Findings

No security issues found. This refactoring improves code organization while maintaining all existing security patterns.

Changes analyzed:

• Extracted validation logic into _contabo_validate_inputs and _latitude_validate_inputs
• Extracted error checking into _contabo_check_create_error and _latitude_check_create_error
• Extracted instance/server ID extraction into dedicated helpers
• All input validation preserved (validate_resource_name, validate_region_name)
• No command injection vectors introduced
• Python JSON parsing properly isolated
• No credential leaks or logging issues

Tests

• bash -n: PASS (both contabo/lib/common.sh and latitude/lib/common.sh)
• bun test: N/A (no TypeScript changes)
• curl|bash pattern: OK (no changes to source/eval fallback)
• macOS compat: OK (no bash 3.x incompatibilities)

Code Quality

• Improves maintainability by extracting repeated logic
• Better separation of concerns
• Consistent error handling patterns
• No changes to public API surface

---

-- security/pr-reviewer

[la14-1]

Summary

• Extract validation, error handling, and response parsing from create_server in both latitude/lib/common.sh and contabo/lib/common.sh into dedicated helper functions
• Follows the same decomposition pattern established in PR refactor: decompose webdock create_server and koyeb ensure_koyeb_cli into focused helpers #1016 (Webdock/Koyeb)
• Each provider gets 3 new focused helpers: input validation, create-error checking, and response ID extraction

Latitude helpers

• _latitude_validate_inputs — validates plan, site, and OS resource names
• _latitude_check_create_error — checks response and reports failure details
• _latitude_extract_server_id — extracts and exports server ID from response

Contabo helpers

• _contabo_validate_inputs — validates product ID, region, image ID, and period
• _contabo_check_create_error — checks response and reports failure details
• _contabo_extract_instance_id — extracts and exports instance ID from response

Test plan

• bash -n latitude/lib/common.sh passes
• bash -n contabo/lib/common.sh passes
• bash test/mock.sh latitude — same results as main (15 passed, 45 failed — pre-existing SSH key mock issue)
• Contabo has no mock fixtures — no test regression possible

Agent: complexity-hunter

🤖 Generated with Claude Code

[louisgv]

Security Review

Verdict: APPROVED

Findings

No security issues found. This refactoring improves code organization while maintaining all existing security patterns.

Changes analyzed:

• Extracted validation logic into _contabo_validate_inputs and _latitude_validate_inputs
• Extracted error checking into _contabo_check_create_error and _latitude_check_create_error
• Extracted instance/server ID extraction into dedicated helpers
• All input validation preserved (validate_resource_name, validate_region_name)
• No command injection vectors introduced
• Python JSON parsing properly isolated
• No credential leaks or logging issues

Tests

• bash -n: PASS (both contabo/lib/common.sh and latitude/lib/common.sh)
• bun test: N/A (no TypeScript changes)
• curl|bash pattern: OK (no changes to source/eval fallback)
• macOS compat: OK (no bash 3.x incompatibilities)

Code Quality

• Improves maintainability by extracting repeated logic
• Better separation of concerns
• Consistent error handling patterns
• No changes to public API surface

---

-- security/pr-reviewer

[la14-1]

Summary

• Extract validation, error handling, and response parsing from create_server in both latitude/lib/common.sh and contabo/lib/common.sh into dedicated helper functions
• Follows the same decomposition pattern established in PR refactor: decompose webdock create_server and koyeb ensure_koyeb_cli into focused helpers #1016 (Webdock/Koyeb)
• Each provider gets 3 new focused helpers: input validation, create-error checking, and response ID extraction

Latitude helpers

• _latitude_validate_inputs — validates plan, site, and OS resource names
• _latitude_check_create_error — checks response and reports failure details
• _latitude_extract_server_id — extracts and exports server ID from response

Contabo helpers

• _contabo_validate_inputs — validates product ID, region, image ID, and period
• _contabo_check_create_error — checks response and reports failure details
• _contabo_extract_instance_id — extracts and exports instance ID from response

Test plan

• bash -n latitude/lib/common.sh passes
• bash -n contabo/lib/common.sh passes
• bash test/mock.sh latitude — same results as main (15 passed, 45 failed — pre-existing SSH key mock issue)
• Contabo has no mock fixtures — no test regression possible

Agent: complexity-hunter

🤖 Generated with Claude Code

[louisgv]

Security Review

Verdict: APPROVED

Findings

No security issues found. This refactoring improves code organization while maintaining all existing security patterns.

Changes analyzed:

• Extracted validation logic into _contabo_validate_inputs and _latitude_validate_inputs
• Extracted error checking into _contabo_check_create_error and _latitude_check_create_error
• Extracted instance/server ID extraction into dedicated helpers
• All input validation preserved (validate_resource_name, validate_region_name)
• No command injection vectors introduced
• Python JSON parsing properly isolated
• No credential leaks or logging issues

Tests

• bash -n: PASS (both contabo/lib/common.sh and latitude/lib/common.sh)
• bun test: N/A (no TypeScript changes)
• curl|bash pattern: OK (no changes to source/eval fallback)
• macOS compat: OK (no bash 3.x incompatibilities)

Code Quality

• Improves maintainability by extracting repeated logic
• Better separation of concerns
• Consistent error handling patterns
• No changes to public API surface

---

-- security/pr-reviewer

[la14-1]

Summary

• Extract validation, error handling, and response parsing from create_server in both latitude/lib/common.sh and contabo/lib/common.sh into dedicated helper functions
• Follows the same decomposition pattern established in PR refactor: decompose webdock create_server and koyeb ensure_koyeb_cli into focused helpers #1016 (Webdock/Koyeb)
• Each provider gets 3 new focused helpers: input validation, create-error checking, and response ID extraction

Latitude helpers

• _latitude_validate_inputs — validates plan, site, and OS resource names
• _latitude_check_create_error — checks response and reports failure details
• _latitude_extract_server_id — extracts and exports server ID from response

Contabo helpers

• _contabo_validate_inputs — validates product ID, region, image ID, and period
• _contabo_check_create_error — checks response and reports failure details
• _contabo_extract_instance_id — extracts and exports instance ID from response

Test plan

• bash -n latitude/lib/common.sh passes
• bash -n contabo/lib/common.sh passes
• bash test/mock.sh latitude — same results as main (15 passed, 45 failed — pre-existing SSH key mock issue)
• Contabo has no mock fixtures — no test regression possible

Agent: complexity-hunter

🤖 Generated with Claude Code

[louisgv]

Security Review

Verdict: APPROVED

Findings

No security issues found. This refactoring improves code organization while maintaining all existing security patterns.

Changes analyzed:

• Extracted validation logic into _contabo_validate_inputs and _latitude_validate_inputs
• Extracted error checking into _contabo_check_create_error and _latitude_check_create_error
• Extracted instance/server ID extraction into dedicated helpers
• All input validation preserved (validate_resource_name, validate_region_name)
• No command injection vectors introduced
• Python JSON parsing properly isolated
• No credential leaks or logging issues

Tests

• bash -n: PASS (both contabo/lib/common.sh and latitude/lib/common.sh)
• bun test: N/A (no TypeScript changes)
• curl|bash pattern: OK (no changes to source/eval fallback)
• macOS compat: OK (no bash 3.x incompatibilities)

Code Quality

• Improves maintainability by extracting repeated logic
• Better separation of concerns
• Consistent error handling patterns
• No changes to public API surface

---

-- security/pr-reviewer

[la14-1]

Summary

• Extract validation, error handling, and response parsing from create_server in both latitude/lib/common.sh and contabo/lib/common.sh into dedicated helper functions
• Follows the same decomposition pattern established in PR refactor: decompose webdock create_server and koyeb ensure_koyeb_cli into focused helpers #1016 (Webdock/Koyeb)
• Each provider gets 3 new focused helpers: input validation, create-error checking, and response ID extraction

Latitude helpers

• _latitude_validate_inputs — validates plan, site, and OS resource names
• _latitude_check_create_error — checks response and reports failure details
• _latitude_extract_server_id — extracts and exports server ID from response

Contabo helpers

• _contabo_validate_inputs — validates product ID, region, image ID, and period
• _contabo_check_create_error — checks response and reports failure details
• _contabo_extract_instance_id — extracts and exports instance ID from response

Test plan

• bash -n latitude/lib/common.sh passes
• bash -n contabo/lib/common.sh passes
• bash test/mock.sh latitude — same results as main (15 passed, 45 failed — pre-existing SSH key mock issue)
• Contabo has no mock fixtures — no test regression possible

Agent: complexity-hunter

🤖 Generated with Claude Code

[louisgv]

Security Review

Verdict: APPROVED

Findings

No security issues found. This refactoring improves code organization while maintaining all existing security patterns.

Changes analyzed:

• Extracted validation logic into _contabo_validate_inputs and _latitude_validate_inputs
• Extracted error checking into _contabo_check_create_error and _latitude_check_create_error
• Extracted instance/server ID extraction into dedicated helpers
• All input validation preserved (validate_resource_name, validate_region_name)
• No command injection vectors introduced
• Python JSON parsing properly isolated
• No credential leaks or logging issues

Tests

• bash -n: PASS (both contabo/lib/common.sh and latitude/lib/common.sh)
• bun test: N/A (no TypeScript changes)
• curl|bash pattern: OK (no changes to source/eval fallback)
• macOS compat: OK (no bash 3.x incompatibilities)

Code Quality

• Improves maintainability by extracting repeated logic
• Better separation of concerns
• Consistent error handling patterns
• No changes to public API surface

---

-- security/pr-reviewer

[la14-1]

Summary

• Extract validation, error handling, and response parsing from create_server in both latitude/lib/common.sh and contabo/lib/common.sh into dedicated helper functions
• Follows the same decomposition pattern established in PR refactor: decompose webdock create_server and koyeb ensure_koyeb_cli into focused helpers #1016 (Webdock/Koyeb)
• Each provider gets 3 new focused helpers: input validation, create-error checking, and response ID extraction

Latitude helpers

• _latitude_validate_inputs — validates plan, site, and OS resource names
• _latitude_check_create_error — checks response and reports failure details
• _latitude_extract_server_id — extracts and exports server ID from response

Contabo helpers

• _contabo_validate_inputs — validates product ID, region, image ID, and period
• _contabo_check_create_error — checks response and reports failure details
• _contabo_extract_instance_id — extracts and exports instance ID from response

Test plan

• bash -n latitude/lib/common.sh passes
• bash -n contabo/lib/common.sh passes
• bash test/mock.sh latitude — same results as main (15 passed, 45 failed — pre-existing SSH key mock issue)
• Contabo has no mock fixtures — no test regression possible

Agent: complexity-hunter

🤖 Generated with Claude Code

[louisgv]

Security Review

Verdict: APPROVED

Findings

No security issues found. This refactoring improves code organization while maintaining all existing security patterns.

Changes analyzed:

• Extracted validation logic into _contabo_validate_inputs and _latitude_validate_inputs
• Extracted error checking into _contabo_check_create_error and _latitude_check_create_error
• Extracted instance/server ID extraction into dedicated helpers
• All input validation preserved (validate_resource_name, validate_region_name)
• No command injection vectors introduced
• Python JSON parsing properly isolated
• No credential leaks or logging issues

Tests

• bash -n: PASS (both contabo/lib/common.sh and latitude/lib/common.sh)
• bun test: N/A (no TypeScript changes)
• curl|bash pattern: OK (no changes to source/eval fallback)
• macOS compat: OK (no bash 3.x incompatibilities)

Code Quality

• Improves maintainability by extracting repeated logic
• Better separation of concerns
• Consistent error handling patterns
• No changes to public API surface

---

-- security/pr-reviewer

[la14-1]

Summary

• Extract validation, error handling, and response parsing from create_server in both latitude/lib/common.sh and contabo/lib/common.sh into dedicated helper functions
• Follows the same decomposition pattern established in PR refactor: decompose webdock create_server and koyeb ensure_koyeb_cli into focused helpers #1016 (Webdock/Koyeb)
• Each provider gets 3 new focused helpers: input validation, create-error checking, and response ID extraction

Latitude helpers

• _latitude_validate_inputs — validates plan, site, and OS resource names
• _latitude_check_create_error — checks response and reports failure details
• _latitude_extract_server_id — extracts and exports server ID from response

Contabo helpers

• _contabo_validate_inputs — validates product ID, region, image ID, and period
• _contabo_check_create_error — checks response and reports failure details
• _contabo_extract_instance_id — extracts and exports instance ID from response

Test plan

• bash -n latitude/lib/common.sh passes
• bash -n contabo/lib/common.sh passes
• bash test/mock.sh latitude — same results as main (15 passed, 45 failed — pre-existing SSH key mock issue)
• Contabo has no mock fixtures — no test regression possible

Agent: complexity-hunter

🤖 Generated with Claude Code

[louisgv]

Security Review

Verdict: APPROVED

Findings

No security issues found. This refactoring improves code organization while maintaining all existing security patterns.

Changes analyzed:

• Extracted validation logic into _contabo_validate_inputs and _latitude_validate_inputs
• Extracted error checking into _contabo_check_create_error and _latitude_check_create_error
• Extracted instance/server ID extraction into dedicated helpers
• All input validation preserved (validate_resource_name, validate_region_name)
• No command injection vectors introduced
• Python JSON parsing properly isolated
• No credential leaks or logging issues

Tests

• bash -n: PASS (both contabo/lib/common.sh and latitude/lib/common.sh)
• bun test: N/A (no TypeScript changes)
• curl|bash pattern: OK (no changes to source/eval fallback)
• macOS compat: OK (no bash 3.x incompatibilities)

Code Quality

• Improves maintainability by extracting repeated logic
• Better separation of concerns
• Consistent error handling patterns
• No changes to public API surface

---

-- security/pr-reviewer

[la14-1]

Summary

• Extract validation, error handling, and response parsing from create_server in both latitude/lib/common.sh and contabo/lib/common.sh into dedicated helper functions
• Follows the same decomposition pattern established in PR refactor: decompose webdock create_server and koyeb ensure_koyeb_cli into focused helpers #1016 (Webdock/Koyeb)
• Each provider gets 3 new focused helpers: input validation, create-error checking, and response ID extraction

Latitude helpers

• _latitude_validate_inputs — validates plan, site, and OS resource names
• _latitude_check_create_error — checks response and reports failure details
• _latitude_extract_server_id — extracts and exports server ID from response

Contabo helpers

• _contabo_validate_inputs — validates product ID, region, image ID, and period
• _contabo_check_create_error — checks response and reports failure details
• _contabo_extract_instance_id — extracts and exports instance ID from response

Test plan

• bash -n latitude/lib/common.sh passes
• bash -n contabo/lib/common.sh passes
• bash test/mock.sh latitude — same results as main (15 passed, 45 failed — pre-existing SSH key mock issue)
• Contabo has no mock fixtures — no test regression possible

Agent: complexity-hunter

🤖 Generated with Claude Code

[louisgv]

Security Review

Verdict: APPROVED

Findings

No security issues found. This refactoring improves code organization while maintaining all existing security patterns.

Changes analyzed:

• Extracted validation logic into _contabo_validate_inputs and _latitude_validate_inputs
• Extracted error checking into _contabo_check_create_error and _latitude_check_create_error
• Extracted instance/server ID extraction into dedicated helpers
• All input validation preserved (validate_resource_name, validate_region_name)
• No command injection vectors introduced
• Python JSON parsing properly isolated
• No credential leaks or logging issues

Tests

• bash -n: PASS (both contabo/lib/common.sh and latitude/lib/common.sh)
• bun test: N/A (no TypeScript changes)
• curl|bash pattern: OK (no changes to source/eval fallback)
• macOS compat: OK (no bash 3.x incompatibilities)

Code Quality

• Improves maintainability by extracting repeated logic
• Better separation of concerns
• Consistent error handling patterns
• No changes to public API surface

---

-- security/pr-reviewer