fix(ux): add post-session summary to Alibaba Cloud and GCP

[la14-1]

Summary

• Alibaba Cloud and GCP both had custom interactive_session() functions that called ssh directly, bypassing the shared ssh_interactive_session helper which shows the post-session "your server is still running" warning
• Users ending sessions on these clouds got no reminder to delete their server, risking ongoing charges
• Both clouds were also missing SPAWN_DASHBOARD_URL, so even if the summary were shown, it would display a generic message instead of a clickable dashboard link

Changes

• alibabacloud/lib/common.sh: Replace 3 custom SSH functions (run_server, upload_file, interactive_session) with shared helper delegates; add SPAWN_DASHBOARD_URL pointing to ECS console
• gcp/lib/common.sh: Set SSH_USER="${GCP_USERNAME}" so shared helpers use the correct username; replace 4 custom SSH functions with shared helper delegates; add SPAWN_DASHBOARD_URL pointing to Compute Engine console

Test plan

• bash -n syntax check passes on both modified files
• All 105 post-session tests pass (including the SPAWN_DASHBOARD_URL convention tests which now auto-discover both clouds)
• Pre-existing CodeSandbox test failures are unrelated (also fail on main)

-- refactor/ux-engineer

[la14-1]

The Mock Test failure here is the same pre-existing issue (missing Civo/Hetzner/Scaleway fixtures) affecting all branches. See #1050 for the fix — once that merges, rebasing this PR should make CI green.

-- refactor/pr-maintainer

[louisgv]

Security Review

Verdict: APPROVED

Findings

No security issues found.

Analysis

• Alibaba Cloud: Replaced inline upload_file, run_server, interactive_session (all using root@ directly) with delegates to shared ssh_run_server, ssh_upload_file, ssh_interactive_session. Since SSH_USER is unset, defaults to root — identical behavior. Added static SPAWN_DASHBOARD_URL.
• GCP: Replaced inline SSH functions (using ${GCP_USERNAME}@) with shared helpers. SSH_USER="${GCP_USERNAME}" is set at module level, ensuring correct non-root username. wait_for_cloud_init updated to use ssh_verify_connectivity for the first phase — same semantics. Added static SPAWN_DASHBOARD_URL.
• No new file path handling, credential exposure, or injection vectors introduced.
• The refactoring is a pure DRY improvement delegating to well-tested shared helpers.

Tests

• bash -n: PASS (both files), bun test: N/A (no TS changes), curl|bash: OK (source fallback pattern unchanged), macOS compat: OK (no incompatible constructs)

---

-- security/pr-reviewer

[la14-1]

Summary

• Alibaba Cloud and GCP both had custom interactive_session() functions that called ssh directly, bypassing the shared ssh_interactive_session helper which shows the post-session "your server is still running" warning
• Users ending sessions on these clouds got no reminder to delete their server, risking ongoing charges
• Both clouds were also missing SPAWN_DASHBOARD_URL, so even if the summary were shown, it would display a generic message instead of a clickable dashboard link

Changes

• alibabacloud/lib/common.sh: Replace 3 custom SSH functions (run_server, upload_file, interactive_session) with shared helper delegates; add SPAWN_DASHBOARD_URL pointing to ECS console
• gcp/lib/common.sh: Set SSH_USER="${GCP_USERNAME}" so shared helpers use the correct username; replace 4 custom SSH functions with shared helper delegates; add SPAWN_DASHBOARD_URL pointing to Compute Engine console

Test plan

• bash -n syntax check passes on both modified files
• All 105 post-session tests pass (including the SPAWN_DASHBOARD_URL convention tests which now auto-discover both clouds)
• Pre-existing CodeSandbox test failures are unrelated (also fail on main)

-- refactor/ux-engineer

[la14-1]

The Mock Test failure here is the same pre-existing issue (missing Civo/Hetzner/Scaleway fixtures) affecting all branches. See #1050 for the fix — once that merges, rebasing this PR should make CI green.

-- refactor/pr-maintainer

[louisgv]

Security Review

Verdict: APPROVED

Findings

No security issues found.

Analysis

• Alibaba Cloud: Replaced inline upload_file, run_server, interactive_session (all using root@ directly) with delegates to shared ssh_run_server, ssh_upload_file, ssh_interactive_session. Since SSH_USER is unset, defaults to root — identical behavior. Added static SPAWN_DASHBOARD_URL.
• GCP: Replaced inline SSH functions (using ${GCP_USERNAME}@) with shared helpers. SSH_USER="${GCP_USERNAME}" is set at module level, ensuring correct non-root username. wait_for_cloud_init updated to use ssh_verify_connectivity for the first phase — same semantics. Added static SPAWN_DASHBOARD_URL.
• No new file path handling, credential exposure, or injection vectors introduced.
• The refactoring is a pure DRY improvement delegating to well-tested shared helpers.

Tests

• bash -n: PASS (both files), bun test: N/A (no TS changes), curl|bash: OK (source fallback pattern unchanged), macOS compat: OK (no incompatible constructs)

---

-- security/pr-reviewer

[la14-1]

Summary

• Alibaba Cloud and GCP both had custom interactive_session() functions that called ssh directly, bypassing the shared ssh_interactive_session helper which shows the post-session "your server is still running" warning
• Users ending sessions on these clouds got no reminder to delete their server, risking ongoing charges
• Both clouds were also missing SPAWN_DASHBOARD_URL, so even if the summary were shown, it would display a generic message instead of a clickable dashboard link

Changes

• alibabacloud/lib/common.sh: Replace 3 custom SSH functions (run_server, upload_file, interactive_session) with shared helper delegates; add SPAWN_DASHBOARD_URL pointing to ECS console
• gcp/lib/common.sh: Set SSH_USER="${GCP_USERNAME}" so shared helpers use the correct username; replace 4 custom SSH functions with shared helper delegates; add SPAWN_DASHBOARD_URL pointing to Compute Engine console

Test plan

• bash -n syntax check passes on both modified files
• All 105 post-session tests pass (including the SPAWN_DASHBOARD_URL convention tests which now auto-discover both clouds)
• Pre-existing CodeSandbox test failures are unrelated (also fail on main)

-- refactor/ux-engineer

[la14-1]

The Mock Test failure here is the same pre-existing issue (missing Civo/Hetzner/Scaleway fixtures) affecting all branches. See #1050 for the fix — once that merges, rebasing this PR should make CI green.

-- refactor/pr-maintainer

[louisgv]

Security Review

Verdict: APPROVED

Findings

No security issues found.

Analysis

• Alibaba Cloud: Replaced inline upload_file, run_server, interactive_session (all using root@ directly) with delegates to shared ssh_run_server, ssh_upload_file, ssh_interactive_session. Since SSH_USER is unset, defaults to root — identical behavior. Added static SPAWN_DASHBOARD_URL.
• GCP: Replaced inline SSH functions (using ${GCP_USERNAME}@) with shared helpers. SSH_USER="${GCP_USERNAME}" is set at module level, ensuring correct non-root username. wait_for_cloud_init updated to use ssh_verify_connectivity for the first phase — same semantics. Added static SPAWN_DASHBOARD_URL.
• No new file path handling, credential exposure, or injection vectors introduced.
• The refactoring is a pure DRY improvement delegating to well-tested shared helpers.

Tests

• bash -n: PASS (both files), bun test: N/A (no TS changes), curl|bash: OK (source fallback pattern unchanged), macOS compat: OK (no incompatible constructs)

---

-- security/pr-reviewer

[la14-1]

Summary

• Alibaba Cloud and GCP both had custom interactive_session() functions that called ssh directly, bypassing the shared ssh_interactive_session helper which shows the post-session "your server is still running" warning
• Users ending sessions on these clouds got no reminder to delete their server, risking ongoing charges
• Both clouds were also missing SPAWN_DASHBOARD_URL, so even if the summary were shown, it would display a generic message instead of a clickable dashboard link

Changes

• alibabacloud/lib/common.sh: Replace 3 custom SSH functions (run_server, upload_file, interactive_session) with shared helper delegates; add SPAWN_DASHBOARD_URL pointing to ECS console
• gcp/lib/common.sh: Set SSH_USER="${GCP_USERNAME}" so shared helpers use the correct username; replace 4 custom SSH functions with shared helper delegates; add SPAWN_DASHBOARD_URL pointing to Compute Engine console

Test plan

• bash -n syntax check passes on both modified files
• All 105 post-session tests pass (including the SPAWN_DASHBOARD_URL convention tests which now auto-discover both clouds)
• Pre-existing CodeSandbox test failures are unrelated (also fail on main)

-- refactor/ux-engineer

[la14-1]

The Mock Test failure here is the same pre-existing issue (missing Civo/Hetzner/Scaleway fixtures) affecting all branches. See #1050 for the fix — once that merges, rebasing this PR should make CI green.

-- refactor/pr-maintainer

[louisgv]

Security Review

Verdict: APPROVED

Findings

No security issues found.

Analysis

• Alibaba Cloud: Replaced inline upload_file, run_server, interactive_session (all using root@ directly) with delegates to shared ssh_run_server, ssh_upload_file, ssh_interactive_session. Since SSH_USER is unset, defaults to root — identical behavior. Added static SPAWN_DASHBOARD_URL.
• GCP: Replaced inline SSH functions (using ${GCP_USERNAME}@) with shared helpers. SSH_USER="${GCP_USERNAME}" is set at module level, ensuring correct non-root username. wait_for_cloud_init updated to use ssh_verify_connectivity for the first phase — same semantics. Added static SPAWN_DASHBOARD_URL.
• No new file path handling, credential exposure, or injection vectors introduced.
• The refactoring is a pure DRY improvement delegating to well-tested shared helpers.

Tests

• bash -n: PASS (both files), bun test: N/A (no TS changes), curl|bash: OK (source fallback pattern unchanged), macOS compat: OK (no incompatible constructs)

---

-- security/pr-reviewer

[la14-1]

Summary

• Alibaba Cloud and GCP both had custom interactive_session() functions that called ssh directly, bypassing the shared ssh_interactive_session helper which shows the post-session "your server is still running" warning
• Users ending sessions on these clouds got no reminder to delete their server, risking ongoing charges
• Both clouds were also missing SPAWN_DASHBOARD_URL, so even if the summary were shown, it would display a generic message instead of a clickable dashboard link

Changes

• alibabacloud/lib/common.sh: Replace 3 custom SSH functions (run_server, upload_file, interactive_session) with shared helper delegates; add SPAWN_DASHBOARD_URL pointing to ECS console
• gcp/lib/common.sh: Set SSH_USER="${GCP_USERNAME}" so shared helpers use the correct username; replace 4 custom SSH functions with shared helper delegates; add SPAWN_DASHBOARD_URL pointing to Compute Engine console

Test plan

• bash -n syntax check passes on both modified files
• All 105 post-session tests pass (including the SPAWN_DASHBOARD_URL convention tests which now auto-discover both clouds)
• Pre-existing CodeSandbox test failures are unrelated (also fail on main)

-- refactor/ux-engineer

[la14-1]

The Mock Test failure here is the same pre-existing issue (missing Civo/Hetzner/Scaleway fixtures) affecting all branches. See #1050 for the fix — once that merges, rebasing this PR should make CI green.

-- refactor/pr-maintainer

[louisgv]

Security Review

Verdict: APPROVED

Findings

No security issues found.

Analysis

• Alibaba Cloud: Replaced inline upload_file, run_server, interactive_session (all using root@ directly) with delegates to shared ssh_run_server, ssh_upload_file, ssh_interactive_session. Since SSH_USER is unset, defaults to root — identical behavior. Added static SPAWN_DASHBOARD_URL.
• GCP: Replaced inline SSH functions (using ${GCP_USERNAME}@) with shared helpers. SSH_USER="${GCP_USERNAME}" is set at module level, ensuring correct non-root username. wait_for_cloud_init updated to use ssh_verify_connectivity for the first phase — same semantics. Added static SPAWN_DASHBOARD_URL.
• No new file path handling, credential exposure, or injection vectors introduced.
• The refactoring is a pure DRY improvement delegating to well-tested shared helpers.

Tests

• bash -n: PASS (both files), bun test: N/A (no TS changes), curl|bash: OK (source fallback pattern unchanged), macOS compat: OK (no incompatible constructs)

---

-- security/pr-reviewer

[la14-1]

Summary

• Alibaba Cloud and GCP both had custom interactive_session() functions that called ssh directly, bypassing the shared ssh_interactive_session helper which shows the post-session "your server is still running" warning
• Users ending sessions on these clouds got no reminder to delete their server, risking ongoing charges
• Both clouds were also missing SPAWN_DASHBOARD_URL, so even if the summary were shown, it would display a generic message instead of a clickable dashboard link

Changes

• alibabacloud/lib/common.sh: Replace 3 custom SSH functions (run_server, upload_file, interactive_session) with shared helper delegates; add SPAWN_DASHBOARD_URL pointing to ECS console
• gcp/lib/common.sh: Set SSH_USER="${GCP_USERNAME}" so shared helpers use the correct username; replace 4 custom SSH functions with shared helper delegates; add SPAWN_DASHBOARD_URL pointing to Compute Engine console

Test plan

• bash -n syntax check passes on both modified files
• All 105 post-session tests pass (including the SPAWN_DASHBOARD_URL convention tests which now auto-discover both clouds)
• Pre-existing CodeSandbox test failures are unrelated (also fail on main)

-- refactor/ux-engineer

[la14-1]

The Mock Test failure here is the same pre-existing issue (missing Civo/Hetzner/Scaleway fixtures) affecting all branches. See #1050 for the fix — once that merges, rebasing this PR should make CI green.

-- refactor/pr-maintainer

[louisgv]

Security Review

Verdict: APPROVED

Findings

No security issues found.

Analysis

• Alibaba Cloud: Replaced inline upload_file, run_server, interactive_session (all using root@ directly) with delegates to shared ssh_run_server, ssh_upload_file, ssh_interactive_session. Since SSH_USER is unset, defaults to root — identical behavior. Added static SPAWN_DASHBOARD_URL.
• GCP: Replaced inline SSH functions (using ${GCP_USERNAME}@) with shared helpers. SSH_USER="${GCP_USERNAME}" is set at module level, ensuring correct non-root username. wait_for_cloud_init updated to use ssh_verify_connectivity for the first phase — same semantics. Added static SPAWN_DASHBOARD_URL.
• No new file path handling, credential exposure, or injection vectors introduced.
• The refactoring is a pure DRY improvement delegating to well-tested shared helpers.

Tests

• bash -n: PASS (both files), bun test: N/A (no TS changes), curl|bash: OK (source fallback pattern unchanged), macOS compat: OK (no incompatible constructs)

---

-- security/pr-reviewer

[la14-1]

Summary

• Alibaba Cloud and GCP both had custom interactive_session() functions that called ssh directly, bypassing the shared ssh_interactive_session helper which shows the post-session "your server is still running" warning
• Users ending sessions on these clouds got no reminder to delete their server, risking ongoing charges
• Both clouds were also missing SPAWN_DASHBOARD_URL, so even if the summary were shown, it would display a generic message instead of a clickable dashboard link

Changes

• alibabacloud/lib/common.sh: Replace 3 custom SSH functions (run_server, upload_file, interactive_session) with shared helper delegates; add SPAWN_DASHBOARD_URL pointing to ECS console
• gcp/lib/common.sh: Set SSH_USER="${GCP_USERNAME}" so shared helpers use the correct username; replace 4 custom SSH functions with shared helper delegates; add SPAWN_DASHBOARD_URL pointing to Compute Engine console

Test plan

• bash -n syntax check passes on both modified files
• All 105 post-session tests pass (including the SPAWN_DASHBOARD_URL convention tests which now auto-discover both clouds)
• Pre-existing CodeSandbox test failures are unrelated (also fail on main)

-- refactor/ux-engineer

[la14-1]

The Mock Test failure here is the same pre-existing issue (missing Civo/Hetzner/Scaleway fixtures) affecting all branches. See #1050 for the fix — once that merges, rebasing this PR should make CI green.

-- refactor/pr-maintainer

[louisgv]

Security Review

Verdict: APPROVED

Findings

No security issues found.

Analysis

• Alibaba Cloud: Replaced inline upload_file, run_server, interactive_session (all using root@ directly) with delegates to shared ssh_run_server, ssh_upload_file, ssh_interactive_session. Since SSH_USER is unset, defaults to root — identical behavior. Added static SPAWN_DASHBOARD_URL.
• GCP: Replaced inline SSH functions (using ${GCP_USERNAME}@) with shared helpers. SSH_USER="${GCP_USERNAME}" is set at module level, ensuring correct non-root username. wait_for_cloud_init updated to use ssh_verify_connectivity for the first phase — same semantics. Added static SPAWN_DASHBOARD_URL.
• No new file path handling, credential exposure, or injection vectors introduced.
• The refactoring is a pure DRY improvement delegating to well-tested shared helpers.

Tests

• bash -n: PASS (both files), bun test: N/A (no TS changes), curl|bash: OK (source fallback pattern unchanged), macOS compat: OK (no incompatible constructs)

---

-- security/pr-reviewer

[la14-1]

Summary

• Alibaba Cloud and GCP both had custom interactive_session() functions that called ssh directly, bypassing the shared ssh_interactive_session helper which shows the post-session "your server is still running" warning
• Users ending sessions on these clouds got no reminder to delete their server, risking ongoing charges
• Both clouds were also missing SPAWN_DASHBOARD_URL, so even if the summary were shown, it would display a generic message instead of a clickable dashboard link

Changes

• alibabacloud/lib/common.sh: Replace 3 custom SSH functions (run_server, upload_file, interactive_session) with shared helper delegates; add SPAWN_DASHBOARD_URL pointing to ECS console
• gcp/lib/common.sh: Set SSH_USER="${GCP_USERNAME}" so shared helpers use the correct username; replace 4 custom SSH functions with shared helper delegates; add SPAWN_DASHBOARD_URL pointing to Compute Engine console

Test plan

• bash -n syntax check passes on both modified files
• All 105 post-session tests pass (including the SPAWN_DASHBOARD_URL convention tests which now auto-discover both clouds)
• Pre-existing CodeSandbox test failures are unrelated (also fail on main)

-- refactor/ux-engineer

[la14-1]

The Mock Test failure here is the same pre-existing issue (missing Civo/Hetzner/Scaleway fixtures) affecting all branches. See #1050 for the fix — once that merges, rebasing this PR should make CI green.

-- refactor/pr-maintainer

[louisgv]

Security Review

Verdict: APPROVED

Findings

No security issues found.

Analysis

• Alibaba Cloud: Replaced inline upload_file, run_server, interactive_session (all using root@ directly) with delegates to shared ssh_run_server, ssh_upload_file, ssh_interactive_session. Since SSH_USER is unset, defaults to root — identical behavior. Added static SPAWN_DASHBOARD_URL.
• GCP: Replaced inline SSH functions (using ${GCP_USERNAME}@) with shared helpers. SSH_USER="${GCP_USERNAME}" is set at module level, ensuring correct non-root username. wait_for_cloud_init updated to use ssh_verify_connectivity for the first phase — same semantics. Added static SPAWN_DASHBOARD_URL.
• No new file path handling, credential exposure, or injection vectors introduced.
• The refactoring is a pure DRY improvement delegating to well-tested shared helpers.

Tests

• bash -n: PASS (both files), bun test: N/A (no TS changes), curl|bash: OK (source fallback pattern unchanged), macOS compat: OK (no incompatible constructs)

---

-- security/pr-reviewer