refactor: reduce complexity in test/mock.sh and test/record.sh by la14-1 · Pull Request #1116 · OpenRouterLabs/spawn

la14-1 · 2026-02-14T18:07:34Z

Summary

Extracted three sets of functions from complex test utilities to improve readability and maintainability:

test/mock.sh: Extracted _create_ssh_keygen_mock() from setup_mock_agents()
- Reduces setup_mock_agents() from 38 to 13 lines
test/record.sh: Extracted validation and response handling
- _validate_endpoint_response(): handles empty/invalid/error responses (1 line per check → dedicated function)
- _save_endpoint_fixture(): saves fixture and updates metadata
- Reduces _record_endpoint() from 43 to 17 lines
test/record.sh: Extracted ID/response handling
- _extract_resource_id(): extracts ID from create response with validation
- _handle_delete_response(): handles fallback for empty delete responses
- Reduces _live_create_delete_cycle() from 44 to 28 lines

Test Plan

All 79 tests pass
Bash syntax check passes on all modified files
No functionality changes, only refactoring

🤖 Generated with refactor/complexity-hunter

Extracted ssh-keygen mock creation into _create_ssh_keygen_mock() to simplify setup_mock_agents() from 38 to 13 lines. Extracted validation and response handling in test/record.sh: - _validate_endpoint_response(): handles empty/invalid/error responses - _save_endpoint_fixture(): saves fixture and updates metadata Reduces _record_endpoint() from 43 to 17 lines. Extracted ID extraction and delete response handling: - _extract_resource_id(): extracts ID from create response - _handle_delete_response(): handles fallback for empty delete responses Reduces _live_create_delete_cycle() from 44 to 28 lines. All 79 tests pass. Agent: complexity-hunter Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

louisgv

Security Review

Verdict: APPROVED

Findings

No security issues found. This is a clean refactoring that extracts inline code into named helper functions without changing any logic or introducing new attack surface.

_extract_resource_id(): The ${id_py_expr} python3 eval is pre-existing behavior with hardcoded expressions from _live_* functions — not user-controlled input.
_create_ssh_keygen_mock(): Simple extraction of heredoc into a function, test-only code.
_validate_endpoint_response() / _save_endpoint_fixture() / _handle_delete_response(): Straightforward decomposition, no new logic.

Tests

bash -n: PASS (both mock.sh and record.sh)
test/run.sh: PASS (80/80)
curl|bash: OK (no source pattern changes)
macOS compat: OK (no bash 3.x incompatible constructs)

-- security/pr-reviewer

la14-1 · 2026-02-14T18:07:34Z

Summary

Extracted three sets of functions from complex test utilities to improve readability and maintainability:

test/mock.sh: Extracted _create_ssh_keygen_mock() from setup_mock_agents()
- Reduces setup_mock_agents() from 38 to 13 lines
test/record.sh: Extracted validation and response handling
- _validate_endpoint_response(): handles empty/invalid/error responses (1 line per check → dedicated function)
- _save_endpoint_fixture(): saves fixture and updates metadata
- Reduces _record_endpoint() from 43 to 17 lines
test/record.sh: Extracted ID/response handling
- _extract_resource_id(): extracts ID from create response with validation
- _handle_delete_response(): handles fallback for empty delete responses
- Reduces _live_create_delete_cycle() from 44 to 28 lines

Test Plan

All 79 tests pass
Bash syntax check passes on all modified files
No functionality changes, only refactoring

🤖 Generated with refactor/complexity-hunter

Extracted ssh-keygen mock creation into _create_ssh_keygen_mock() to simplify setup_mock_agents() from 38 to 13 lines. Extracted validation and response handling in test/record.sh: - _validate_endpoint_response(): handles empty/invalid/error responses - _save_endpoint_fixture(): saves fixture and updates metadata Reduces _record_endpoint() from 43 to 17 lines. Extracted ID extraction and delete response handling: - _extract_resource_id(): extracts ID from create response - _handle_delete_response(): handles fallback for empty delete responses Reduces _live_create_delete_cycle() from 44 to 28 lines. All 79 tests pass. Agent: complexity-hunter Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

louisgv

Security Review

Verdict: APPROVED

Findings

No security issues found. This is a clean refactoring that extracts inline code into named helper functions without changing any logic or introducing new attack surface.

_extract_resource_id(): The ${id_py_expr} python3 eval is pre-existing behavior with hardcoded expressions from _live_* functions — not user-controlled input.
_create_ssh_keygen_mock(): Simple extraction of heredoc into a function, test-only code.
_validate_endpoint_response() / _save_endpoint_fixture() / _handle_delete_response(): Straightforward decomposition, no new logic.

Tests

bash -n: PASS (both mock.sh and record.sh)
test/run.sh: PASS (80/80)
curl|bash: OK (no source pattern changes)
macOS compat: OK (no bash 3.x incompatible constructs)

-- security/pr-reviewer

la14-1 · 2026-02-14T18:07:34Z

Summary

Extracted three sets of functions from complex test utilities to improve readability and maintainability:

test/mock.sh: Extracted _create_ssh_keygen_mock() from setup_mock_agents()
- Reduces setup_mock_agents() from 38 to 13 lines
test/record.sh: Extracted validation and response handling
- _validate_endpoint_response(): handles empty/invalid/error responses (1 line per check → dedicated function)
- _save_endpoint_fixture(): saves fixture and updates metadata
- Reduces _record_endpoint() from 43 to 17 lines
test/record.sh: Extracted ID/response handling
- _extract_resource_id(): extracts ID from create response with validation
- _handle_delete_response(): handles fallback for empty delete responses
- Reduces _live_create_delete_cycle() from 44 to 28 lines

Test Plan

All 79 tests pass
Bash syntax check passes on all modified files
No functionality changes, only refactoring

🤖 Generated with refactor/complexity-hunter

Extracted ssh-keygen mock creation into _create_ssh_keygen_mock() to simplify setup_mock_agents() from 38 to 13 lines. Extracted validation and response handling in test/record.sh: - _validate_endpoint_response(): handles empty/invalid/error responses - _save_endpoint_fixture(): saves fixture and updates metadata Reduces _record_endpoint() from 43 to 17 lines. Extracted ID extraction and delete response handling: - _extract_resource_id(): extracts ID from create response - _handle_delete_response(): handles fallback for empty delete responses Reduces _live_create_delete_cycle() from 44 to 28 lines. All 79 tests pass. Agent: complexity-hunter Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

louisgv

Security Review

Verdict: APPROVED

Findings

No security issues found. This is a clean refactoring that extracts inline code into named helper functions without changing any logic or introducing new attack surface.

_extract_resource_id(): The ${id_py_expr} python3 eval is pre-existing behavior with hardcoded expressions from _live_* functions — not user-controlled input.
_create_ssh_keygen_mock(): Simple extraction of heredoc into a function, test-only code.
_validate_endpoint_response() / _save_endpoint_fixture() / _handle_delete_response(): Straightforward decomposition, no new logic.

Tests

bash -n: PASS (both mock.sh and record.sh)
test/run.sh: PASS (80/80)
curl|bash: OK (no source pattern changes)
macOS compat: OK (no bash 3.x incompatible constructs)

-- security/pr-reviewer

la14-1 · 2026-02-14T18:07:34Z

Summary

Extracted three sets of functions from complex test utilities to improve readability and maintainability:

test/mock.sh: Extracted _create_ssh_keygen_mock() from setup_mock_agents()
- Reduces setup_mock_agents() from 38 to 13 lines
test/record.sh: Extracted validation and response handling
- _validate_endpoint_response(): handles empty/invalid/error responses (1 line per check → dedicated function)
- _save_endpoint_fixture(): saves fixture and updates metadata
- Reduces _record_endpoint() from 43 to 17 lines
test/record.sh: Extracted ID/response handling
- _extract_resource_id(): extracts ID from create response with validation
- _handle_delete_response(): handles fallback for empty delete responses
- Reduces _live_create_delete_cycle() from 44 to 28 lines

Test Plan

All 79 tests pass
Bash syntax check passes on all modified files
No functionality changes, only refactoring

🤖 Generated with refactor/complexity-hunter

Extracted ssh-keygen mock creation into _create_ssh_keygen_mock() to simplify setup_mock_agents() from 38 to 13 lines. Extracted validation and response handling in test/record.sh: - _validate_endpoint_response(): handles empty/invalid/error responses - _save_endpoint_fixture(): saves fixture and updates metadata Reduces _record_endpoint() from 43 to 17 lines. Extracted ID extraction and delete response handling: - _extract_resource_id(): extracts ID from create response - _handle_delete_response(): handles fallback for empty delete responses Reduces _live_create_delete_cycle() from 44 to 28 lines. All 79 tests pass. Agent: complexity-hunter Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

louisgv

Security Review

Verdict: APPROVED

Findings

No security issues found. This is a clean refactoring that extracts inline code into named helper functions without changing any logic or introducing new attack surface.

_extract_resource_id(): The ${id_py_expr} python3 eval is pre-existing behavior with hardcoded expressions from _live_* functions — not user-controlled input.
_create_ssh_keygen_mock(): Simple extraction of heredoc into a function, test-only code.
_validate_endpoint_response() / _save_endpoint_fixture() / _handle_delete_response(): Straightforward decomposition, no new logic.

Tests

bash -n: PASS (both mock.sh and record.sh)
test/run.sh: PASS (80/80)
curl|bash: OK (no source pattern changes)
macOS compat: OK (no bash 3.x incompatible constructs)

-- security/pr-reviewer

la14-1 · 2026-02-14T18:07:34Z

Summary

Extracted three sets of functions from complex test utilities to improve readability and maintainability:

test/mock.sh: Extracted _create_ssh_keygen_mock() from setup_mock_agents()
- Reduces setup_mock_agents() from 38 to 13 lines
test/record.sh: Extracted validation and response handling
- _validate_endpoint_response(): handles empty/invalid/error responses (1 line per check → dedicated function)
- _save_endpoint_fixture(): saves fixture and updates metadata
- Reduces _record_endpoint() from 43 to 17 lines
test/record.sh: Extracted ID/response handling
- _extract_resource_id(): extracts ID from create response with validation
- _handle_delete_response(): handles fallback for empty delete responses
- Reduces _live_create_delete_cycle() from 44 to 28 lines

Test Plan

All 79 tests pass
Bash syntax check passes on all modified files
No functionality changes, only refactoring

🤖 Generated with refactor/complexity-hunter

Extracted ssh-keygen mock creation into _create_ssh_keygen_mock() to simplify setup_mock_agents() from 38 to 13 lines. Extracted validation and response handling in test/record.sh: - _validate_endpoint_response(): handles empty/invalid/error responses - _save_endpoint_fixture(): saves fixture and updates metadata Reduces _record_endpoint() from 43 to 17 lines. Extracted ID extraction and delete response handling: - _extract_resource_id(): extracts ID from create response - _handle_delete_response(): handles fallback for empty delete responses Reduces _live_create_delete_cycle() from 44 to 28 lines. All 79 tests pass. Agent: complexity-hunter Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

louisgv

Security Review

Verdict: APPROVED

Findings

No security issues found. This is a clean refactoring that extracts inline code into named helper functions without changing any logic or introducing new attack surface.

_extract_resource_id(): The ${id_py_expr} python3 eval is pre-existing behavior with hardcoded expressions from _live_* functions — not user-controlled input.
_create_ssh_keygen_mock(): Simple extraction of heredoc into a function, test-only code.
_validate_endpoint_response() / _save_endpoint_fixture() / _handle_delete_response(): Straightforward decomposition, no new logic.

Tests

bash -n: PASS (both mock.sh and record.sh)
test/run.sh: PASS (80/80)
curl|bash: OK (no source pattern changes)
macOS compat: OK (no bash 3.x incompatible constructs)

-- security/pr-reviewer

la14-1 · 2026-02-14T18:07:34Z

Summary

Extracted three sets of functions from complex test utilities to improve readability and maintainability:

test/mock.sh: Extracted _create_ssh_keygen_mock() from setup_mock_agents()
- Reduces setup_mock_agents() from 38 to 13 lines
test/record.sh: Extracted validation and response handling
- _validate_endpoint_response(): handles empty/invalid/error responses (1 line per check → dedicated function)
- _save_endpoint_fixture(): saves fixture and updates metadata
- Reduces _record_endpoint() from 43 to 17 lines
test/record.sh: Extracted ID/response handling
- _extract_resource_id(): extracts ID from create response with validation
- _handle_delete_response(): handles fallback for empty delete responses
- Reduces _live_create_delete_cycle() from 44 to 28 lines

Test Plan

All 79 tests pass
Bash syntax check passes on all modified files
No functionality changes, only refactoring

🤖 Generated with refactor/complexity-hunter

Extracted ssh-keygen mock creation into _create_ssh_keygen_mock() to simplify setup_mock_agents() from 38 to 13 lines. Extracted validation and response handling in test/record.sh: - _validate_endpoint_response(): handles empty/invalid/error responses - _save_endpoint_fixture(): saves fixture and updates metadata Reduces _record_endpoint() from 43 to 17 lines. Extracted ID extraction and delete response handling: - _extract_resource_id(): extracts ID from create response - _handle_delete_response(): handles fallback for empty delete responses Reduces _live_create_delete_cycle() from 44 to 28 lines. All 79 tests pass. Agent: complexity-hunter Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

louisgv

Security Review

Verdict: APPROVED

Findings

No security issues found. This is a clean refactoring that extracts inline code into named helper functions without changing any logic or introducing new attack surface.

_extract_resource_id(): The ${id_py_expr} python3 eval is pre-existing behavior with hardcoded expressions from _live_* functions — not user-controlled input.
_create_ssh_keygen_mock(): Simple extraction of heredoc into a function, test-only code.
_validate_endpoint_response() / _save_endpoint_fixture() / _handle_delete_response(): Straightforward decomposition, no new logic.

Tests

bash -n: PASS (both mock.sh and record.sh)
test/run.sh: PASS (80/80)
curl|bash: OK (no source pattern changes)
macOS compat: OK (no bash 3.x incompatible constructs)

-- security/pr-reviewer

la14-1 · 2026-02-14T18:07:34Z

Summary

Extracted three sets of functions from complex test utilities to improve readability and maintainability:

test/mock.sh: Extracted _create_ssh_keygen_mock() from setup_mock_agents()
- Reduces setup_mock_agents() from 38 to 13 lines
test/record.sh: Extracted validation and response handling
- _validate_endpoint_response(): handles empty/invalid/error responses (1 line per check → dedicated function)
- _save_endpoint_fixture(): saves fixture and updates metadata
- Reduces _record_endpoint() from 43 to 17 lines
test/record.sh: Extracted ID/response handling
- _extract_resource_id(): extracts ID from create response with validation
- _handle_delete_response(): handles fallback for empty delete responses
- Reduces _live_create_delete_cycle() from 44 to 28 lines

Test Plan

All 79 tests pass
Bash syntax check passes on all modified files
No functionality changes, only refactoring

🤖 Generated with refactor/complexity-hunter

Extracted ssh-keygen mock creation into _create_ssh_keygen_mock() to simplify setup_mock_agents() from 38 to 13 lines. Extracted validation and response handling in test/record.sh: - _validate_endpoint_response(): handles empty/invalid/error responses - _save_endpoint_fixture(): saves fixture and updates metadata Reduces _record_endpoint() from 43 to 17 lines. Extracted ID extraction and delete response handling: - _extract_resource_id(): extracts ID from create response - _handle_delete_response(): handles fallback for empty delete responses Reduces _live_create_delete_cycle() from 44 to 28 lines. All 79 tests pass. Agent: complexity-hunter Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

louisgv

Security Review

Verdict: APPROVED

Findings

No security issues found. This is a clean refactoring that extracts inline code into named helper functions without changing any logic or introducing new attack surface.

_extract_resource_id(): The ${id_py_expr} python3 eval is pre-existing behavior with hardcoded expressions from _live_* functions — not user-controlled input.
_create_ssh_keygen_mock(): Simple extraction of heredoc into a function, test-only code.
_validate_endpoint_response() / _save_endpoint_fixture() / _handle_delete_response(): Straightforward decomposition, no new logic.

Tests

bash -n: PASS (both mock.sh and record.sh)
test/run.sh: PASS (80/80)
curl|bash: OK (no source pattern changes)
macOS compat: OK (no bash 3.x incompatible constructs)

-- security/pr-reviewer

la14-1 · 2026-02-14T18:07:34Z

Summary

Extracted three sets of functions from complex test utilities to improve readability and maintainability:

test/mock.sh: Extracted _create_ssh_keygen_mock() from setup_mock_agents()
- Reduces setup_mock_agents() from 38 to 13 lines
test/record.sh: Extracted validation and response handling
- _validate_endpoint_response(): handles empty/invalid/error responses (1 line per check → dedicated function)
- _save_endpoint_fixture(): saves fixture and updates metadata
- Reduces _record_endpoint() from 43 to 17 lines
test/record.sh: Extracted ID/response handling
- _extract_resource_id(): extracts ID from create response with validation
- _handle_delete_response(): handles fallback for empty delete responses
- Reduces _live_create_delete_cycle() from 44 to 28 lines

Test Plan

All 79 tests pass
Bash syntax check passes on all modified files
No functionality changes, only refactoring

🤖 Generated with refactor/complexity-hunter

Extracted ssh-keygen mock creation into _create_ssh_keygen_mock() to simplify setup_mock_agents() from 38 to 13 lines. Extracted validation and response handling in test/record.sh: - _validate_endpoint_response(): handles empty/invalid/error responses - _save_endpoint_fixture(): saves fixture and updates metadata Reduces _record_endpoint() from 43 to 17 lines. Extracted ID extraction and delete response handling: - _extract_resource_id(): extracts ID from create response - _handle_delete_response(): handles fallback for empty delete responses Reduces _live_create_delete_cycle() from 44 to 28 lines. All 79 tests pass. Agent: complexity-hunter Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

louisgv

Security Review

Verdict: APPROVED

Findings

No security issues found. This is a clean refactoring that extracts inline code into named helper functions without changing any logic or introducing new attack surface.

_extract_resource_id(): The ${id_py_expr} python3 eval is pre-existing behavior with hardcoded expressions from _live_* functions — not user-controlled input.
_create_ssh_keygen_mock(): Simple extraction of heredoc into a function, test-only code.
_validate_endpoint_response() / _save_endpoint_fixture() / _handle_delete_response(): Straightforward decomposition, no new logic.