Reduce complexity in test/mock.sh and discovery.sh

[la14-1]

Summary

Refactored two functions with significant complexity issues:

1. test/mock.sh: _validate_body() (93 → 35 lines)

   • Extracted 60+ line nested case statement into _get_required_fields()
   • Uses pattern matching on "cloud:endpoint" for cleaner lookups
   • Improves readability and maintainability

2. .claude/skills/setup-agent-team/discovery.sh: build_team_prompt() (162 → 6 lines)

   • Extracted massive heredoc into external discovery-team-prompt.txt file
   • Function now simply loads and cats the template
   • Makes discovery.sh easier to maintain and modify

Testing

• All 80 bash tests pass
• Syntax validation: bash -n on both modified files passes
• No functional changes - refactoring only

Changes

• Modified: test/mock.sh (function refactoring)
• Modified: .claude/skills/setup-agent-team/discovery.sh (function refactoring)
• Created: .claude/skills/setup-agent-team/discovery-team-prompt.txt (new data file)

Agent: complexity-hunter

Co-Authored-By: Claude Haiku 4.5 noreply@anthropic.com

[louisgv]

Security Review

Verdict: APPROVED

Findings

No security findings.

Summary: Two clean refactoring changes:

1. discovery.sh — Extracts inline heredoc prompt (~155 lines) into discovery-team-prompt.txt and reads it via cat. The file path is derived from $SCRIPT_DIR (safe), and the function fails fast with exit 1 if the file is missing. No injection risk since the file content is used as a prompt template, not executed.
2. test/mock.sh — Extracts the nested case logic in _validate_body() into a helper _get_required_fields(). Pure refactor with identical behavior — the combined ${cloud}:${endpoint} pattern matching is equivalent to the original nested case structure.

Tests

• bash -n: PASS (both changed .sh files), bun test: N/A, curl|bash: OK (discovery.sh is not curl-piped), macOS compat: OK (no bash 3.x incompatibilities introduced)
• Full test suite: 80 passed, 0 failed

---

-- security/pr-reviewer

[la14-1]

Summary

Refactored two functions with significant complexity issues:

1. test/mock.sh: _validate_body() (93 → 35 lines)

   • Extracted 60+ line nested case statement into _get_required_fields()
   • Uses pattern matching on "cloud:endpoint" for cleaner lookups
   • Improves readability and maintainability

2. .claude/skills/setup-agent-team/discovery.sh: build_team_prompt() (162 → 6 lines)

   • Extracted massive heredoc into external discovery-team-prompt.txt file
   • Function now simply loads and cats the template
   • Makes discovery.sh easier to maintain and modify

Testing

• All 80 bash tests pass
• Syntax validation: bash -n on both modified files passes
• No functional changes - refactoring only

Changes

• Modified: test/mock.sh (function refactoring)
• Modified: .claude/skills/setup-agent-team/discovery.sh (function refactoring)
• Created: .claude/skills/setup-agent-team/discovery-team-prompt.txt (new data file)

Agent: complexity-hunter

Co-Authored-By: Claude Haiku 4.5 noreply@anthropic.com

[louisgv]

Security Review

Verdict: APPROVED

Findings

No security findings.

Summary: Two clean refactoring changes:

1. discovery.sh — Extracts inline heredoc prompt (~155 lines) into discovery-team-prompt.txt and reads it via cat. The file path is derived from $SCRIPT_DIR (safe), and the function fails fast with exit 1 if the file is missing. No injection risk since the file content is used as a prompt template, not executed.
2. test/mock.sh — Extracts the nested case logic in _validate_body() into a helper _get_required_fields(). Pure refactor with identical behavior — the combined ${cloud}:${endpoint} pattern matching is equivalent to the original nested case structure.

Tests

• bash -n: PASS (both changed .sh files), bun test: N/A, curl|bash: OK (discovery.sh is not curl-piped), macOS compat: OK (no bash 3.x incompatibilities introduced)
• Full test suite: 80 passed, 0 failed

---

-- security/pr-reviewer

[la14-1]

Summary

Refactored two functions with significant complexity issues:

1. test/mock.sh: _validate_body() (93 → 35 lines)

   • Extracted 60+ line nested case statement into _get_required_fields()
   • Uses pattern matching on "cloud:endpoint" for cleaner lookups
   • Improves readability and maintainability

2. .claude/skills/setup-agent-team/discovery.sh: build_team_prompt() (162 → 6 lines)

   • Extracted massive heredoc into external discovery-team-prompt.txt file
   • Function now simply loads and cats the template
   • Makes discovery.sh easier to maintain and modify

Testing

• All 80 bash tests pass
• Syntax validation: bash -n on both modified files passes
• No functional changes - refactoring only

Changes

• Modified: test/mock.sh (function refactoring)
• Modified: .claude/skills/setup-agent-team/discovery.sh (function refactoring)
• Created: .claude/skills/setup-agent-team/discovery-team-prompt.txt (new data file)

Agent: complexity-hunter

Co-Authored-By: Claude Haiku 4.5 noreply@anthropic.com

[louisgv]

Security Review

Verdict: APPROVED

Findings

No security findings.

Summary: Two clean refactoring changes:

1. discovery.sh — Extracts inline heredoc prompt (~155 lines) into discovery-team-prompt.txt and reads it via cat. The file path is derived from $SCRIPT_DIR (safe), and the function fails fast with exit 1 if the file is missing. No injection risk since the file content is used as a prompt template, not executed.
2. test/mock.sh — Extracts the nested case logic in _validate_body() into a helper _get_required_fields(). Pure refactor with identical behavior — the combined ${cloud}:${endpoint} pattern matching is equivalent to the original nested case structure.

Tests

• bash -n: PASS (both changed .sh files), bun test: N/A, curl|bash: OK (discovery.sh is not curl-piped), macOS compat: OK (no bash 3.x incompatibilities introduced)
• Full test suite: 80 passed, 0 failed

---

-- security/pr-reviewer

[la14-1]

Summary

Refactored two functions with significant complexity issues:

1. test/mock.sh: _validate_body() (93 → 35 lines)

   • Extracted 60+ line nested case statement into _get_required_fields()
   • Uses pattern matching on "cloud:endpoint" for cleaner lookups
   • Improves readability and maintainability

2. .claude/skills/setup-agent-team/discovery.sh: build_team_prompt() (162 → 6 lines)

   • Extracted massive heredoc into external discovery-team-prompt.txt file
   • Function now simply loads and cats the template
   • Makes discovery.sh easier to maintain and modify

Testing

• All 80 bash tests pass
• Syntax validation: bash -n on both modified files passes
• No functional changes - refactoring only

Changes

• Modified: test/mock.sh (function refactoring)
• Modified: .claude/skills/setup-agent-team/discovery.sh (function refactoring)
• Created: .claude/skills/setup-agent-team/discovery-team-prompt.txt (new data file)

Agent: complexity-hunter

Co-Authored-By: Claude Haiku 4.5 noreply@anthropic.com

[louisgv]

Security Review

Verdict: APPROVED

Findings

No security findings.

Summary: Two clean refactoring changes:

1. discovery.sh — Extracts inline heredoc prompt (~155 lines) into discovery-team-prompt.txt and reads it via cat. The file path is derived from $SCRIPT_DIR (safe), and the function fails fast with exit 1 if the file is missing. No injection risk since the file content is used as a prompt template, not executed.
2. test/mock.sh — Extracts the nested case logic in _validate_body() into a helper _get_required_fields(). Pure refactor with identical behavior — the combined ${cloud}:${endpoint} pattern matching is equivalent to the original nested case structure.

Tests

• bash -n: PASS (both changed .sh files), bun test: N/A, curl|bash: OK (discovery.sh is not curl-piped), macOS compat: OK (no bash 3.x incompatibilities introduced)
• Full test suite: 80 passed, 0 failed

---

-- security/pr-reviewer

[la14-1]

Summary

Refactored two functions with significant complexity issues:

1. test/mock.sh: _validate_body() (93 → 35 lines)

   • Extracted 60+ line nested case statement into _get_required_fields()
   • Uses pattern matching on "cloud:endpoint" for cleaner lookups
   • Improves readability and maintainability

2. .claude/skills/setup-agent-team/discovery.sh: build_team_prompt() (162 → 6 lines)

   • Extracted massive heredoc into external discovery-team-prompt.txt file
   • Function now simply loads and cats the template
   • Makes discovery.sh easier to maintain and modify

Testing

• All 80 bash tests pass
• Syntax validation: bash -n on both modified files passes
• No functional changes - refactoring only

Changes

• Modified: test/mock.sh (function refactoring)
• Modified: .claude/skills/setup-agent-team/discovery.sh (function refactoring)
• Created: .claude/skills/setup-agent-team/discovery-team-prompt.txt (new data file)

Agent: complexity-hunter

Co-Authored-By: Claude Haiku 4.5 noreply@anthropic.com

[louisgv]

Security Review

Verdict: APPROVED

Findings

No security findings.

Summary: Two clean refactoring changes:

1. discovery.sh — Extracts inline heredoc prompt (~155 lines) into discovery-team-prompt.txt and reads it via cat. The file path is derived from $SCRIPT_DIR (safe), and the function fails fast with exit 1 if the file is missing. No injection risk since the file content is used as a prompt template, not executed.
2. test/mock.sh — Extracts the nested case logic in _validate_body() into a helper _get_required_fields(). Pure refactor with identical behavior — the combined ${cloud}:${endpoint} pattern matching is equivalent to the original nested case structure.

Tests

• bash -n: PASS (both changed .sh files), bun test: N/A, curl|bash: OK (discovery.sh is not curl-piped), macOS compat: OK (no bash 3.x incompatibilities introduced)
• Full test suite: 80 passed, 0 failed

---

-- security/pr-reviewer

[la14-1]

Summary

Refactored two functions with significant complexity issues:

1. test/mock.sh: _validate_body() (93 → 35 lines)

   • Extracted 60+ line nested case statement into _get_required_fields()
   • Uses pattern matching on "cloud:endpoint" for cleaner lookups
   • Improves readability and maintainability

2. .claude/skills/setup-agent-team/discovery.sh: build_team_prompt() (162 → 6 lines)

   • Extracted massive heredoc into external discovery-team-prompt.txt file
   • Function now simply loads and cats the template
   • Makes discovery.sh easier to maintain and modify

Testing

• All 80 bash tests pass
• Syntax validation: bash -n on both modified files passes
• No functional changes - refactoring only

Changes

• Modified: test/mock.sh (function refactoring)
• Modified: .claude/skills/setup-agent-team/discovery.sh (function refactoring)
• Created: .claude/skills/setup-agent-team/discovery-team-prompt.txt (new data file)

Agent: complexity-hunter

Co-Authored-By: Claude Haiku 4.5 noreply@anthropic.com

[louisgv]

Security Review

Verdict: APPROVED

Findings

No security findings.

Summary: Two clean refactoring changes:

1. discovery.sh — Extracts inline heredoc prompt (~155 lines) into discovery-team-prompt.txt and reads it via cat. The file path is derived from $SCRIPT_DIR (safe), and the function fails fast with exit 1 if the file is missing. No injection risk since the file content is used as a prompt template, not executed.
2. test/mock.sh — Extracts the nested case logic in _validate_body() into a helper _get_required_fields(). Pure refactor with identical behavior — the combined ${cloud}:${endpoint} pattern matching is equivalent to the original nested case structure.

Tests

• bash -n: PASS (both changed .sh files), bun test: N/A, curl|bash: OK (discovery.sh is not curl-piped), macOS compat: OK (no bash 3.x incompatibilities introduced)
• Full test suite: 80 passed, 0 failed

---

-- security/pr-reviewer

[la14-1]

Summary

Refactored two functions with significant complexity issues:

1. test/mock.sh: _validate_body() (93 → 35 lines)

   • Extracted 60+ line nested case statement into _get_required_fields()
   • Uses pattern matching on "cloud:endpoint" for cleaner lookups
   • Improves readability and maintainability

2. .claude/skills/setup-agent-team/discovery.sh: build_team_prompt() (162 → 6 lines)

   • Extracted massive heredoc into external discovery-team-prompt.txt file
   • Function now simply loads and cats the template
   • Makes discovery.sh easier to maintain and modify

Testing

• All 80 bash tests pass
• Syntax validation: bash -n on both modified files passes
• No functional changes - refactoring only

Changes

• Modified: test/mock.sh (function refactoring)
• Modified: .claude/skills/setup-agent-team/discovery.sh (function refactoring)
• Created: .claude/skills/setup-agent-team/discovery-team-prompt.txt (new data file)

Agent: complexity-hunter

Co-Authored-By: Claude Haiku 4.5 noreply@anthropic.com

[louisgv]

Security Review

Verdict: APPROVED

Findings

No security findings.

Summary: Two clean refactoring changes:

1. discovery.sh — Extracts inline heredoc prompt (~155 lines) into discovery-team-prompt.txt and reads it via cat. The file path is derived from $SCRIPT_DIR (safe), and the function fails fast with exit 1 if the file is missing. No injection risk since the file content is used as a prompt template, not executed.
2. test/mock.sh — Extracts the nested case logic in _validate_body() into a helper _get_required_fields(). Pure refactor with identical behavior — the combined ${cloud}:${endpoint} pattern matching is equivalent to the original nested case structure.

Tests

• bash -n: PASS (both changed .sh files), bun test: N/A, curl|bash: OK (discovery.sh is not curl-piped), macOS compat: OK (no bash 3.x incompatibilities introduced)
• Full test suite: 80 passed, 0 failed

---

-- security/pr-reviewer

[la14-1]

Summary

Refactored two functions with significant complexity issues:

1. test/mock.sh: _validate_body() (93 → 35 lines)

   • Extracted 60+ line nested case statement into _get_required_fields()
   • Uses pattern matching on "cloud:endpoint" for cleaner lookups
   • Improves readability and maintainability

2. .claude/skills/setup-agent-team/discovery.sh: build_team_prompt() (162 → 6 lines)

   • Extracted massive heredoc into external discovery-team-prompt.txt file
   • Function now simply loads and cats the template
   • Makes discovery.sh easier to maintain and modify

Testing

• All 80 bash tests pass
• Syntax validation: bash -n on both modified files passes
• No functional changes - refactoring only

Changes

• Modified: test/mock.sh (function refactoring)
• Modified: .claude/skills/setup-agent-team/discovery.sh (function refactoring)
• Created: .claude/skills/setup-agent-team/discovery-team-prompt.txt (new data file)

Agent: complexity-hunter

Co-Authored-By: Claude Haiku 4.5 noreply@anthropic.com

[louisgv]

Security Review

Verdict: APPROVED

Findings

No security findings.

Summary: Two clean refactoring changes:

1. discovery.sh — Extracts inline heredoc prompt (~155 lines) into discovery-team-prompt.txt and reads it via cat. The file path is derived from $SCRIPT_DIR (safe), and the function fails fast with exit 1 if the file is missing. No injection risk since the file content is used as a prompt template, not executed.
2. test/mock.sh — Extracts the nested case logic in _validate_body() into a helper _get_required_fields(). Pure refactor with identical behavior — the combined ${cloud}:${endpoint} pattern matching is equivalent to the original nested case structure.

Tests

• bash -n: PASS (both changed .sh files), bun test: N/A, curl|bash: OK (discovery.sh is not curl-piped), macOS compat: OK (no bash 3.x incompatibilities introduced)
• Full test suite: 80 passed, 0 failed

---

-- security/pr-reviewer