refactor: reduce complexity in discovery.sh, record.sh, and common.sh by la14-1 · Pull Request #1123 · OpenRouterLabs/spawn

la14-1 · 2026-02-14T20:10:11Z

Summary

Refactored three complex functions to improve maintainability and readability:

discovery.sh: Extracted process lifecycle helpers from run_team_cycle() (71→39 lines)
- _sync_and_setup() - git sync and prompt preparation
- _launch_claude() - claude process startup
- _session_completed() - check for session completion
- _cleanup_cycle_files() - cleanup temp files
record.sh: Extracted validation helpers from _save_live_fixture() (34→15 lines)
- _validate_response_not_empty() - check non-empty response
- _validate_response_json() - validate JSON format
- _validate_response_no_error() - check for API errors
- _record_fixture_metadata() - record fixture metadata
shared/common.sh: Extracted verification helpers from verify_agent_installed() (32→11 lines)
- _check_agent_in_path() - verify command in PATH
- _check_agent_runs() - verify command execution

Test plan

Syntax check on all modified .sh files (bash -n)
All 80 shell tests passing
Behavior unchanged - extracted logic is identical

-- refactor/complexity-hunter

Break down overly complex functions into smaller, single-purpose helpers: discovery.sh: - Extract _sync_and_setup() from run_team_cycle() for git sync + setup - Extract _launch_claude() to handle process startup - Extract _session_completed() to check session status - Extract _cleanup_cycle_files() for file cleanup - Reduces run_team_cycle() from 71 lines to 39 lines record.sh: - Extract _validate_response_not_empty() for empty check - Extract _validate_response_json() for JSON validation - Extract _validate_response_no_error() for API error checking - Extract _record_fixture_metadata() for metadata recording - Reduces _save_live_fixture() from 34 lines to 15 lines shared/common.sh: - Extract _check_agent_in_path() for PATH verification - Extract _check_agent_runs() for execution verification - Reduces verify_agent_installed() from 32 lines to 11 lines Each helper is focused on one concern, improving maintainability and testability. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

louisgv

Security Review

Verdict: APPROVED

Findings

No security issues found. This is a pure refactoring PR that extracts inline code blocks into named helper functions with no behavioral changes:

discovery.sh: run_team_cycle() decomposed into _sync_and_setup(), _launch_claude(), _session_completed(), _cleanup_cycle_files() — all logic preserved, dynamic scoping for PROMPT_FILE is the existing pattern
shared/common.sh: verify_agent_installed() decomposed into _check_agent_in_path() and _check_agent_runs() — command execution properly quoted, unchanged from original
test/record.sh: _save_live_fixture() decomposed into validation and metadata helpers — dynamic scoping for counters matches existing pattern

Tests

bash -n: PASS (all 3 changed .sh files)
test/run.sh: PASS (80 passed, 0 failed)
curl|bash: OK (no source/eval patterns changed)
macOS compat: OK (no bash 3.x incompatible constructs introduced)

-- security/pr-reviewer

la14-1 · 2026-02-14T20:10:11Z

Summary

Refactored three complex functions to improve maintainability and readability:

discovery.sh: Extracted process lifecycle helpers from run_team_cycle() (71→39 lines)
- _sync_and_setup() - git sync and prompt preparation
- _launch_claude() - claude process startup
- _session_completed() - check for session completion
- _cleanup_cycle_files() - cleanup temp files
record.sh: Extracted validation helpers from _save_live_fixture() (34→15 lines)
- _validate_response_not_empty() - check non-empty response
- _validate_response_json() - validate JSON format
- _validate_response_no_error() - check for API errors
- _record_fixture_metadata() - record fixture metadata
shared/common.sh: Extracted verification helpers from verify_agent_installed() (32→11 lines)
- _check_agent_in_path() - verify command in PATH
- _check_agent_runs() - verify command execution

Test plan

Syntax check on all modified .sh files (bash -n)
All 80 shell tests passing
Behavior unchanged - extracted logic is identical

-- refactor/complexity-hunter

Break down overly complex functions into smaller, single-purpose helpers: discovery.sh: - Extract _sync_and_setup() from run_team_cycle() for git sync + setup - Extract _launch_claude() to handle process startup - Extract _session_completed() to check session status - Extract _cleanup_cycle_files() for file cleanup - Reduces run_team_cycle() from 71 lines to 39 lines record.sh: - Extract _validate_response_not_empty() for empty check - Extract _validate_response_json() for JSON validation - Extract _validate_response_no_error() for API error checking - Extract _record_fixture_metadata() for metadata recording - Reduces _save_live_fixture() from 34 lines to 15 lines shared/common.sh: - Extract _check_agent_in_path() for PATH verification - Extract _check_agent_runs() for execution verification - Reduces verify_agent_installed() from 32 lines to 11 lines Each helper is focused on one concern, improving maintainability and testability. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

louisgv

Security Review

Verdict: APPROVED

Findings

No security issues found. This is a pure refactoring PR that extracts inline code blocks into named helper functions with no behavioral changes:

discovery.sh: run_team_cycle() decomposed into _sync_and_setup(), _launch_claude(), _session_completed(), _cleanup_cycle_files() — all logic preserved, dynamic scoping for PROMPT_FILE is the existing pattern
shared/common.sh: verify_agent_installed() decomposed into _check_agent_in_path() and _check_agent_runs() — command execution properly quoted, unchanged from original
test/record.sh: _save_live_fixture() decomposed into validation and metadata helpers — dynamic scoping for counters matches existing pattern

Tests

bash -n: PASS (all 3 changed .sh files)
test/run.sh: PASS (80 passed, 0 failed)
curl|bash: OK (no source/eval patterns changed)
macOS compat: OK (no bash 3.x incompatible constructs introduced)

-- security/pr-reviewer

la14-1 · 2026-02-14T20:10:11Z

Summary

Refactored three complex functions to improve maintainability and readability:

discovery.sh: Extracted process lifecycle helpers from run_team_cycle() (71→39 lines)
- _sync_and_setup() - git sync and prompt preparation
- _launch_claude() - claude process startup
- _session_completed() - check for session completion
- _cleanup_cycle_files() - cleanup temp files
record.sh: Extracted validation helpers from _save_live_fixture() (34→15 lines)
- _validate_response_not_empty() - check non-empty response
- _validate_response_json() - validate JSON format
- _validate_response_no_error() - check for API errors
- _record_fixture_metadata() - record fixture metadata
shared/common.sh: Extracted verification helpers from verify_agent_installed() (32→11 lines)
- _check_agent_in_path() - verify command in PATH
- _check_agent_runs() - verify command execution

Test plan

Syntax check on all modified .sh files (bash -n)
All 80 shell tests passing
Behavior unchanged - extracted logic is identical

-- refactor/complexity-hunter

Break down overly complex functions into smaller, single-purpose helpers: discovery.sh: - Extract _sync_and_setup() from run_team_cycle() for git sync + setup - Extract _launch_claude() to handle process startup - Extract _session_completed() to check session status - Extract _cleanup_cycle_files() for file cleanup - Reduces run_team_cycle() from 71 lines to 39 lines record.sh: - Extract _validate_response_not_empty() for empty check - Extract _validate_response_json() for JSON validation - Extract _validate_response_no_error() for API error checking - Extract _record_fixture_metadata() for metadata recording - Reduces _save_live_fixture() from 34 lines to 15 lines shared/common.sh: - Extract _check_agent_in_path() for PATH verification - Extract _check_agent_runs() for execution verification - Reduces verify_agent_installed() from 32 lines to 11 lines Each helper is focused on one concern, improving maintainability and testability. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

louisgv

Security Review

Verdict: APPROVED

Findings

No security issues found. This is a pure refactoring PR that extracts inline code blocks into named helper functions with no behavioral changes:

discovery.sh: run_team_cycle() decomposed into _sync_and_setup(), _launch_claude(), _session_completed(), _cleanup_cycle_files() — all logic preserved, dynamic scoping for PROMPT_FILE is the existing pattern
shared/common.sh: verify_agent_installed() decomposed into _check_agent_in_path() and _check_agent_runs() — command execution properly quoted, unchanged from original
test/record.sh: _save_live_fixture() decomposed into validation and metadata helpers — dynamic scoping for counters matches existing pattern

Tests

bash -n: PASS (all 3 changed .sh files)
test/run.sh: PASS (80 passed, 0 failed)
curl|bash: OK (no source/eval patterns changed)
macOS compat: OK (no bash 3.x incompatible constructs introduced)

-- security/pr-reviewer

la14-1 · 2026-02-14T20:10:11Z

Summary

Refactored three complex functions to improve maintainability and readability:

discovery.sh: Extracted process lifecycle helpers from run_team_cycle() (71→39 lines)
- _sync_and_setup() - git sync and prompt preparation
- _launch_claude() - claude process startup
- _session_completed() - check for session completion
- _cleanup_cycle_files() - cleanup temp files
record.sh: Extracted validation helpers from _save_live_fixture() (34→15 lines)
- _validate_response_not_empty() - check non-empty response
- _validate_response_json() - validate JSON format
- _validate_response_no_error() - check for API errors
- _record_fixture_metadata() - record fixture metadata
shared/common.sh: Extracted verification helpers from verify_agent_installed() (32→11 lines)
- _check_agent_in_path() - verify command in PATH
- _check_agent_runs() - verify command execution

Test plan

Syntax check on all modified .sh files (bash -n)
All 80 shell tests passing
Behavior unchanged - extracted logic is identical

-- refactor/complexity-hunter

Break down overly complex functions into smaller, single-purpose helpers: discovery.sh: - Extract _sync_and_setup() from run_team_cycle() for git sync + setup - Extract _launch_claude() to handle process startup - Extract _session_completed() to check session status - Extract _cleanup_cycle_files() for file cleanup - Reduces run_team_cycle() from 71 lines to 39 lines record.sh: - Extract _validate_response_not_empty() for empty check - Extract _validate_response_json() for JSON validation - Extract _validate_response_no_error() for API error checking - Extract _record_fixture_metadata() for metadata recording - Reduces _save_live_fixture() from 34 lines to 15 lines shared/common.sh: - Extract _check_agent_in_path() for PATH verification - Extract _check_agent_runs() for execution verification - Reduces verify_agent_installed() from 32 lines to 11 lines Each helper is focused on one concern, improving maintainability and testability. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

louisgv

Security Review

Verdict: APPROVED

Findings

No security issues found. This is a pure refactoring PR that extracts inline code blocks into named helper functions with no behavioral changes:

discovery.sh: run_team_cycle() decomposed into _sync_and_setup(), _launch_claude(), _session_completed(), _cleanup_cycle_files() — all logic preserved, dynamic scoping for PROMPT_FILE is the existing pattern
shared/common.sh: verify_agent_installed() decomposed into _check_agent_in_path() and _check_agent_runs() — command execution properly quoted, unchanged from original
test/record.sh: _save_live_fixture() decomposed into validation and metadata helpers — dynamic scoping for counters matches existing pattern

Tests

bash -n: PASS (all 3 changed .sh files)
test/run.sh: PASS (80 passed, 0 failed)
curl|bash: OK (no source/eval patterns changed)
macOS compat: OK (no bash 3.x incompatible constructs introduced)

-- security/pr-reviewer

la14-1 · 2026-02-14T20:10:11Z

Summary

Refactored three complex functions to improve maintainability and readability:

discovery.sh: Extracted process lifecycle helpers from run_team_cycle() (71→39 lines)
- _sync_and_setup() - git sync and prompt preparation
- _launch_claude() - claude process startup
- _session_completed() - check for session completion
- _cleanup_cycle_files() - cleanup temp files
record.sh: Extracted validation helpers from _save_live_fixture() (34→15 lines)
- _validate_response_not_empty() - check non-empty response
- _validate_response_json() - validate JSON format
- _validate_response_no_error() - check for API errors
- _record_fixture_metadata() - record fixture metadata
shared/common.sh: Extracted verification helpers from verify_agent_installed() (32→11 lines)
- _check_agent_in_path() - verify command in PATH
- _check_agent_runs() - verify command execution

Test plan

Syntax check on all modified .sh files (bash -n)
All 80 shell tests passing
Behavior unchanged - extracted logic is identical

-- refactor/complexity-hunter

Break down overly complex functions into smaller, single-purpose helpers: discovery.sh: - Extract _sync_and_setup() from run_team_cycle() for git sync + setup - Extract _launch_claude() to handle process startup - Extract _session_completed() to check session status - Extract _cleanup_cycle_files() for file cleanup - Reduces run_team_cycle() from 71 lines to 39 lines record.sh: - Extract _validate_response_not_empty() for empty check - Extract _validate_response_json() for JSON validation - Extract _validate_response_no_error() for API error checking - Extract _record_fixture_metadata() for metadata recording - Reduces _save_live_fixture() from 34 lines to 15 lines shared/common.sh: - Extract _check_agent_in_path() for PATH verification - Extract _check_agent_runs() for execution verification - Reduces verify_agent_installed() from 32 lines to 11 lines Each helper is focused on one concern, improving maintainability and testability. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

louisgv

Security Review

Verdict: APPROVED

Findings

No security issues found. This is a pure refactoring PR that extracts inline code blocks into named helper functions with no behavioral changes:

discovery.sh: run_team_cycle() decomposed into _sync_and_setup(), _launch_claude(), _session_completed(), _cleanup_cycle_files() — all logic preserved, dynamic scoping for PROMPT_FILE is the existing pattern
shared/common.sh: verify_agent_installed() decomposed into _check_agent_in_path() and _check_agent_runs() — command execution properly quoted, unchanged from original
test/record.sh: _save_live_fixture() decomposed into validation and metadata helpers — dynamic scoping for counters matches existing pattern

Tests

bash -n: PASS (all 3 changed .sh files)
test/run.sh: PASS (80 passed, 0 failed)
curl|bash: OK (no source/eval patterns changed)
macOS compat: OK (no bash 3.x incompatible constructs introduced)

-- security/pr-reviewer

la14-1 · 2026-02-14T20:10:11Z

Summary

Refactored three complex functions to improve maintainability and readability:

discovery.sh: Extracted process lifecycle helpers from run_team_cycle() (71→39 lines)
- _sync_and_setup() - git sync and prompt preparation
- _launch_claude() - claude process startup
- _session_completed() - check for session completion
- _cleanup_cycle_files() - cleanup temp files
record.sh: Extracted validation helpers from _save_live_fixture() (34→15 lines)
- _validate_response_not_empty() - check non-empty response
- _validate_response_json() - validate JSON format
- _validate_response_no_error() - check for API errors
- _record_fixture_metadata() - record fixture metadata
shared/common.sh: Extracted verification helpers from verify_agent_installed() (32→11 lines)
- _check_agent_in_path() - verify command in PATH
- _check_agent_runs() - verify command execution

Test plan

Syntax check on all modified .sh files (bash -n)
All 80 shell tests passing
Behavior unchanged - extracted logic is identical

-- refactor/complexity-hunter

Break down overly complex functions into smaller, single-purpose helpers: discovery.sh: - Extract _sync_and_setup() from run_team_cycle() for git sync + setup - Extract _launch_claude() to handle process startup - Extract _session_completed() to check session status - Extract _cleanup_cycle_files() for file cleanup - Reduces run_team_cycle() from 71 lines to 39 lines record.sh: - Extract _validate_response_not_empty() for empty check - Extract _validate_response_json() for JSON validation - Extract _validate_response_no_error() for API error checking - Extract _record_fixture_metadata() for metadata recording - Reduces _save_live_fixture() from 34 lines to 15 lines shared/common.sh: - Extract _check_agent_in_path() for PATH verification - Extract _check_agent_runs() for execution verification - Reduces verify_agent_installed() from 32 lines to 11 lines Each helper is focused on one concern, improving maintainability and testability. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

louisgv

Security Review

Verdict: APPROVED

Findings

No security issues found. This is a pure refactoring PR that extracts inline code blocks into named helper functions with no behavioral changes:

discovery.sh: run_team_cycle() decomposed into _sync_and_setup(), _launch_claude(), _session_completed(), _cleanup_cycle_files() — all logic preserved, dynamic scoping for PROMPT_FILE is the existing pattern
shared/common.sh: verify_agent_installed() decomposed into _check_agent_in_path() and _check_agent_runs() — command execution properly quoted, unchanged from original
test/record.sh: _save_live_fixture() decomposed into validation and metadata helpers — dynamic scoping for counters matches existing pattern

Tests

bash -n: PASS (all 3 changed .sh files)
test/run.sh: PASS (80 passed, 0 failed)
curl|bash: OK (no source/eval patterns changed)
macOS compat: OK (no bash 3.x incompatible constructs introduced)

-- security/pr-reviewer

la14-1 · 2026-02-14T20:10:11Z

Summary

Refactored three complex functions to improve maintainability and readability:

discovery.sh: Extracted process lifecycle helpers from run_team_cycle() (71→39 lines)
- _sync_and_setup() - git sync and prompt preparation
- _launch_claude() - claude process startup
- _session_completed() - check for session completion
- _cleanup_cycle_files() - cleanup temp files
record.sh: Extracted validation helpers from _save_live_fixture() (34→15 lines)
- _validate_response_not_empty() - check non-empty response
- _validate_response_json() - validate JSON format
- _validate_response_no_error() - check for API errors
- _record_fixture_metadata() - record fixture metadata
shared/common.sh: Extracted verification helpers from verify_agent_installed() (32→11 lines)
- _check_agent_in_path() - verify command in PATH
- _check_agent_runs() - verify command execution

Test plan

Syntax check on all modified .sh files (bash -n)
All 80 shell tests passing
Behavior unchanged - extracted logic is identical

-- refactor/complexity-hunter

Break down overly complex functions into smaller, single-purpose helpers: discovery.sh: - Extract _sync_and_setup() from run_team_cycle() for git sync + setup - Extract _launch_claude() to handle process startup - Extract _session_completed() to check session status - Extract _cleanup_cycle_files() for file cleanup - Reduces run_team_cycle() from 71 lines to 39 lines record.sh: - Extract _validate_response_not_empty() for empty check - Extract _validate_response_json() for JSON validation - Extract _validate_response_no_error() for API error checking - Extract _record_fixture_metadata() for metadata recording - Reduces _save_live_fixture() from 34 lines to 15 lines shared/common.sh: - Extract _check_agent_in_path() for PATH verification - Extract _check_agent_runs() for execution verification - Reduces verify_agent_installed() from 32 lines to 11 lines Each helper is focused on one concern, improving maintainability and testability. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

louisgv

Security Review

Verdict: APPROVED

Findings

No security issues found. This is a pure refactoring PR that extracts inline code blocks into named helper functions with no behavioral changes:

discovery.sh: run_team_cycle() decomposed into _sync_and_setup(), _launch_claude(), _session_completed(), _cleanup_cycle_files() — all logic preserved, dynamic scoping for PROMPT_FILE is the existing pattern
shared/common.sh: verify_agent_installed() decomposed into _check_agent_in_path() and _check_agent_runs() — command execution properly quoted, unchanged from original
test/record.sh: _save_live_fixture() decomposed into validation and metadata helpers — dynamic scoping for counters matches existing pattern

Tests

bash -n: PASS (all 3 changed .sh files)
test/run.sh: PASS (80 passed, 0 failed)
curl|bash: OK (no source/eval patterns changed)
macOS compat: OK (no bash 3.x incompatible constructs introduced)

-- security/pr-reviewer

la14-1 · 2026-02-14T20:10:11Z

Summary

Refactored three complex functions to improve maintainability and readability:

discovery.sh: Extracted process lifecycle helpers from run_team_cycle() (71→39 lines)
- _sync_and_setup() - git sync and prompt preparation
- _launch_claude() - claude process startup
- _session_completed() - check for session completion
- _cleanup_cycle_files() - cleanup temp files
record.sh: Extracted validation helpers from _save_live_fixture() (34→15 lines)
- _validate_response_not_empty() - check non-empty response
- _validate_response_json() - validate JSON format
- _validate_response_no_error() - check for API errors
- _record_fixture_metadata() - record fixture metadata
shared/common.sh: Extracted verification helpers from verify_agent_installed() (32→11 lines)
- _check_agent_in_path() - verify command in PATH
- _check_agent_runs() - verify command execution

Test plan

Syntax check on all modified .sh files (bash -n)
All 80 shell tests passing
Behavior unchanged - extracted logic is identical

-- refactor/complexity-hunter

Break down overly complex functions into smaller, single-purpose helpers: discovery.sh: - Extract _sync_and_setup() from run_team_cycle() for git sync + setup - Extract _launch_claude() to handle process startup - Extract _session_completed() to check session status - Extract _cleanup_cycle_files() for file cleanup - Reduces run_team_cycle() from 71 lines to 39 lines record.sh: - Extract _validate_response_not_empty() for empty check - Extract _validate_response_json() for JSON validation - Extract _validate_response_no_error() for API error checking - Extract _record_fixture_metadata() for metadata recording - Reduces _save_live_fixture() from 34 lines to 15 lines shared/common.sh: - Extract _check_agent_in_path() for PATH verification - Extract _check_agent_runs() for execution verification - Reduces verify_agent_installed() from 32 lines to 11 lines Each helper is focused on one concern, improving maintainability and testability. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

louisgv

Security Review

Verdict: APPROVED

Findings

No security issues found. This is a pure refactoring PR that extracts inline code blocks into named helper functions with no behavioral changes:

discovery.sh: run_team_cycle() decomposed into _sync_and_setup(), _launch_claude(), _session_completed(), _cleanup_cycle_files() — all logic preserved, dynamic scoping for PROMPT_FILE is the existing pattern
shared/common.sh: verify_agent_installed() decomposed into _check_agent_in_path() and _check_agent_runs() — command execution properly quoted, unchanged from original
test/record.sh: _save_live_fixture() decomposed into validation and metadata helpers — dynamic scoping for counters matches existing pattern