security: consolidate shellQuote and null-byte validation across all clouds

[la14-1]

Why: PR #2533 hardened GCP's shell escaping with shellQuote() (null-byte rejection + POSIX single-quote escaping), but left Hetzner, DigitalOcean, AWS, and connect.ts using inline .replace(/'/g, "'\\''") without null-byte validation. A null byte in a command string could cause truncation at the C/OS level, potentially bypassing shell escaping. This closes the defense-in-depth gap across all cloud providers.

Changes

Shared infrastructure

• shared/ui.ts — Added shellQuote() as the canonical shared implementation
• gcp/gcp.ts — Replaced local shellQuote definition with import + re-export from shared/ui.ts

Null-byte validation added to runServer()

• hetzner/hetzner.ts — Added !cmd || /\0/.test(cmd) guard
• digitalocean/digitalocean.ts — Added !cmd || /\0/.test(cmd) guard
• aws/aws.ts — Added !cmd || /\0/.test(cmd) guard + replaced inline .replace() with shellQuote()

Inline shell escaping replaced with shellQuote() in interactiveSession()

• hetzner/hetzner.ts — Null-byte validation + shellQuote(cmd)
• digitalocean/digitalocean.ts — Null-byte validation + shellQuote(cmd)
• aws/aws.ts — Null-byte validation + shellQuote(cmd)

Additional hardening

• commands/connect.ts — Replaced inline .replace() with shellQuote()
• shared/agents.tsbuildEnvBlock() — Added null-byte rejection for env var values + replaced inline escaping with shellQuote()

Tests & version

• __tests__/gcp-shellquote.test.ts — Updated import to shared/ui.ts
• package.json — Patch bump 0.16.17 → 0.16.18

Verification

• bunx @biomejs/biome check src/ — 0 errors
• bun test — 1400 pass, 0 fail

-- refactor/security-auditor

[louisgv]

Security Review

Verdict: APPROVED
Commit: a71faf1

Summary

This PR consolidates shell quoting and null-byte validation across all cloud providers. It moves shellQuote from gcp/gcp.ts to shared/ui.ts and applies it consistently across AWS, DigitalOcean, Hetzner, GCP, and the connect command.

Findings

No security issues found. This is a positive security improvement.

Security improvements:

• ✅ Centralized shellQuote() function eliminates inconsistent escaping
• ✅ Added null-byte validation at all command entry points (runServer, interactiveSession)
• ✅ Replaced ad-hoc quote escaping with centralized function
• ✅ Applied defense-in-depth (null-byte checks at entry point + in shellQuote)
• ✅ Environment variable generation now uses shellQuote() instead of inline escaping

Changed files:

• packages/cli/src/shared/ui.ts — Added shellQuote() export
• packages/cli/src/shared/agents.ts — Uses shellQuote() for env vars, added null-byte check
• packages/cli/src/aws/aws.ts — Added null-byte validation, uses shellQuote()
• packages/cli/src/digitalocean/digitalocean.ts — Added null-byte validation, uses shellQuote()
• packages/cli/src/hetzner/hetzner.ts — Added null-byte validation, uses shellQuote()
• packages/cli/src/gcp/gcp.ts — Re-exports shellQuote() from shared/ui
• packages/cli/src/commands/connect.ts — Uses shellQuote() for SSH commands

Tests

• ✅ bun test: PASS (1400/1400 tests)
• ✅ biome lint: PASS (117 files, 0 issues)
• ✅ null-byte validation: Present in all entry points
• ✅ shellQuote coverage: Test exists at __tests__/gcp-shellquote.test.ts

Risk Assessment

Risk level: NONE — This is a hardening change that improves security posture.

---

-- security/pr-reviewer

[la14-1]

Why: PR #2533 hardened GCP's shell escaping with shellQuote() (null-byte rejection + POSIX single-quote escaping), but left Hetzner, DigitalOcean, AWS, and connect.ts using inline .replace(/'/g, "'\\''") without null-byte validation. A null byte in a command string could cause truncation at the C/OS level, potentially bypassing shell escaping. This closes the defense-in-depth gap across all cloud providers.

Changes

Shared infrastructure

• shared/ui.ts — Added shellQuote() as the canonical shared implementation
• gcp/gcp.ts — Replaced local shellQuote definition with import + re-export from shared/ui.ts

Null-byte validation added to runServer()

• hetzner/hetzner.ts — Added !cmd || /\0/.test(cmd) guard
• digitalocean/digitalocean.ts — Added !cmd || /\0/.test(cmd) guard
• aws/aws.ts — Added !cmd || /\0/.test(cmd) guard + replaced inline .replace() with shellQuote()

Inline shell escaping replaced with shellQuote() in interactiveSession()

• hetzner/hetzner.ts — Null-byte validation + shellQuote(cmd)
• digitalocean/digitalocean.ts — Null-byte validation + shellQuote(cmd)
• aws/aws.ts — Null-byte validation + shellQuote(cmd)

Additional hardening

• commands/connect.ts — Replaced inline .replace() with shellQuote()
• shared/agents.tsbuildEnvBlock() — Added null-byte rejection for env var values + replaced inline escaping with shellQuote()

Tests & version

• __tests__/gcp-shellquote.test.ts — Updated import to shared/ui.ts
• package.json — Patch bump 0.16.17 → 0.16.18

Verification

• bunx @biomejs/biome check src/ — 0 errors
• bun test — 1400 pass, 0 fail

-- refactor/security-auditor

[louisgv]

Security Review

Verdict: APPROVED
Commit: a71faf1

Summary

This PR consolidates shell quoting and null-byte validation across all cloud providers. It moves shellQuote from gcp/gcp.ts to shared/ui.ts and applies it consistently across AWS, DigitalOcean, Hetzner, GCP, and the connect command.

Findings

No security issues found. This is a positive security improvement.

Security improvements:

• ✅ Centralized shellQuote() function eliminates inconsistent escaping
• ✅ Added null-byte validation at all command entry points (runServer, interactiveSession)
• ✅ Replaced ad-hoc quote escaping with centralized function
• ✅ Applied defense-in-depth (null-byte checks at entry point + in shellQuote)
• ✅ Environment variable generation now uses shellQuote() instead of inline escaping

Changed files:

• packages/cli/src/shared/ui.ts — Added shellQuote() export
• packages/cli/src/shared/agents.ts — Uses shellQuote() for env vars, added null-byte check
• packages/cli/src/aws/aws.ts — Added null-byte validation, uses shellQuote()
• packages/cli/src/digitalocean/digitalocean.ts — Added null-byte validation, uses shellQuote()
• packages/cli/src/hetzner/hetzner.ts — Added null-byte validation, uses shellQuote()
• packages/cli/src/gcp/gcp.ts — Re-exports shellQuote() from shared/ui
• packages/cli/src/commands/connect.ts — Uses shellQuote() for SSH commands

Tests

• ✅ bun test: PASS (1400/1400 tests)
• ✅ biome lint: PASS (117 files, 0 issues)
• ✅ null-byte validation: Present in all entry points
• ✅ shellQuote coverage: Test exists at __tests__/gcp-shellquote.test.ts

Risk Assessment

Risk level: NONE — This is a hardening change that improves security posture.

---

-- security/pr-reviewer

[la14-1]

Why: PR #2533 hardened GCP's shell escaping with shellQuote() (null-byte rejection + POSIX single-quote escaping), but left Hetzner, DigitalOcean, AWS, and connect.ts using inline .replace(/'/g, "'\\''") without null-byte validation. A null byte in a command string could cause truncation at the C/OS level, potentially bypassing shell escaping. This closes the defense-in-depth gap across all cloud providers.

Changes

Shared infrastructure

• shared/ui.ts — Added shellQuote() as the canonical shared implementation
• gcp/gcp.ts — Replaced local shellQuote definition with import + re-export from shared/ui.ts

Null-byte validation added to runServer()

• hetzner/hetzner.ts — Added !cmd || /\0/.test(cmd) guard
• digitalocean/digitalocean.ts — Added !cmd || /\0/.test(cmd) guard
• aws/aws.ts — Added !cmd || /\0/.test(cmd) guard + replaced inline .replace() with shellQuote()

Inline shell escaping replaced with shellQuote() in interactiveSession()

• hetzner/hetzner.ts — Null-byte validation + shellQuote(cmd)
• digitalocean/digitalocean.ts — Null-byte validation + shellQuote(cmd)
• aws/aws.ts — Null-byte validation + shellQuote(cmd)

Additional hardening

• commands/connect.ts — Replaced inline .replace() with shellQuote()
• shared/agents.tsbuildEnvBlock() — Added null-byte rejection for env var values + replaced inline escaping with shellQuote()

Tests & version

• __tests__/gcp-shellquote.test.ts — Updated import to shared/ui.ts
• package.json — Patch bump 0.16.17 → 0.16.18

Verification

• bunx @biomejs/biome check src/ — 0 errors
• bun test — 1400 pass, 0 fail

-- refactor/security-auditor

[louisgv]

Security Review

Verdict: APPROVED
Commit: a71faf1

Summary

This PR consolidates shell quoting and null-byte validation across all cloud providers. It moves shellQuote from gcp/gcp.ts to shared/ui.ts and applies it consistently across AWS, DigitalOcean, Hetzner, GCP, and the connect command.

Findings

No security issues found. This is a positive security improvement.

Security improvements:

• ✅ Centralized shellQuote() function eliminates inconsistent escaping
• ✅ Added null-byte validation at all command entry points (runServer, interactiveSession)
• ✅ Replaced ad-hoc quote escaping with centralized function
• ✅ Applied defense-in-depth (null-byte checks at entry point + in shellQuote)
• ✅ Environment variable generation now uses shellQuote() instead of inline escaping

Changed files:

• packages/cli/src/shared/ui.ts — Added shellQuote() export
• packages/cli/src/shared/agents.ts — Uses shellQuote() for env vars, added null-byte check
• packages/cli/src/aws/aws.ts — Added null-byte validation, uses shellQuote()
• packages/cli/src/digitalocean/digitalocean.ts — Added null-byte validation, uses shellQuote()
• packages/cli/src/hetzner/hetzner.ts — Added null-byte validation, uses shellQuote()
• packages/cli/src/gcp/gcp.ts — Re-exports shellQuote() from shared/ui
• packages/cli/src/commands/connect.ts — Uses shellQuote() for SSH commands

Tests

• ✅ bun test: PASS (1400/1400 tests)
• ✅ biome lint: PASS (117 files, 0 issues)
• ✅ null-byte validation: Present in all entry points
• ✅ shellQuote coverage: Test exists at __tests__/gcp-shellquote.test.ts

Risk Assessment

Risk level: NONE — This is a hardening change that improves security posture.

---

-- security/pr-reviewer

[la14-1]

Why: PR #2533 hardened GCP's shell escaping with shellQuote() (null-byte rejection + POSIX single-quote escaping), but left Hetzner, DigitalOcean, AWS, and connect.ts using inline .replace(/'/g, "'\\''") without null-byte validation. A null byte in a command string could cause truncation at the C/OS level, potentially bypassing shell escaping. This closes the defense-in-depth gap across all cloud providers.

Changes

Shared infrastructure

• shared/ui.ts — Added shellQuote() as the canonical shared implementation
• gcp/gcp.ts — Replaced local shellQuote definition with import + re-export from shared/ui.ts

Null-byte validation added to runServer()

• hetzner/hetzner.ts — Added !cmd || /\0/.test(cmd) guard
• digitalocean/digitalocean.ts — Added !cmd || /\0/.test(cmd) guard
• aws/aws.ts — Added !cmd || /\0/.test(cmd) guard + replaced inline .replace() with shellQuote()

Inline shell escaping replaced with shellQuote() in interactiveSession()

• hetzner/hetzner.ts — Null-byte validation + shellQuote(cmd)
• digitalocean/digitalocean.ts — Null-byte validation + shellQuote(cmd)
• aws/aws.ts — Null-byte validation + shellQuote(cmd)

Additional hardening

• commands/connect.ts — Replaced inline .replace() with shellQuote()
• shared/agents.tsbuildEnvBlock() — Added null-byte rejection for env var values + replaced inline escaping with shellQuote()

Tests & version

• __tests__/gcp-shellquote.test.ts — Updated import to shared/ui.ts
• package.json — Patch bump 0.16.17 → 0.16.18

Verification

• bunx @biomejs/biome check src/ — 0 errors
• bun test — 1400 pass, 0 fail

-- refactor/security-auditor

[louisgv]

Security Review

Verdict: APPROVED
Commit: a71faf1

Summary

This PR consolidates shell quoting and null-byte validation across all cloud providers. It moves shellQuote from gcp/gcp.ts to shared/ui.ts and applies it consistently across AWS, DigitalOcean, Hetzner, GCP, and the connect command.

Findings

No security issues found. This is a positive security improvement.

Security improvements:

• ✅ Centralized shellQuote() function eliminates inconsistent escaping
• ✅ Added null-byte validation at all command entry points (runServer, interactiveSession)
• ✅ Replaced ad-hoc quote escaping with centralized function
• ✅ Applied defense-in-depth (null-byte checks at entry point + in shellQuote)
• ✅ Environment variable generation now uses shellQuote() instead of inline escaping

Changed files:

• packages/cli/src/shared/ui.ts — Added shellQuote() export
• packages/cli/src/shared/agents.ts — Uses shellQuote() for env vars, added null-byte check
• packages/cli/src/aws/aws.ts — Added null-byte validation, uses shellQuote()
• packages/cli/src/digitalocean/digitalocean.ts — Added null-byte validation, uses shellQuote()
• packages/cli/src/hetzner/hetzner.ts — Added null-byte validation, uses shellQuote()
• packages/cli/src/gcp/gcp.ts — Re-exports shellQuote() from shared/ui
• packages/cli/src/commands/connect.ts — Uses shellQuote() for SSH commands

Tests

• ✅ bun test: PASS (1400/1400 tests)
• ✅ biome lint: PASS (117 files, 0 issues)
• ✅ null-byte validation: Present in all entry points
• ✅ shellQuote coverage: Test exists at __tests__/gcp-shellquote.test.ts

Risk Assessment

Risk level: NONE — This is a hardening change that improves security posture.

---

-- security/pr-reviewer

[la14-1]

Why: PR #2533 hardened GCP's shell escaping with shellQuote() (null-byte rejection + POSIX single-quote escaping), but left Hetzner, DigitalOcean, AWS, and connect.ts using inline .replace(/'/g, "'\\''") without null-byte validation. A null byte in a command string could cause truncation at the C/OS level, potentially bypassing shell escaping. This closes the defense-in-depth gap across all cloud providers.

Changes

Shared infrastructure

• shared/ui.ts — Added shellQuote() as the canonical shared implementation
• gcp/gcp.ts — Replaced local shellQuote definition with import + re-export from shared/ui.ts

Null-byte validation added to runServer()

• hetzner/hetzner.ts — Added !cmd || /\0/.test(cmd) guard
• digitalocean/digitalocean.ts — Added !cmd || /\0/.test(cmd) guard
• aws/aws.ts — Added !cmd || /\0/.test(cmd) guard + replaced inline .replace() with shellQuote()

Inline shell escaping replaced with shellQuote() in interactiveSession()

• hetzner/hetzner.ts — Null-byte validation + shellQuote(cmd)
• digitalocean/digitalocean.ts — Null-byte validation + shellQuote(cmd)
• aws/aws.ts — Null-byte validation + shellQuote(cmd)

Additional hardening

• commands/connect.ts — Replaced inline .replace() with shellQuote()
• shared/agents.tsbuildEnvBlock() — Added null-byte rejection for env var values + replaced inline escaping with shellQuote()

Tests & version

• __tests__/gcp-shellquote.test.ts — Updated import to shared/ui.ts
• package.json — Patch bump 0.16.17 → 0.16.18

Verification

• bunx @biomejs/biome check src/ — 0 errors
• bun test — 1400 pass, 0 fail

-- refactor/security-auditor

[louisgv]

Security Review

Verdict: APPROVED
Commit: a71faf1

Summary

This PR consolidates shell quoting and null-byte validation across all cloud providers. It moves shellQuote from gcp/gcp.ts to shared/ui.ts and applies it consistently across AWS, DigitalOcean, Hetzner, GCP, and the connect command.

Findings

No security issues found. This is a positive security improvement.

Security improvements:

• ✅ Centralized shellQuote() function eliminates inconsistent escaping
• ✅ Added null-byte validation at all command entry points (runServer, interactiveSession)
• ✅ Replaced ad-hoc quote escaping with centralized function
• ✅ Applied defense-in-depth (null-byte checks at entry point + in shellQuote)
• ✅ Environment variable generation now uses shellQuote() instead of inline escaping

Changed files:

• packages/cli/src/shared/ui.ts — Added shellQuote() export
• packages/cli/src/shared/agents.ts — Uses shellQuote() for env vars, added null-byte check
• packages/cli/src/aws/aws.ts — Added null-byte validation, uses shellQuote()
• packages/cli/src/digitalocean/digitalocean.ts — Added null-byte validation, uses shellQuote()
• packages/cli/src/hetzner/hetzner.ts — Added null-byte validation, uses shellQuote()
• packages/cli/src/gcp/gcp.ts — Re-exports shellQuote() from shared/ui
• packages/cli/src/commands/connect.ts — Uses shellQuote() for SSH commands

Tests

• ✅ bun test: PASS (1400/1400 tests)
• ✅ biome lint: PASS (117 files, 0 issues)
• ✅ null-byte validation: Present in all entry points
• ✅ shellQuote coverage: Test exists at __tests__/gcp-shellquote.test.ts

Risk Assessment

Risk level: NONE — This is a hardening change that improves security posture.

---

-- security/pr-reviewer

[la14-1]

Why: PR #2533 hardened GCP's shell escaping with shellQuote() (null-byte rejection + POSIX single-quote escaping), but left Hetzner, DigitalOcean, AWS, and connect.ts using inline .replace(/'/g, "'\\''") without null-byte validation. A null byte in a command string could cause truncation at the C/OS level, potentially bypassing shell escaping. This closes the defense-in-depth gap across all cloud providers.

Changes

Shared infrastructure

• shared/ui.ts — Added shellQuote() as the canonical shared implementation
• gcp/gcp.ts — Replaced local shellQuote definition with import + re-export from shared/ui.ts

Null-byte validation added to runServer()

• hetzner/hetzner.ts — Added !cmd || /\0/.test(cmd) guard
• digitalocean/digitalocean.ts — Added !cmd || /\0/.test(cmd) guard
• aws/aws.ts — Added !cmd || /\0/.test(cmd) guard + replaced inline .replace() with shellQuote()

Inline shell escaping replaced with shellQuote() in interactiveSession()

• hetzner/hetzner.ts — Null-byte validation + shellQuote(cmd)
• digitalocean/digitalocean.ts — Null-byte validation + shellQuote(cmd)
• aws/aws.ts — Null-byte validation + shellQuote(cmd)

Additional hardening

• commands/connect.ts — Replaced inline .replace() with shellQuote()
• shared/agents.tsbuildEnvBlock() — Added null-byte rejection for env var values + replaced inline escaping with shellQuote()

Tests & version

• __tests__/gcp-shellquote.test.ts — Updated import to shared/ui.ts
• package.json — Patch bump 0.16.17 → 0.16.18

Verification

• bunx @biomejs/biome check src/ — 0 errors
• bun test — 1400 pass, 0 fail

-- refactor/security-auditor

[louisgv]

Security Review

Verdict: APPROVED
Commit: a71faf1

Summary

This PR consolidates shell quoting and null-byte validation across all cloud providers. It moves shellQuote from gcp/gcp.ts to shared/ui.ts and applies it consistently across AWS, DigitalOcean, Hetzner, GCP, and the connect command.

Findings

No security issues found. This is a positive security improvement.

Security improvements:

• ✅ Centralized shellQuote() function eliminates inconsistent escaping
• ✅ Added null-byte validation at all command entry points (runServer, interactiveSession)
• ✅ Replaced ad-hoc quote escaping with centralized function
• ✅ Applied defense-in-depth (null-byte checks at entry point + in shellQuote)
• ✅ Environment variable generation now uses shellQuote() instead of inline escaping

Changed files:

• packages/cli/src/shared/ui.ts — Added shellQuote() export
• packages/cli/src/shared/agents.ts — Uses shellQuote() for env vars, added null-byte check
• packages/cli/src/aws/aws.ts — Added null-byte validation, uses shellQuote()
• packages/cli/src/digitalocean/digitalocean.ts — Added null-byte validation, uses shellQuote()
• packages/cli/src/hetzner/hetzner.ts — Added null-byte validation, uses shellQuote()
• packages/cli/src/gcp/gcp.ts — Re-exports shellQuote() from shared/ui
• packages/cli/src/commands/connect.ts — Uses shellQuote() for SSH commands

Tests

• ✅ bun test: PASS (1400/1400 tests)
• ✅ biome lint: PASS (117 files, 0 issues)
• ✅ null-byte validation: Present in all entry points
• ✅ shellQuote coverage: Test exists at __tests__/gcp-shellquote.test.ts

Risk Assessment

Risk level: NONE — This is a hardening change that improves security posture.

---

-- security/pr-reviewer

[la14-1]

Why: PR #2533 hardened GCP's shell escaping with shellQuote() (null-byte rejection + POSIX single-quote escaping), but left Hetzner, DigitalOcean, AWS, and connect.ts using inline .replace(/'/g, "'\\''") without null-byte validation. A null byte in a command string could cause truncation at the C/OS level, potentially bypassing shell escaping. This closes the defense-in-depth gap across all cloud providers.

Changes

Shared infrastructure

• shared/ui.ts — Added shellQuote() as the canonical shared implementation
• gcp/gcp.ts — Replaced local shellQuote definition with import + re-export from shared/ui.ts

Null-byte validation added to runServer()

• hetzner/hetzner.ts — Added !cmd || /\0/.test(cmd) guard
• digitalocean/digitalocean.ts — Added !cmd || /\0/.test(cmd) guard
• aws/aws.ts — Added !cmd || /\0/.test(cmd) guard + replaced inline .replace() with shellQuote()

Inline shell escaping replaced with shellQuote() in interactiveSession()

• hetzner/hetzner.ts — Null-byte validation + shellQuote(cmd)
• digitalocean/digitalocean.ts — Null-byte validation + shellQuote(cmd)
• aws/aws.ts — Null-byte validation + shellQuote(cmd)

Additional hardening

• commands/connect.ts — Replaced inline .replace() with shellQuote()
• shared/agents.tsbuildEnvBlock() — Added null-byte rejection for env var values + replaced inline escaping with shellQuote()

Tests & version

• __tests__/gcp-shellquote.test.ts — Updated import to shared/ui.ts
• package.json — Patch bump 0.16.17 → 0.16.18

Verification

• bunx @biomejs/biome check src/ — 0 errors
• bun test — 1400 pass, 0 fail

-- refactor/security-auditor

[louisgv]

Security Review

Verdict: APPROVED
Commit: a71faf1

Summary

This PR consolidates shell quoting and null-byte validation across all cloud providers. It moves shellQuote from gcp/gcp.ts to shared/ui.ts and applies it consistently across AWS, DigitalOcean, Hetzner, GCP, and the connect command.

Findings

No security issues found. This is a positive security improvement.

Security improvements:

• ✅ Centralized shellQuote() function eliminates inconsistent escaping
• ✅ Added null-byte validation at all command entry points (runServer, interactiveSession)
• ✅ Replaced ad-hoc quote escaping with centralized function
• ✅ Applied defense-in-depth (null-byte checks at entry point + in shellQuote)
• ✅ Environment variable generation now uses shellQuote() instead of inline escaping

Changed files:

• packages/cli/src/shared/ui.ts — Added shellQuote() export
• packages/cli/src/shared/agents.ts — Uses shellQuote() for env vars, added null-byte check
• packages/cli/src/aws/aws.ts — Added null-byte validation, uses shellQuote()
• packages/cli/src/digitalocean/digitalocean.ts — Added null-byte validation, uses shellQuote()
• packages/cli/src/hetzner/hetzner.ts — Added null-byte validation, uses shellQuote()
• packages/cli/src/gcp/gcp.ts — Re-exports shellQuote() from shared/ui
• packages/cli/src/commands/connect.ts — Uses shellQuote() for SSH commands

Tests

• ✅ bun test: PASS (1400/1400 tests)
• ✅ biome lint: PASS (117 files, 0 issues)
• ✅ null-byte validation: Present in all entry points
• ✅ shellQuote coverage: Test exists at __tests__/gcp-shellquote.test.ts

Risk Assessment

Risk level: NONE — This is a hardening change that improves security posture.

---

-- security/pr-reviewer

[la14-1]

Why: PR #2533 hardened GCP's shell escaping with shellQuote() (null-byte rejection + POSIX single-quote escaping), but left Hetzner, DigitalOcean, AWS, and connect.ts using inline .replace(/'/g, "'\\''") without null-byte validation. A null byte in a command string could cause truncation at the C/OS level, potentially bypassing shell escaping. This closes the defense-in-depth gap across all cloud providers.

Changes

Shared infrastructure

• shared/ui.ts — Added shellQuote() as the canonical shared implementation
• gcp/gcp.ts — Replaced local shellQuote definition with import + re-export from shared/ui.ts

Null-byte validation added to runServer()

• hetzner/hetzner.ts — Added !cmd || /\0/.test(cmd) guard
• digitalocean/digitalocean.ts — Added !cmd || /\0/.test(cmd) guard
• aws/aws.ts — Added !cmd || /\0/.test(cmd) guard + replaced inline .replace() with shellQuote()

Inline shell escaping replaced with shellQuote() in interactiveSession()

• hetzner/hetzner.ts — Null-byte validation + shellQuote(cmd)
• digitalocean/digitalocean.ts — Null-byte validation + shellQuote(cmd)
• aws/aws.ts — Null-byte validation + shellQuote(cmd)

Additional hardening

• commands/connect.ts — Replaced inline .replace() with shellQuote()
• shared/agents.tsbuildEnvBlock() — Added null-byte rejection for env var values + replaced inline escaping with shellQuote()

Tests & version

• __tests__/gcp-shellquote.test.ts — Updated import to shared/ui.ts
• package.json — Patch bump 0.16.17 → 0.16.18

Verification

• bunx @biomejs/biome check src/ — 0 errors
• bun test — 1400 pass, 0 fail

-- refactor/security-auditor

[louisgv]

Security Review

Verdict: APPROVED
Commit: a71faf1

Summary

This PR consolidates shell quoting and null-byte validation across all cloud providers. It moves shellQuote from gcp/gcp.ts to shared/ui.ts and applies it consistently across AWS, DigitalOcean, Hetzner, GCP, and the connect command.

Findings

No security issues found. This is a positive security improvement.

Security improvements:

• ✅ Centralized shellQuote() function eliminates inconsistent escaping
• ✅ Added null-byte validation at all command entry points (runServer, interactiveSession)
• ✅ Replaced ad-hoc quote escaping with centralized function
• ✅ Applied defense-in-depth (null-byte checks at entry point + in shellQuote)
• ✅ Environment variable generation now uses shellQuote() instead of inline escaping

Changed files:

• packages/cli/src/shared/ui.ts — Added shellQuote() export
• packages/cli/src/shared/agents.ts — Uses shellQuote() for env vars, added null-byte check
• packages/cli/src/aws/aws.ts — Added null-byte validation, uses shellQuote()
• packages/cli/src/digitalocean/digitalocean.ts — Added null-byte validation, uses shellQuote()
• packages/cli/src/hetzner/hetzner.ts — Added null-byte validation, uses shellQuote()
• packages/cli/src/gcp/gcp.ts — Re-exports shellQuote() from shared/ui
• packages/cli/src/commands/connect.ts — Uses shellQuote() for SSH commands

Tests

• ✅ bun test: PASS (1400/1400 tests)
• ✅ biome lint: PASS (117 files, 0 issues)
• ✅ null-byte validation: Present in all entry points
• ✅ shellQuote coverage: Test exists at __tests__/gcp-shellquote.test.ts

Risk Assessment

Risk level: NONE — This is a hardening change that improves security posture.

---

-- security/pr-reviewer