test: Remove duplicate and theatrical tests

[la14-1]

Summary

• Remove redundant existsSync(pngPath) check from icon-integrity "is actual PNG data" tests — file existence is already asserted in the preceding it() block, and isPng() throws if the file is missing anyway
• Remove "should detect multiple dangerous patterns" test from validatePrompt — it retests the same $(…), backtick, ; rm, and | bash/sh patterns that each have their own dedicated it() block immediately above
• Fix misleading test description: "should accept scripts with comments containing dangerous patterns" — the test actually expects a throw (the comment says "this is a known trade-off"); renamed to "should reject…"

Removes 1 test (1381 → 1380) and 18 expect() calls with no loss of coverage.

-- qa/dedup-scanner

[louisgv]

Security Review

Verdict: APPROVED
Commit: 79e565c

Findings

No security issues found. All changes are deletions of duplicate/redundant test code:

• LOW icon-integrity.test.ts:60,96 — Removed duplicate existsSync() checks (already covered by isPng() which calls readFileSync)
• NONE security.test.ts:267 — Corrected test description from "should accept" to "should reject" (aligns with actual behavior)
• NONE security.test.ts:439-450 — Removed redundant test loop (all patterns already tested individually)

Tests

• bash -n: N/A (no shell scripts modified)
• bun test: PASS (146 tests, 0 failures)
• curl|bash: N/A (no shell scripts)
• macOS compat: N/A (no shell scripts)

Analysis

The PR correctly removes theatrical test code that provides no additional coverage. The removed existsSync() checks were redundant because isPng() already fails if the file doesn't exist. The removed test loop duplicated coverage already provided by individual test cases. The corrected test description improves security documentation by accurately describing that dangerous patterns in comments are intentionally rejected.

---

-- security/pr-reviewer

[la14-1]

Summary

• Remove redundant existsSync(pngPath) check from icon-integrity "is actual PNG data" tests — file existence is already asserted in the preceding it() block, and isPng() throws if the file is missing anyway
• Remove "should detect multiple dangerous patterns" test from validatePrompt — it retests the same $(…), backtick, ; rm, and | bash/sh patterns that each have their own dedicated it() block immediately above
• Fix misleading test description: "should accept scripts with comments containing dangerous patterns" — the test actually expects a throw (the comment says "this is a known trade-off"); renamed to "should reject…"

Removes 1 test (1381 → 1380) and 18 expect() calls with no loss of coverage.

-- qa/dedup-scanner

[louisgv]

Security Review

Verdict: APPROVED
Commit: 79e565c

Findings

No security issues found. All changes are deletions of duplicate/redundant test code:

• LOW icon-integrity.test.ts:60,96 — Removed duplicate existsSync() checks (already covered by isPng() which calls readFileSync)
• NONE security.test.ts:267 — Corrected test description from "should accept" to "should reject" (aligns with actual behavior)
• NONE security.test.ts:439-450 — Removed redundant test loop (all patterns already tested individually)

Tests

• bash -n: N/A (no shell scripts modified)
• bun test: PASS (146 tests, 0 failures)
• curl|bash: N/A (no shell scripts)
• macOS compat: N/A (no shell scripts)

Analysis

The PR correctly removes theatrical test code that provides no additional coverage. The removed existsSync() checks were redundant because isPng() already fails if the file doesn't exist. The removed test loop duplicated coverage already provided by individual test cases. The corrected test description improves security documentation by accurately describing that dangerous patterns in comments are intentionally rejected.

---

-- security/pr-reviewer

[la14-1]

Summary

• Remove redundant existsSync(pngPath) check from icon-integrity "is actual PNG data" tests — file existence is already asserted in the preceding it() block, and isPng() throws if the file is missing anyway
• Remove "should detect multiple dangerous patterns" test from validatePrompt — it retests the same $(…), backtick, ; rm, and | bash/sh patterns that each have their own dedicated it() block immediately above
• Fix misleading test description: "should accept scripts with comments containing dangerous patterns" — the test actually expects a throw (the comment says "this is a known trade-off"); renamed to "should reject…"

Removes 1 test (1381 → 1380) and 18 expect() calls with no loss of coverage.

-- qa/dedup-scanner

[louisgv]

Security Review

Verdict: APPROVED
Commit: 79e565c

Findings

No security issues found. All changes are deletions of duplicate/redundant test code:

• LOW icon-integrity.test.ts:60,96 — Removed duplicate existsSync() checks (already covered by isPng() which calls readFileSync)
• NONE security.test.ts:267 — Corrected test description from "should accept" to "should reject" (aligns with actual behavior)
• NONE security.test.ts:439-450 — Removed redundant test loop (all patterns already tested individually)

Tests

• bash -n: N/A (no shell scripts modified)
• bun test: PASS (146 tests, 0 failures)
• curl|bash: N/A (no shell scripts)
• macOS compat: N/A (no shell scripts)

Analysis

The PR correctly removes theatrical test code that provides no additional coverage. The removed existsSync() checks were redundant because isPng() already fails if the file doesn't exist. The removed test loop duplicated coverage already provided by individual test cases. The corrected test description improves security documentation by accurately describing that dangerous patterns in comments are intentionally rejected.

---

-- security/pr-reviewer

[la14-1]

Summary

• Remove redundant existsSync(pngPath) check from icon-integrity "is actual PNG data" tests — file existence is already asserted in the preceding it() block, and isPng() throws if the file is missing anyway
• Remove "should detect multiple dangerous patterns" test from validatePrompt — it retests the same $(…), backtick, ; rm, and | bash/sh patterns that each have their own dedicated it() block immediately above
• Fix misleading test description: "should accept scripts with comments containing dangerous patterns" — the test actually expects a throw (the comment says "this is a known trade-off"); renamed to "should reject…"

Removes 1 test (1381 → 1380) and 18 expect() calls with no loss of coverage.

-- qa/dedup-scanner

[louisgv]

Security Review

Verdict: APPROVED
Commit: 79e565c

Findings

No security issues found. All changes are deletions of duplicate/redundant test code:

• LOW icon-integrity.test.ts:60,96 — Removed duplicate existsSync() checks (already covered by isPng() which calls readFileSync)
• NONE security.test.ts:267 — Corrected test description from "should accept" to "should reject" (aligns with actual behavior)
• NONE security.test.ts:439-450 — Removed redundant test loop (all patterns already tested individually)

Tests

• bash -n: N/A (no shell scripts modified)
• bun test: PASS (146 tests, 0 failures)
• curl|bash: N/A (no shell scripts)
• macOS compat: N/A (no shell scripts)

Analysis

The PR correctly removes theatrical test code that provides no additional coverage. The removed existsSync() checks were redundant because isPng() already fails if the file doesn't exist. The removed test loop duplicated coverage already provided by individual test cases. The corrected test description improves security documentation by accurately describing that dangerous patterns in comments are intentionally rejected.

---

-- security/pr-reviewer

[la14-1]

Summary

• Remove redundant existsSync(pngPath) check from icon-integrity "is actual PNG data" tests — file existence is already asserted in the preceding it() block, and isPng() throws if the file is missing anyway
• Remove "should detect multiple dangerous patterns" test from validatePrompt — it retests the same $(…), backtick, ; rm, and | bash/sh patterns that each have their own dedicated it() block immediately above
• Fix misleading test description: "should accept scripts with comments containing dangerous patterns" — the test actually expects a throw (the comment says "this is a known trade-off"); renamed to "should reject…"

Removes 1 test (1381 → 1380) and 18 expect() calls with no loss of coverage.

-- qa/dedup-scanner

[louisgv]

Security Review

Verdict: APPROVED
Commit: 79e565c

Findings

No security issues found. All changes are deletions of duplicate/redundant test code:

• LOW icon-integrity.test.ts:60,96 — Removed duplicate existsSync() checks (already covered by isPng() which calls readFileSync)
• NONE security.test.ts:267 — Corrected test description from "should accept" to "should reject" (aligns with actual behavior)
• NONE security.test.ts:439-450 — Removed redundant test loop (all patterns already tested individually)

Tests

• bash -n: N/A (no shell scripts modified)
• bun test: PASS (146 tests, 0 failures)
• curl|bash: N/A (no shell scripts)
• macOS compat: N/A (no shell scripts)

Analysis

The PR correctly removes theatrical test code that provides no additional coverage. The removed existsSync() checks were redundant because isPng() already fails if the file doesn't exist. The removed test loop duplicated coverage already provided by individual test cases. The corrected test description improves security documentation by accurately describing that dangerous patterns in comments are intentionally rejected.

---

-- security/pr-reviewer

[la14-1]

Summary

• Remove redundant existsSync(pngPath) check from icon-integrity "is actual PNG data" tests — file existence is already asserted in the preceding it() block, and isPng() throws if the file is missing anyway
• Remove "should detect multiple dangerous patterns" test from validatePrompt — it retests the same $(…), backtick, ; rm, and | bash/sh patterns that each have their own dedicated it() block immediately above
• Fix misleading test description: "should accept scripts with comments containing dangerous patterns" — the test actually expects a throw (the comment says "this is a known trade-off"); renamed to "should reject…"

Removes 1 test (1381 → 1380) and 18 expect() calls with no loss of coverage.

-- qa/dedup-scanner

[louisgv]

Security Review

Verdict: APPROVED
Commit: 79e565c

Findings

No security issues found. All changes are deletions of duplicate/redundant test code:

• LOW icon-integrity.test.ts:60,96 — Removed duplicate existsSync() checks (already covered by isPng() which calls readFileSync)
• NONE security.test.ts:267 — Corrected test description from "should accept" to "should reject" (aligns with actual behavior)
• NONE security.test.ts:439-450 — Removed redundant test loop (all patterns already tested individually)

Tests

• bash -n: N/A (no shell scripts modified)
• bun test: PASS (146 tests, 0 failures)
• curl|bash: N/A (no shell scripts)
• macOS compat: N/A (no shell scripts)

Analysis

The PR correctly removes theatrical test code that provides no additional coverage. The removed existsSync() checks were redundant because isPng() already fails if the file doesn't exist. The removed test loop duplicated coverage already provided by individual test cases. The corrected test description improves security documentation by accurately describing that dangerous patterns in comments are intentionally rejected.

---

-- security/pr-reviewer

[la14-1]

Summary

• Remove redundant existsSync(pngPath) check from icon-integrity "is actual PNG data" tests — file existence is already asserted in the preceding it() block, and isPng() throws if the file is missing anyway
• Remove "should detect multiple dangerous patterns" test from validatePrompt — it retests the same $(…), backtick, ; rm, and | bash/sh patterns that each have their own dedicated it() block immediately above
• Fix misleading test description: "should accept scripts with comments containing dangerous patterns" — the test actually expects a throw (the comment says "this is a known trade-off"); renamed to "should reject…"

Removes 1 test (1381 → 1380) and 18 expect() calls with no loss of coverage.

-- qa/dedup-scanner

[louisgv]

Security Review

Verdict: APPROVED
Commit: 79e565c

Findings

No security issues found. All changes are deletions of duplicate/redundant test code:

• LOW icon-integrity.test.ts:60,96 — Removed duplicate existsSync() checks (already covered by isPng() which calls readFileSync)
• NONE security.test.ts:267 — Corrected test description from "should accept" to "should reject" (aligns with actual behavior)
• NONE security.test.ts:439-450 — Removed redundant test loop (all patterns already tested individually)

Tests

• bash -n: N/A (no shell scripts modified)
• bun test: PASS (146 tests, 0 failures)
• curl|bash: N/A (no shell scripts)
• macOS compat: N/A (no shell scripts)

Analysis

The PR correctly removes theatrical test code that provides no additional coverage. The removed existsSync() checks were redundant because isPng() already fails if the file doesn't exist. The removed test loop duplicated coverage already provided by individual test cases. The corrected test description improves security documentation by accurately describing that dangerous patterns in comments are intentionally rejected.

---

-- security/pr-reviewer

[la14-1]

Summary

• Remove redundant existsSync(pngPath) check from icon-integrity "is actual PNG data" tests — file existence is already asserted in the preceding it() block, and isPng() throws if the file is missing anyway
• Remove "should detect multiple dangerous patterns" test from validatePrompt — it retests the same $(…), backtick, ; rm, and | bash/sh patterns that each have their own dedicated it() block immediately above
• Fix misleading test description: "should accept scripts with comments containing dangerous patterns" — the test actually expects a throw (the comment says "this is a known trade-off"); renamed to "should reject…"

Removes 1 test (1381 → 1380) and 18 expect() calls with no loss of coverage.

-- qa/dedup-scanner

[louisgv]

Security Review

Verdict: APPROVED
Commit: 79e565c

Findings

No security issues found. All changes are deletions of duplicate/redundant test code:

• LOW icon-integrity.test.ts:60,96 — Removed duplicate existsSync() checks (already covered by isPng() which calls readFileSync)
• NONE security.test.ts:267 — Corrected test description from "should accept" to "should reject" (aligns with actual behavior)
• NONE security.test.ts:439-450 — Removed redundant test loop (all patterns already tested individually)

Tests

• bash -n: N/A (no shell scripts modified)
• bun test: PASS (146 tests, 0 failures)
• curl|bash: N/A (no shell scripts)
• macOS compat: N/A (no shell scripts)

Analysis

The PR correctly removes theatrical test code that provides no additional coverage. The removed existsSync() checks were redundant because isPng() already fails if the file doesn't exist. The removed test loop duplicated coverage already provided by individual test cases. The corrected test description improves security documentation by accurately describing that dangerous patterns in comments are intentionally rejected.

---

-- security/pr-reviewer