Uh oh!
There was an error while loading. Please reload this page.
fix: remove duplicate --model flag from help and error output - #2562
Conversation
louisgv
left a comment
There was a problem hiding this comment.
Security Review
Verdict: APPROVED
Commit: d4787c5
Summary
This PR removes duplicate --model flag documentation from help output and error messages. No security concerns.
Changes Reviewed
packages/cli/package.json- Version bump 0.17.3 → 0.17.5packages/cli/src/commands/help.ts- Removed duplicate--modelline from help textpackages/cli/src/index.ts- Deduplicated--modelflag in error message, improved syntax clarity
Security Findings
None. This is purely a documentation cleanup.
Tests
- bash -n: N/A (no shell scripts modified)
- bun test: PASS (1403 tests, 0 failures)
- biome lint: PASS (121 files checked, no issues)
- curl|bash: N/A (no installation scripts modified)
- macOS compat: N/A (no shell scripts modified)
-- security/pr-reviewer
The --model flag was listed twice in two user-facing outputs: - help.ts USAGE section: lines 11 and 20 both showed --model <id> with different descriptions - index.ts unknown-flag error: lines 118 and 121 both showed --model with different descriptions Both duplicates were introduced when --model support was added. Combined the two entries into one clear line each. Agent: ux-engineer Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
d4787c5 to
b99a6d8Comparela14-1
commented
Mar 13, 2026
Rebased onto latest main to resolve merge conflicts (version bump conflict in -- refactor/pr-maintainer |
louisgv
left a comment
There was a problem hiding this comment.
Security Review
Verdict: APPROVED
Commit: b99a6d8
Summary
This PR removes duplicate --model flag documentation from help output and error messages. No security concerns.
Changes Reviewed
packages/cli/package.json- Version bump 0.17.4 → 0.17.5packages/cli/src/commands/help.ts- Removed duplicate--modelline from help text (line 20)packages/cli/src/index.ts- Deduplicated--modelflag in error message (removed line 121), improved syntax clarity on line 118
Security Findings
None. This is purely a documentation cleanup.
Tests
- bash -n: N/A (no shell scripts modified)
- bun test: PASS (1400 tests, 0 failures)
- biome lint: PASS (121 files checked, no issues)
- curl|bash: N/A (no installation scripts modified)
- macOS compat: N/A (no shell scripts modified)
-- security/pr-reviewer
Uh oh!
There was an error while loading. Please reload this page.
Why: Users running `spawn help` or hitting an unknown-flag error see `--model` listed twice with contradictory descriptions, making the CLI look broken.
What changed
The `--model` flag was duplicated in two user-facing outputs when it was introduced in #2543:
`spawn help` USAGE section (`commands/help.ts`):
Unknown flag error (`index.ts`):
Consolidated into a single `--model, -m ` entry in the error output.
Test plan
-- refactor/ux-engineer