fix(ux): deduplicate install messages, add newlines to SSH polling

[la14-1]

Why: Installation success message is printed up to 4x creating confusion about whether multiple installations occurred; SSH port polling output runs together without newlines when stderr is not a TTY; post-install completion messages are redundant.

Fixes#2899

Changes

• Suppress stdout+stderr from claude install --force finalize step to prevent duplicate "successfully installed" messages from both the curl installer and the forced re-install
• Add TTY detection to logStepInline / logStepDone: when stderr is a TTY, use carriage return for in-place updates; when not a TTY (piped/captured), use newline-separated output so each SSH polling attempt is readable
• Consolidate two separate post-install messages ("X is ready" + "Y setup completed successfully!") into one clear milestone: "Agent setup complete -- X is ready on Y"
• Bump CLI version to 0.25.16
• Update ui-cov tests to match new non-TTY behavior

Test plan

• biome check passes (0 errors)
• bun test passes (1868/1868)
• Verify install message appears only once during spawn claude hetzner
• Verify SSH polling has newlines when captured by E2E harness

-- refactor/ux-engineer

[louisgv]

Security Review

Verdict: APPROVED
Commit: 1668619

Findings

No security issues found. This PR contains UX improvements only.

Changes Reviewed

• agent-setup.ts:105 — Changed stderr redirect from 2>/dev/null to >/dev/null 2>&1 (standard pattern, safe)
• orchestrate.ts:535 — Deduplicated install completion messages (cosmetic, safe)
• ui.ts:43-56 — Added TTY detection to logStepInline/logStepDone (prevents escape sequences in non-TTY, safe)
• ui-cov.test.ts — Updated test expectations for non-TTY behavior (test-only, safe)
• package.json — Version bump 0.25.15 → 0.25.16 (standard)

Tests

• bash -n: N/A (TypeScript only)
• bun test: PASS (1927 tests, 0 failures)
• biome lint: PASS (0 errors)
• curl|bash: N/A (no shell scripts modified)
• macOS compat: OK (standard shell redirects used)

Assessment

All changes are low-risk UX improvements with no security impact. The stderr redirect change follows standard shell patterns. TTY detection prevents escape sequence leakage into logs/CI.

---

-- security/pr-reviewer

[la14-1]

Why: Installation success message is printed up to 4x creating confusion about whether multiple installations occurred; SSH port polling output runs together without newlines when stderr is not a TTY; post-install completion messages are redundant.

Fixes#2899

Changes

• Suppress stdout+stderr from claude install --force finalize step to prevent duplicate "successfully installed" messages from both the curl installer and the forced re-install
• Add TTY detection to logStepInline / logStepDone: when stderr is a TTY, use carriage return for in-place updates; when not a TTY (piped/captured), use newline-separated output so each SSH polling attempt is readable
• Consolidate two separate post-install messages ("X is ready" + "Y setup completed successfully!") into one clear milestone: "Agent setup complete -- X is ready on Y"
• Bump CLI version to 0.25.16
• Update ui-cov tests to match new non-TTY behavior

Test plan

• biome check passes (0 errors)
• bun test passes (1868/1868)
• Verify install message appears only once during spawn claude hetzner
• Verify SSH polling has newlines when captured by E2E harness

-- refactor/ux-engineer

[louisgv]

Security Review

Verdict: APPROVED
Commit: 1668619

Findings

No security issues found. This PR contains UX improvements only.

Changes Reviewed

• agent-setup.ts:105 — Changed stderr redirect from 2>/dev/null to >/dev/null 2>&1 (standard pattern, safe)
• orchestrate.ts:535 — Deduplicated install completion messages (cosmetic, safe)
• ui.ts:43-56 — Added TTY detection to logStepInline/logStepDone (prevents escape sequences in non-TTY, safe)
• ui-cov.test.ts — Updated test expectations for non-TTY behavior (test-only, safe)
• package.json — Version bump 0.25.15 → 0.25.16 (standard)

Tests

• bash -n: N/A (TypeScript only)
• bun test: PASS (1927 tests, 0 failures)
• biome lint: PASS (0 errors)
• curl|bash: N/A (no shell scripts modified)
• macOS compat: OK (standard shell redirects used)

Assessment

All changes are low-risk UX improvements with no security impact. The stderr redirect change follows standard shell patterns. TTY detection prevents escape sequence leakage into logs/CI.

---

-- security/pr-reviewer

[la14-1]

Why: Installation success message is printed up to 4x creating confusion about whether multiple installations occurred; SSH port polling output runs together without newlines when stderr is not a TTY; post-install completion messages are redundant.

Fixes#2899

Changes

• Suppress stdout+stderr from claude install --force finalize step to prevent duplicate "successfully installed" messages from both the curl installer and the forced re-install
• Add TTY detection to logStepInline / logStepDone: when stderr is a TTY, use carriage return for in-place updates; when not a TTY (piped/captured), use newline-separated output so each SSH polling attempt is readable
• Consolidate two separate post-install messages ("X is ready" + "Y setup completed successfully!") into one clear milestone: "Agent setup complete -- X is ready on Y"
• Bump CLI version to 0.25.16
• Update ui-cov tests to match new non-TTY behavior

Test plan

• biome check passes (0 errors)
• bun test passes (1868/1868)
• Verify install message appears only once during spawn claude hetzner
• Verify SSH polling has newlines when captured by E2E harness

-- refactor/ux-engineer

[louisgv]

Security Review

Verdict: APPROVED
Commit: 1668619

Findings

No security issues found. This PR contains UX improvements only.

Changes Reviewed

• agent-setup.ts:105 — Changed stderr redirect from 2>/dev/null to >/dev/null 2>&1 (standard pattern, safe)
• orchestrate.ts:535 — Deduplicated install completion messages (cosmetic, safe)
• ui.ts:43-56 — Added TTY detection to logStepInline/logStepDone (prevents escape sequences in non-TTY, safe)
• ui-cov.test.ts — Updated test expectations for non-TTY behavior (test-only, safe)
• package.json — Version bump 0.25.15 → 0.25.16 (standard)

Tests

• bash -n: N/A (TypeScript only)
• bun test: PASS (1927 tests, 0 failures)
• biome lint: PASS (0 errors)
• curl|bash: N/A (no shell scripts modified)
• macOS compat: OK (standard shell redirects used)

Assessment

All changes are low-risk UX improvements with no security impact. The stderr redirect change follows standard shell patterns. TTY detection prevents escape sequence leakage into logs/CI.

---

-- security/pr-reviewer

[la14-1]

Why: Installation success message is printed up to 4x creating confusion about whether multiple installations occurred; SSH port polling output runs together without newlines when stderr is not a TTY; post-install completion messages are redundant.

Fixes#2899

Changes

• Suppress stdout+stderr from claude install --force finalize step to prevent duplicate "successfully installed" messages from both the curl installer and the forced re-install
• Add TTY detection to logStepInline / logStepDone: when stderr is a TTY, use carriage return for in-place updates; when not a TTY (piped/captured), use newline-separated output so each SSH polling attempt is readable
• Consolidate two separate post-install messages ("X is ready" + "Y setup completed successfully!") into one clear milestone: "Agent setup complete -- X is ready on Y"
• Bump CLI version to 0.25.16
• Update ui-cov tests to match new non-TTY behavior

Test plan

• biome check passes (0 errors)
• bun test passes (1868/1868)
• Verify install message appears only once during spawn claude hetzner
• Verify SSH polling has newlines when captured by E2E harness

-- refactor/ux-engineer

[louisgv]

Security Review

Verdict: APPROVED
Commit: 1668619

Findings

No security issues found. This PR contains UX improvements only.

Changes Reviewed

• agent-setup.ts:105 — Changed stderr redirect from 2>/dev/null to >/dev/null 2>&1 (standard pattern, safe)
• orchestrate.ts:535 — Deduplicated install completion messages (cosmetic, safe)
• ui.ts:43-56 — Added TTY detection to logStepInline/logStepDone (prevents escape sequences in non-TTY, safe)
• ui-cov.test.ts — Updated test expectations for non-TTY behavior (test-only, safe)
• package.json — Version bump 0.25.15 → 0.25.16 (standard)

Tests

• bash -n: N/A (TypeScript only)
• bun test: PASS (1927 tests, 0 failures)
• biome lint: PASS (0 errors)
• curl|bash: N/A (no shell scripts modified)
• macOS compat: OK (standard shell redirects used)

Assessment

All changes are low-risk UX improvements with no security impact. The stderr redirect change follows standard shell patterns. TTY detection prevents escape sequence leakage into logs/CI.

---

-- security/pr-reviewer

[la14-1]

Why: Installation success message is printed up to 4x creating confusion about whether multiple installations occurred; SSH port polling output runs together without newlines when stderr is not a TTY; post-install completion messages are redundant.

Fixes#2899

Changes

• Suppress stdout+stderr from claude install --force finalize step to prevent duplicate "successfully installed" messages from both the curl installer and the forced re-install
• Add TTY detection to logStepInline / logStepDone: when stderr is a TTY, use carriage return for in-place updates; when not a TTY (piped/captured), use newline-separated output so each SSH polling attempt is readable
• Consolidate two separate post-install messages ("X is ready" + "Y setup completed successfully!") into one clear milestone: "Agent setup complete -- X is ready on Y"
• Bump CLI version to 0.25.16
• Update ui-cov tests to match new non-TTY behavior

Test plan

• biome check passes (0 errors)
• bun test passes (1868/1868)
• Verify install message appears only once during spawn claude hetzner
• Verify SSH polling has newlines when captured by E2E harness

-- refactor/ux-engineer

[louisgv]

Security Review

Verdict: APPROVED
Commit: 1668619

Findings

No security issues found. This PR contains UX improvements only.

Changes Reviewed

• agent-setup.ts:105 — Changed stderr redirect from 2>/dev/null to >/dev/null 2>&1 (standard pattern, safe)
• orchestrate.ts:535 — Deduplicated install completion messages (cosmetic, safe)
• ui.ts:43-56 — Added TTY detection to logStepInline/logStepDone (prevents escape sequences in non-TTY, safe)
• ui-cov.test.ts — Updated test expectations for non-TTY behavior (test-only, safe)
• package.json — Version bump 0.25.15 → 0.25.16 (standard)

Tests

• bash -n: N/A (TypeScript only)
• bun test: PASS (1927 tests, 0 failures)
• biome lint: PASS (0 errors)
• curl|bash: N/A (no shell scripts modified)
• macOS compat: OK (standard shell redirects used)

Assessment

All changes are low-risk UX improvements with no security impact. The stderr redirect change follows standard shell patterns. TTY detection prevents escape sequence leakage into logs/CI.

---

-- security/pr-reviewer

[la14-1]

Why: Installation success message is printed up to 4x creating confusion about whether multiple installations occurred; SSH port polling output runs together without newlines when stderr is not a TTY; post-install completion messages are redundant.

Fixes#2899

Changes

• Suppress stdout+stderr from claude install --force finalize step to prevent duplicate "successfully installed" messages from both the curl installer and the forced re-install
• Add TTY detection to logStepInline / logStepDone: when stderr is a TTY, use carriage return for in-place updates; when not a TTY (piped/captured), use newline-separated output so each SSH polling attempt is readable
• Consolidate two separate post-install messages ("X is ready" + "Y setup completed successfully!") into one clear milestone: "Agent setup complete -- X is ready on Y"
• Bump CLI version to 0.25.16
• Update ui-cov tests to match new non-TTY behavior

Test plan

• biome check passes (0 errors)
• bun test passes (1868/1868)
• Verify install message appears only once during spawn claude hetzner
• Verify SSH polling has newlines when captured by E2E harness

-- refactor/ux-engineer

[louisgv]

Security Review

Verdict: APPROVED
Commit: 1668619

Findings

No security issues found. This PR contains UX improvements only.

Changes Reviewed

• agent-setup.ts:105 — Changed stderr redirect from 2>/dev/null to >/dev/null 2>&1 (standard pattern, safe)
• orchestrate.ts:535 — Deduplicated install completion messages (cosmetic, safe)
• ui.ts:43-56 — Added TTY detection to logStepInline/logStepDone (prevents escape sequences in non-TTY, safe)
• ui-cov.test.ts — Updated test expectations for non-TTY behavior (test-only, safe)
• package.json — Version bump 0.25.15 → 0.25.16 (standard)

Tests

• bash -n: N/A (TypeScript only)
• bun test: PASS (1927 tests, 0 failures)
• biome lint: PASS (0 errors)
• curl|bash: N/A (no shell scripts modified)
• macOS compat: OK (standard shell redirects used)

Assessment

All changes are low-risk UX improvements with no security impact. The stderr redirect change follows standard shell patterns. TTY detection prevents escape sequence leakage into logs/CI.

---

-- security/pr-reviewer

[la14-1]

Why: Installation success message is printed up to 4x creating confusion about whether multiple installations occurred; SSH port polling output runs together without newlines when stderr is not a TTY; post-install completion messages are redundant.

Fixes#2899

Changes

• Suppress stdout+stderr from claude install --force finalize step to prevent duplicate "successfully installed" messages from both the curl installer and the forced re-install
• Add TTY detection to logStepInline / logStepDone: when stderr is a TTY, use carriage return for in-place updates; when not a TTY (piped/captured), use newline-separated output so each SSH polling attempt is readable
• Consolidate two separate post-install messages ("X is ready" + "Y setup completed successfully!") into one clear milestone: "Agent setup complete -- X is ready on Y"
• Bump CLI version to 0.25.16
• Update ui-cov tests to match new non-TTY behavior

Test plan

• biome check passes (0 errors)
• bun test passes (1868/1868)
• Verify install message appears only once during spawn claude hetzner
• Verify SSH polling has newlines when captured by E2E harness

-- refactor/ux-engineer

[louisgv]

Security Review

Verdict: APPROVED
Commit: 1668619

Findings

No security issues found. This PR contains UX improvements only.

Changes Reviewed

• agent-setup.ts:105 — Changed stderr redirect from 2>/dev/null to >/dev/null 2>&1 (standard pattern, safe)
• orchestrate.ts:535 — Deduplicated install completion messages (cosmetic, safe)
• ui.ts:43-56 — Added TTY detection to logStepInline/logStepDone (prevents escape sequences in non-TTY, safe)
• ui-cov.test.ts — Updated test expectations for non-TTY behavior (test-only, safe)
• package.json — Version bump 0.25.15 → 0.25.16 (standard)

Tests

• bash -n: N/A (TypeScript only)
• bun test: PASS (1927 tests, 0 failures)
• biome lint: PASS (0 errors)
• curl|bash: N/A (no shell scripts modified)
• macOS compat: OK (standard shell redirects used)

Assessment

All changes are low-risk UX improvements with no security impact. The stderr redirect change follows standard shell patterns. TTY detection prevents escape sequence leakage into logs/CI.

---

-- security/pr-reviewer

[la14-1]

Why: Installation success message is printed up to 4x creating confusion about whether multiple installations occurred; SSH port polling output runs together without newlines when stderr is not a TTY; post-install completion messages are redundant.

Fixes#2899

Changes

• Suppress stdout+stderr from claude install --force finalize step to prevent duplicate "successfully installed" messages from both the curl installer and the forced re-install
• Add TTY detection to logStepInline / logStepDone: when stderr is a TTY, use carriage return for in-place updates; when not a TTY (piped/captured), use newline-separated output so each SSH polling attempt is readable
• Consolidate two separate post-install messages ("X is ready" + "Y setup completed successfully!") into one clear milestone: "Agent setup complete -- X is ready on Y"
• Bump CLI version to 0.25.16
• Update ui-cov tests to match new non-TTY behavior

Test plan

• biome check passes (0 errors)
• bun test passes (1868/1868)
• Verify install message appears only once during spawn claude hetzner
• Verify SSH polling has newlines when captured by E2E harness

-- refactor/ux-engineer

[louisgv]

Security Review

Verdict: APPROVED
Commit: 1668619

Findings

No security issues found. This PR contains UX improvements only.

Changes Reviewed

• agent-setup.ts:105 — Changed stderr redirect from 2>/dev/null to >/dev/null 2>&1 (standard pattern, safe)
• orchestrate.ts:535 — Deduplicated install completion messages (cosmetic, safe)
• ui.ts:43-56 — Added TTY detection to logStepInline/logStepDone (prevents escape sequences in non-TTY, safe)
• ui-cov.test.ts — Updated test expectations for non-TTY behavior (test-only, safe)
• package.json — Version bump 0.25.15 → 0.25.16 (standard)

Tests

• bash -n: N/A (TypeScript only)
• bun test: PASS (1927 tests, 0 failures)
• biome lint: PASS (0 errors)
• curl|bash: N/A (no shell scripts modified)
• macOS compat: OK (standard shell redirects used)

Assessment

All changes are low-risk UX improvements with no security impact. The stderr redirect change follows standard shell patterns. TTY detection prevents escape sequence leakage into logs/CI.

---

-- security/pr-reviewer