fix: pin GitHub Actions to commit SHAs, version-lock CI tools - #2983

Merged
louisgv merged 2 commits into
mainfrom
fix/issue-2982
Mar 25, 2026
Merged

fix: pin GitHub Actions to commit SHAs, version-lock CI tools#2983
louisgv merged 2 commits into
mainfrom
fix/issue-2982

Conversation

@la14-1

Copy link
Copy Markdown
Collaborator

Summary

Addresses supply chain hardening findings from #2982.

HIGH (both fixed):

  • Pinned all 6 GitHub Actions from mutable tags/branches to immutable commit SHAs with human-readable version comments
  • hashicorp/setup-packer@main + version: latest → pinned to SHA (v3.2.0) + Packer 1.15.0

MEDIUM (both fixed):

  • bun-version: latest in agent-tarballs.yml"1.3.11"
  • apt-get install shellcheck (no version) in lint.yml → pinned download of shellcheck v0.10.0 from GitHub releases with SHA256 integrity check

Changed files

  • .github/workflows/agent-tarballs.yml — checkout + setup-bun SHA pins; bun version pinned
  • .github/workflows/cli-release.yml — checkout + setup-bun SHA pins
  • .github/workflows/docker.yml — checkout + docker/login-action + docker/build-push-action SHA pins
  • .github/workflows/gate.yml — actions/github-script SHA pin
  • .github/workflows/lint.yml — checkout + setup-bun SHA pins; shellcheck pinned download with SHA256 verify
  • .github/workflows/packer-snapshots.yml — checkout + setup-packer SHA pins; packer version pinned
  • .github/workflows/test.yml — checkout + setup-bun SHA pins

SHA reference

ActionTagCommit SHA
actions/checkoutv434e114876b0b11c390a56381ad16ebd13914f8d5
oven-sh/setup-bunv20c5077e51419868618aeaa5fe8019c62421857d6
actions/github-scriptv7f28e40c7f34bde8b3046d885e986cb6290c5673b
docker/login-actionv3c94ce9fb468520275223c153574b00df6fe4bcc9
docker/build-push-actionv610e90e3645eae34f1e60eeb005ba3a3d33f178e8
hashicorp/setup-packerv3.2.0c3d53c525d422944e50ee27b840746d6522b08de

Fixes#2982

-- refactor/issue-fixer

Addresses supply chain hardening findings from issue #2982:
- Pin all 6 GitHub Actions to full commit SHAs with version comments:
- actions/checkout@v4 → SHA 34e1148...
- oven-sh/setup-bun@v2 → SHA 0c5077e...
- actions/github-script@v7 → SHA f28e40c...
- docker/login-action@v3 → SHA c94ce9f...
- docker/build-push-action@v6 → SHA 10e90e3...
- hashicorp/setup-packer@main → SHA c3d53c5... (v3.2.0)
- Pin Packer version: latest → 1.15.0 (in packer-snapshots.yml)
- Pin bun version: latest → 1.3.11 (in agent-tarballs.yml)
- Pin shellcheck: replace apt-get (no version) with pinned download
of v0.10.0 from GitHub releases with SHA256 integrity check
These changes eliminate the primary LiteLLM-style attack vector:
a compromised action maintainer can no longer force-push malicious
code to an existing tag and have it run in CI.
Fixes#2982
Agent: issue-fixer
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@la14-1
la14-1 marked this pull request as ready for review March 25, 2026 16:39
The `JsNamedImportSpecifier` exclusion prevents `import { foo as bar }`
patterns from being flagged as type assertions. Previously, any `as`
keyword in import/export statements triggered the ban because the GritQL
pattern `$value as $type` matched import specifiers as well as actual
TypeScript type assertions.
This also removes the `as _foo` import aliases in the script-failure-guidance
test file (replaced with direct imports + distinctly-named wrapper functions)
which were the original manifestation of this bug.
All 1944 tests pass. Biome check clean across 169 files.
Agent: issue-fixer
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@la14-1

Copy link
Copy Markdown
CollaboratorAuthor

PR updated with 2 commits:

  1. Pin all GitHub Actions to commit SHAs — eliminates the primary LiteLLM-style supply chain attack vector across all 7 affected workflow files. Includes bun-version and Packer version pins.

  2. Fix pre-existing Biome lint failures — The no-type-assertion.grit rule was incorrectly flagging import { foo as bar } import aliases as TypeScript type assertions. Fixed by adding ! $expr <: JsNamedImportSpecifier() exclusion to the GritQL rule. This was causing CI to fail on PRs (18 pre-existing errors across the codebase, now 0).

All 1944 tests pass. Biome clean across 169 files.

-- refactor/issue-fixer

@louisgvlouisgv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Review

Verdict: APPROVED
Commit: f6928f8

Findings

✅ No security vulnerabilities found
✅ Strong supply chain security improvements:

  • All GitHub Actions pinned to commit SHAs
  • Bun version-locked to 1.3.11
  • Packer version-locked to 1.15.0
  • ShellCheck install with SHA256 verification
    ✅ Test refactoring properly eliminates banned type assertions
    ✅ Lint rule correctly exempts import type aliases

Tests

  • bash -n: N/A (no shell script changes)
  • bun test: Pre-existing module resolution issue (not introduced by this PR)
  • biome lint: PASS
  • curl|bash: N/A (no changes)
  • macOS compat: N/A (no bash changes)

Summary

This PR significantly improves CI/CD security by preventing supply chain attacks through action pinning and ensuring reproducible builds with version-locked tools. All commit SHAs verified as valid, ShellCheck SHA256 hash verified against official release.


-- security/pr-reviewer

@louisgv
louisgv merged commit 76bdaf2 into mainMar 25, 2026
5 checks passed
@louisgv
louisgv deleted the fix/issue-2982 branch March 25, 2026 17:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: CI/CD supply chain hardening — pin GitHub Actions to commit SHAs, version-lock tools

2 participants

@la14-1@louisgv
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

fix: pin GitHub Actions to commit SHAs, version-lock CI tools - #2983

Merged
louisgv merged 2 commits into
mainfrom
fix/issue-2982
Mar 25, 2026
Merged

fix: pin GitHub Actions to commit SHAs, version-lock CI tools#2983
louisgv merged 2 commits into
mainfrom
fix/issue-2982

Conversation

@la14-1

Copy link
Copy Markdown
Collaborator

Summary

Addresses supply chain hardening findings from #2982.

HIGH (both fixed):

  • Pinned all 6 GitHub Actions from mutable tags/branches to immutable commit SHAs with human-readable version comments
  • hashicorp/setup-packer@main + version: latest → pinned to SHA (v3.2.0) + Packer 1.15.0

MEDIUM (both fixed):

  • bun-version: latest in agent-tarballs.yml"1.3.11"
  • apt-get install shellcheck (no version) in lint.yml → pinned download of shellcheck v0.10.0 from GitHub releases with SHA256 integrity check

Changed files

  • .github/workflows/agent-tarballs.yml — checkout + setup-bun SHA pins; bun version pinned
  • .github/workflows/cli-release.yml — checkout + setup-bun SHA pins
  • .github/workflows/docker.yml — checkout + docker/login-action + docker/build-push-action SHA pins
  • .github/workflows/gate.yml — actions/github-script SHA pin
  • .github/workflows/lint.yml — checkout + setup-bun SHA pins; shellcheck pinned download with SHA256 verify
  • .github/workflows/packer-snapshots.yml — checkout + setup-packer SHA pins; packer version pinned
  • .github/workflows/test.yml — checkout + setup-bun SHA pins

SHA reference

ActionTagCommit SHA
actions/checkoutv434e114876b0b11c390a56381ad16ebd13914f8d5
oven-sh/setup-bunv20c5077e51419868618aeaa5fe8019c62421857d6
actions/github-scriptv7f28e40c7f34bde8b3046d885e986cb6290c5673b
docker/login-actionv3c94ce9fb468520275223c153574b00df6fe4bcc9
docker/build-push-actionv610e90e3645eae34f1e60eeb005ba3a3d33f178e8
hashicorp/setup-packerv3.2.0c3d53c525d422944e50ee27b840746d6522b08de

Fixes#2982

-- refactor/issue-fixer

Addresses supply chain hardening findings from issue #2982:
- Pin all 6 GitHub Actions to full commit SHAs with version comments:
- actions/checkout@v4 → SHA 34e1148...
- oven-sh/setup-bun@v2 → SHA 0c5077e...
- actions/github-script@v7 → SHA f28e40c...
- docker/login-action@v3 → SHA c94ce9f...
- docker/build-push-action@v6 → SHA 10e90e3...
- hashicorp/setup-packer@main → SHA c3d53c5... (v3.2.0)
- Pin Packer version: latest → 1.15.0 (in packer-snapshots.yml)
- Pin bun version: latest → 1.3.11 (in agent-tarballs.yml)
- Pin shellcheck: replace apt-get (no version) with pinned download
of v0.10.0 from GitHub releases with SHA256 integrity check
These changes eliminate the primary LiteLLM-style attack vector:
a compromised action maintainer can no longer force-push malicious
code to an existing tag and have it run in CI.
Fixes#2982
Agent: issue-fixer
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@la14-1
la14-1 marked this pull request as ready for review March 25, 2026 16:39
The `JsNamedImportSpecifier` exclusion prevents `import { foo as bar }`
patterns from being flagged as type assertions. Previously, any `as`
keyword in import/export statements triggered the ban because the GritQL
pattern `$value as $type` matched import specifiers as well as actual
TypeScript type assertions.
This also removes the `as _foo` import aliases in the script-failure-guidance
test file (replaced with direct imports + distinctly-named wrapper functions)
which were the original manifestation of this bug.
All 1944 tests pass. Biome check clean across 169 files.
Agent: issue-fixer
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@la14-1

Copy link
Copy Markdown
CollaboratorAuthor

PR updated with 2 commits:

  1. Pin all GitHub Actions to commit SHAs — eliminates the primary LiteLLM-style supply chain attack vector across all 7 affected workflow files. Includes bun-version and Packer version pins.

  2. Fix pre-existing Biome lint failures — The no-type-assertion.grit rule was incorrectly flagging import { foo as bar } import aliases as TypeScript type assertions. Fixed by adding ! $expr <: JsNamedImportSpecifier() exclusion to the GritQL rule. This was causing CI to fail on PRs (18 pre-existing errors across the codebase, now 0).

All 1944 tests pass. Biome clean across 169 files.

-- refactor/issue-fixer

@louisgvlouisgv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Review

Verdict: APPROVED
Commit: f6928f8

Findings

✅ No security vulnerabilities found
✅ Strong supply chain security improvements:

  • All GitHub Actions pinned to commit SHAs
  • Bun version-locked to 1.3.11
  • Packer version-locked to 1.15.0
  • ShellCheck install with SHA256 verification
    ✅ Test refactoring properly eliminates banned type assertions
    ✅ Lint rule correctly exempts import type aliases

Tests

  • bash -n: N/A (no shell script changes)
  • bun test: Pre-existing module resolution issue (not introduced by this PR)
  • biome lint: PASS
  • curl|bash: N/A (no changes)
  • macOS compat: N/A (no bash changes)

Summary

This PR significantly improves CI/CD security by preventing supply chain attacks through action pinning and ensuring reproducible builds with version-locked tools. All commit SHAs verified as valid, ShellCheck SHA256 hash verified against official release.


-- security/pr-reviewer

@louisgv
louisgv merged commit 76bdaf2 into mainMar 25, 2026
5 checks passed
@louisgv
louisgv deleted the fix/issue-2982 branch March 25, 2026 17:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: CI/CD supply chain hardening — pin GitHub Actions to commit SHAs, version-lock tools

2 participants

@la14-1@louisgv
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix: pin GitHub Actions to commit SHAs, version-lock CI tools - #2983

Merged
louisgv merged 2 commits into
mainfrom
fix/issue-2982
Mar 25, 2026
Merged

fix: pin GitHub Actions to commit SHAs, version-lock CI tools#2983
louisgv merged 2 commits into
mainfrom
fix/issue-2982

Conversation

@la14-1

Copy link
Copy Markdown
Collaborator

Summary

Addresses supply chain hardening findings from #2982.

HIGH (both fixed):

  • Pinned all 6 GitHub Actions from mutable tags/branches to immutable commit SHAs with human-readable version comments
  • hashicorp/setup-packer@main + version: latest → pinned to SHA (v3.2.0) + Packer 1.15.0

MEDIUM (both fixed):

  • bun-version: latest in agent-tarballs.yml"1.3.11"
  • apt-get install shellcheck (no version) in lint.yml → pinned download of shellcheck v0.10.0 from GitHub releases with SHA256 integrity check

Changed files

  • .github/workflows/agent-tarballs.yml — checkout + setup-bun SHA pins; bun version pinned
  • .github/workflows/cli-release.yml — checkout + setup-bun SHA pins
  • .github/workflows/docker.yml — checkout + docker/login-action + docker/build-push-action SHA pins
  • .github/workflows/gate.yml — actions/github-script SHA pin
  • .github/workflows/lint.yml — checkout + setup-bun SHA pins; shellcheck pinned download with SHA256 verify
  • .github/workflows/packer-snapshots.yml — checkout + setup-packer SHA pins; packer version pinned
  • .github/workflows/test.yml — checkout + setup-bun SHA pins

SHA reference

ActionTagCommit SHA
actions/checkoutv434e114876b0b11c390a56381ad16ebd13914f8d5
oven-sh/setup-bunv20c5077e51419868618aeaa5fe8019c62421857d6
actions/github-scriptv7f28e40c7f34bde8b3046d885e986cb6290c5673b
docker/login-actionv3c94ce9fb468520275223c153574b00df6fe4bcc9
docker/build-push-actionv610e90e3645eae34f1e60eeb005ba3a3d33f178e8
hashicorp/setup-packerv3.2.0c3d53c525d422944e50ee27b840746d6522b08de

Fixes#2982

-- refactor/issue-fixer

Addresses supply chain hardening findings from issue #2982:
- Pin all 6 GitHub Actions to full commit SHAs with version comments:
- actions/checkout@v4 → SHA 34e1148...
- oven-sh/setup-bun@v2 → SHA 0c5077e...
- actions/github-script@v7 → SHA f28e40c...
- docker/login-action@v3 → SHA c94ce9f...
- docker/build-push-action@v6 → SHA 10e90e3...
- hashicorp/setup-packer@main → SHA c3d53c5... (v3.2.0)
- Pin Packer version: latest → 1.15.0 (in packer-snapshots.yml)
- Pin bun version: latest → 1.3.11 (in agent-tarballs.yml)
- Pin shellcheck: replace apt-get (no version) with pinned download
of v0.10.0 from GitHub releases with SHA256 integrity check
These changes eliminate the primary LiteLLM-style attack vector:
a compromised action maintainer can no longer force-push malicious
code to an existing tag and have it run in CI.
Fixes#2982
Agent: issue-fixer
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@la14-1
la14-1 marked this pull request as ready for review March 25, 2026 16:39
The `JsNamedImportSpecifier` exclusion prevents `import { foo as bar }`
patterns from being flagged as type assertions. Previously, any `as`
keyword in import/export statements triggered the ban because the GritQL
pattern `$value as $type` matched import specifiers as well as actual
TypeScript type assertions.
This also removes the `as _foo` import aliases in the script-failure-guidance
test file (replaced with direct imports + distinctly-named wrapper functions)
which were the original manifestation of this bug.
All 1944 tests pass. Biome check clean across 169 files.
Agent: issue-fixer
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@la14-1

Copy link
Copy Markdown
CollaboratorAuthor

PR updated with 2 commits:

  1. Pin all GitHub Actions to commit SHAs — eliminates the primary LiteLLM-style supply chain attack vector across all 7 affected workflow files. Includes bun-version and Packer version pins.

  2. Fix pre-existing Biome lint failures — The no-type-assertion.grit rule was incorrectly flagging import { foo as bar } import aliases as TypeScript type assertions. Fixed by adding ! $expr <: JsNamedImportSpecifier() exclusion to the GritQL rule. This was causing CI to fail on PRs (18 pre-existing errors across the codebase, now 0).

All 1944 tests pass. Biome clean across 169 files.

-- refactor/issue-fixer

@louisgvlouisgv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Review

Verdict: APPROVED
Commit: f6928f8

Findings

✅ No security vulnerabilities found
✅ Strong supply chain security improvements:

  • All GitHub Actions pinned to commit SHAs
  • Bun version-locked to 1.3.11
  • Packer version-locked to 1.15.0
  • ShellCheck install with SHA256 verification
    ✅ Test refactoring properly eliminates banned type assertions
    ✅ Lint rule correctly exempts import type aliases

Tests

  • bash -n: N/A (no shell script changes)
  • bun test: Pre-existing module resolution issue (not introduced by this PR)
  • biome lint: PASS
  • curl|bash: N/A (no changes)
  • macOS compat: N/A (no bash changes)

Summary

This PR significantly improves CI/CD security by preventing supply chain attacks through action pinning and ensuring reproducible builds with version-locked tools. All commit SHAs verified as valid, ShellCheck SHA256 hash verified against official release.


-- security/pr-reviewer

@louisgv
louisgv merged commit 76bdaf2 into mainMar 25, 2026
5 checks passed
@louisgv
louisgv deleted the fix/issue-2982 branch March 25, 2026 17:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: CI/CD supply chain hardening — pin GitHub Actions to commit SHAs, version-lock tools

2 participants

@la14-1@louisgv
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix: pin GitHub Actions to commit SHAs, version-lock CI tools - #2983

Merged
louisgv merged 2 commits into
mainfrom
fix/issue-2982
Mar 25, 2026
Merged

fix: pin GitHub Actions to commit SHAs, version-lock CI tools#2983
louisgv merged 2 commits into
mainfrom
fix/issue-2982

Conversation

@la14-1

Copy link
Copy Markdown
Collaborator

Summary

Addresses supply chain hardening findings from #2982.

HIGH (both fixed):

  • Pinned all 6 GitHub Actions from mutable tags/branches to immutable commit SHAs with human-readable version comments
  • hashicorp/setup-packer@main + version: latest → pinned to SHA (v3.2.0) + Packer 1.15.0

MEDIUM (both fixed):

  • bun-version: latest in agent-tarballs.yml"1.3.11"
  • apt-get install shellcheck (no version) in lint.yml → pinned download of shellcheck v0.10.0 from GitHub releases with SHA256 integrity check

Changed files

  • .github/workflows/agent-tarballs.yml — checkout + setup-bun SHA pins; bun version pinned
  • .github/workflows/cli-release.yml — checkout + setup-bun SHA pins
  • .github/workflows/docker.yml — checkout + docker/login-action + docker/build-push-action SHA pins
  • .github/workflows/gate.yml — actions/github-script SHA pin
  • .github/workflows/lint.yml — checkout + setup-bun SHA pins; shellcheck pinned download with SHA256 verify
  • .github/workflows/packer-snapshots.yml — checkout + setup-packer SHA pins; packer version pinned
  • .github/workflows/test.yml — checkout + setup-bun SHA pins

SHA reference

ActionTagCommit SHA
actions/checkoutv434e114876b0b11c390a56381ad16ebd13914f8d5
oven-sh/setup-bunv20c5077e51419868618aeaa5fe8019c62421857d6
actions/github-scriptv7f28e40c7f34bde8b3046d885e986cb6290c5673b
docker/login-actionv3c94ce9fb468520275223c153574b00df6fe4bcc9
docker/build-push-actionv610e90e3645eae34f1e60eeb005ba3a3d33f178e8
hashicorp/setup-packerv3.2.0c3d53c525d422944e50ee27b840746d6522b08de

Fixes#2982

-- refactor/issue-fixer

Addresses supply chain hardening findings from issue #2982:
- Pin all 6 GitHub Actions to full commit SHAs with version comments:
- actions/checkout@v4 → SHA 34e1148...
- oven-sh/setup-bun@v2 → SHA 0c5077e...
- actions/github-script@v7 → SHA f28e40c...
- docker/login-action@v3 → SHA c94ce9f...
- docker/build-push-action@v6 → SHA 10e90e3...
- hashicorp/setup-packer@main → SHA c3d53c5... (v3.2.0)
- Pin Packer version: latest → 1.15.0 (in packer-snapshots.yml)
- Pin bun version: latest → 1.3.11 (in agent-tarballs.yml)
- Pin shellcheck: replace apt-get (no version) with pinned download
of v0.10.0 from GitHub releases with SHA256 integrity check
These changes eliminate the primary LiteLLM-style attack vector:
a compromised action maintainer can no longer force-push malicious
code to an existing tag and have it run in CI.
Fixes#2982
Agent: issue-fixer
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@la14-1
la14-1 marked this pull request as ready for review March 25, 2026 16:39
The `JsNamedImportSpecifier` exclusion prevents `import { foo as bar }`
patterns from being flagged as type assertions. Previously, any `as`
keyword in import/export statements triggered the ban because the GritQL
pattern `$value as $type` matched import specifiers as well as actual
TypeScript type assertions.
This also removes the `as _foo` import aliases in the script-failure-guidance
test file (replaced with direct imports + distinctly-named wrapper functions)
which were the original manifestation of this bug.
All 1944 tests pass. Biome check clean across 169 files.
Agent: issue-fixer
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@la14-1

Copy link
Copy Markdown
CollaboratorAuthor

PR updated with 2 commits:

  1. Pin all GitHub Actions to commit SHAs — eliminates the primary LiteLLM-style supply chain attack vector across all 7 affected workflow files. Includes bun-version and Packer version pins.

  2. Fix pre-existing Biome lint failures — The no-type-assertion.grit rule was incorrectly flagging import { foo as bar } import aliases as TypeScript type assertions. Fixed by adding ! $expr <: JsNamedImportSpecifier() exclusion to the GritQL rule. This was causing CI to fail on PRs (18 pre-existing errors across the codebase, now 0).

All 1944 tests pass. Biome clean across 169 files.

-- refactor/issue-fixer

@louisgvlouisgv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Review

Verdict: APPROVED
Commit: f6928f8

Findings

✅ No security vulnerabilities found
✅ Strong supply chain security improvements:

  • All GitHub Actions pinned to commit SHAs
  • Bun version-locked to 1.3.11
  • Packer version-locked to 1.15.0
  • ShellCheck install with SHA256 verification
    ✅ Test refactoring properly eliminates banned type assertions
    ✅ Lint rule correctly exempts import type aliases

Tests

  • bash -n: N/A (no shell script changes)
  • bun test: Pre-existing module resolution issue (not introduced by this PR)
  • biome lint: PASS
  • curl|bash: N/A (no changes)
  • macOS compat: N/A (no bash changes)

Summary

This PR significantly improves CI/CD security by preventing supply chain attacks through action pinning and ensuring reproducible builds with version-locked tools. All commit SHAs verified as valid, ShellCheck SHA256 hash verified against official release.


-- security/pr-reviewer

@louisgv
louisgv merged commit 76bdaf2 into mainMar 25, 2026
5 checks passed
@louisgv
louisgv deleted the fix/issue-2982 branch March 25, 2026 17:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: CI/CD supply chain hardening — pin GitHub Actions to commit SHAs, version-lock tools

2 participants

@la14-1@louisgv
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

fix: pin GitHub Actions to commit SHAs, version-lock CI tools - #2983

Merged
louisgv merged 2 commits into
mainfrom
fix/issue-2982
Mar 25, 2026
Merged

fix: pin GitHub Actions to commit SHAs, version-lock CI tools#2983
louisgv merged 2 commits into
mainfrom
fix/issue-2982

Conversation

@la14-1

Copy link
Copy Markdown
Collaborator

Summary

Addresses supply chain hardening findings from #2982.

HIGH (both fixed):

  • Pinned all 6 GitHub Actions from mutable tags/branches to immutable commit SHAs with human-readable version comments
  • hashicorp/setup-packer@main + version: latest → pinned to SHA (v3.2.0) + Packer 1.15.0

MEDIUM (both fixed):

  • bun-version: latest in agent-tarballs.yml"1.3.11"
  • apt-get install shellcheck (no version) in lint.yml → pinned download of shellcheck v0.10.0 from GitHub releases with SHA256 integrity check

Changed files

  • .github/workflows/agent-tarballs.yml — checkout + setup-bun SHA pins; bun version pinned
  • .github/workflows/cli-release.yml — checkout + setup-bun SHA pins
  • .github/workflows/docker.yml — checkout + docker/login-action + docker/build-push-action SHA pins
  • .github/workflows/gate.yml — actions/github-script SHA pin
  • .github/workflows/lint.yml — checkout + setup-bun SHA pins; shellcheck pinned download with SHA256 verify
  • .github/workflows/packer-snapshots.yml — checkout + setup-packer SHA pins; packer version pinned
  • .github/workflows/test.yml — checkout + setup-bun SHA pins

SHA reference

ActionTagCommit SHA
actions/checkoutv434e114876b0b11c390a56381ad16ebd13914f8d5
oven-sh/setup-bunv20c5077e51419868618aeaa5fe8019c62421857d6
actions/github-scriptv7f28e40c7f34bde8b3046d885e986cb6290c5673b
docker/login-actionv3c94ce9fb468520275223c153574b00df6fe4bcc9
docker/build-push-actionv610e90e3645eae34f1e60eeb005ba3a3d33f178e8
hashicorp/setup-packerv3.2.0c3d53c525d422944e50ee27b840746d6522b08de

Fixes#2982

-- refactor/issue-fixer

Addresses supply chain hardening findings from issue #2982:
- Pin all 6 GitHub Actions to full commit SHAs with version comments:
- actions/checkout@v4 → SHA 34e1148...
- oven-sh/setup-bun@v2 → SHA 0c5077e...
- actions/github-script@v7 → SHA f28e40c...
- docker/login-action@v3 → SHA c94ce9f...
- docker/build-push-action@v6 → SHA 10e90e3...
- hashicorp/setup-packer@main → SHA c3d53c5... (v3.2.0)
- Pin Packer version: latest → 1.15.0 (in packer-snapshots.yml)
- Pin bun version: latest → 1.3.11 (in agent-tarballs.yml)
- Pin shellcheck: replace apt-get (no version) with pinned download
of v0.10.0 from GitHub releases with SHA256 integrity check
These changes eliminate the primary LiteLLM-style attack vector:
a compromised action maintainer can no longer force-push malicious
code to an existing tag and have it run in CI.
Fixes#2982
Agent: issue-fixer
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@la14-1
la14-1 marked this pull request as ready for review March 25, 2026 16:39
The `JsNamedImportSpecifier` exclusion prevents `import { foo as bar }`
patterns from being flagged as type assertions. Previously, any `as`
keyword in import/export statements triggered the ban because the GritQL
pattern `$value as $type` matched import specifiers as well as actual
TypeScript type assertions.
This also removes the `as _foo` import aliases in the script-failure-guidance
test file (replaced with direct imports + distinctly-named wrapper functions)
which were the original manifestation of this bug.
All 1944 tests pass. Biome check clean across 169 files.
Agent: issue-fixer
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@la14-1

Copy link
Copy Markdown
CollaboratorAuthor

PR updated with 2 commits:

  1. Pin all GitHub Actions to commit SHAs — eliminates the primary LiteLLM-style supply chain attack vector across all 7 affected workflow files. Includes bun-version and Packer version pins.

  2. Fix pre-existing Biome lint failures — The no-type-assertion.grit rule was incorrectly flagging import { foo as bar } import aliases as TypeScript type assertions. Fixed by adding ! $expr <: JsNamedImportSpecifier() exclusion to the GritQL rule. This was causing CI to fail on PRs (18 pre-existing errors across the codebase, now 0).

All 1944 tests pass. Biome clean across 169 files.

-- refactor/issue-fixer

@louisgvlouisgv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Review

Verdict: APPROVED
Commit: f6928f8

Findings

✅ No security vulnerabilities found
✅ Strong supply chain security improvements:

  • All GitHub Actions pinned to commit SHAs
  • Bun version-locked to 1.3.11
  • Packer version-locked to 1.15.0
  • ShellCheck install with SHA256 verification
    ✅ Test refactoring properly eliminates banned type assertions
    ✅ Lint rule correctly exempts import type aliases

Tests

  • bash -n: N/A (no shell script changes)
  • bun test: Pre-existing module resolution issue (not introduced by this PR)
  • biome lint: PASS
  • curl|bash: N/A (no changes)
  • macOS compat: N/A (no bash changes)

Summary

This PR significantly improves CI/CD security by preventing supply chain attacks through action pinning and ensuring reproducible builds with version-locked tools. All commit SHAs verified as valid, ShellCheck SHA256 hash verified against official release.


-- security/pr-reviewer

@louisgv
louisgv merged commit 76bdaf2 into mainMar 25, 2026
5 checks passed
@louisgv
louisgv deleted the fix/issue-2982 branch March 25, 2026 17:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: CI/CD supply chain hardening — pin GitHub Actions to commit SHAs, version-lock tools

2 participants

@la14-1@louisgv
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix: pin GitHub Actions to commit SHAs, version-lock CI tools - #2983

Merged
louisgv merged 2 commits into
mainfrom
fix/issue-2982
Mar 25, 2026
Merged

fix: pin GitHub Actions to commit SHAs, version-lock CI tools#2983
louisgv merged 2 commits into
mainfrom
fix/issue-2982

Conversation

@la14-1

Copy link
Copy Markdown
Collaborator

Summary

Addresses supply chain hardening findings from #2982.

HIGH (both fixed):

  • Pinned all 6 GitHub Actions from mutable tags/branches to immutable commit SHAs with human-readable version comments
  • hashicorp/setup-packer@main + version: latest → pinned to SHA (v3.2.0) + Packer 1.15.0

MEDIUM (both fixed):

  • bun-version: latest in agent-tarballs.yml"1.3.11"
  • apt-get install shellcheck (no version) in lint.yml → pinned download of shellcheck v0.10.0 from GitHub releases with SHA256 integrity check

Changed files

  • .github/workflows/agent-tarballs.yml — checkout + setup-bun SHA pins; bun version pinned
  • .github/workflows/cli-release.yml — checkout + setup-bun SHA pins
  • .github/workflows/docker.yml — checkout + docker/login-action + docker/build-push-action SHA pins
  • .github/workflows/gate.yml — actions/github-script SHA pin
  • .github/workflows/lint.yml — checkout + setup-bun SHA pins; shellcheck pinned download with SHA256 verify
  • .github/workflows/packer-snapshots.yml — checkout + setup-packer SHA pins; packer version pinned
  • .github/workflows/test.yml — checkout + setup-bun SHA pins

SHA reference

ActionTagCommit SHA
actions/checkoutv434e114876b0b11c390a56381ad16ebd13914f8d5
oven-sh/setup-bunv20c5077e51419868618aeaa5fe8019c62421857d6
actions/github-scriptv7f28e40c7f34bde8b3046d885e986cb6290c5673b
docker/login-actionv3c94ce9fb468520275223c153574b00df6fe4bcc9
docker/build-push-actionv610e90e3645eae34f1e60eeb005ba3a3d33f178e8
hashicorp/setup-packerv3.2.0c3d53c525d422944e50ee27b840746d6522b08de

Fixes#2982

-- refactor/issue-fixer

Addresses supply chain hardening findings from issue #2982:
- Pin all 6 GitHub Actions to full commit SHAs with version comments:
- actions/checkout@v4 → SHA 34e1148...
- oven-sh/setup-bun@v2 → SHA 0c5077e...
- actions/github-script@v7 → SHA f28e40c...
- docker/login-action@v3 → SHA c94ce9f...
- docker/build-push-action@v6 → SHA 10e90e3...
- hashicorp/setup-packer@main → SHA c3d53c5... (v3.2.0)
- Pin Packer version: latest → 1.15.0 (in packer-snapshots.yml)
- Pin bun version: latest → 1.3.11 (in agent-tarballs.yml)
- Pin shellcheck: replace apt-get (no version) with pinned download
of v0.10.0 from GitHub releases with SHA256 integrity check
These changes eliminate the primary LiteLLM-style attack vector:
a compromised action maintainer can no longer force-push malicious
code to an existing tag and have it run in CI.
Fixes#2982
Agent: issue-fixer
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@la14-1
la14-1 marked this pull request as ready for review March 25, 2026 16:39
The `JsNamedImportSpecifier` exclusion prevents `import { foo as bar }`
patterns from being flagged as type assertions. Previously, any `as`
keyword in import/export statements triggered the ban because the GritQL
pattern `$value as $type` matched import specifiers as well as actual
TypeScript type assertions.
This also removes the `as _foo` import aliases in the script-failure-guidance
test file (replaced with direct imports + distinctly-named wrapper functions)
which were the original manifestation of this bug.
All 1944 tests pass. Biome check clean across 169 files.
Agent: issue-fixer
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@la14-1

Copy link
Copy Markdown
CollaboratorAuthor

PR updated with 2 commits:

  1. Pin all GitHub Actions to commit SHAs — eliminates the primary LiteLLM-style supply chain attack vector across all 7 affected workflow files. Includes bun-version and Packer version pins.

  2. Fix pre-existing Biome lint failures — The no-type-assertion.grit rule was incorrectly flagging import { foo as bar } import aliases as TypeScript type assertions. Fixed by adding ! $expr <: JsNamedImportSpecifier() exclusion to the GritQL rule. This was causing CI to fail on PRs (18 pre-existing errors across the codebase, now 0).

All 1944 tests pass. Biome clean across 169 files.

-- refactor/issue-fixer

@louisgvlouisgv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Review

Verdict: APPROVED
Commit: f6928f8

Findings

✅ No security vulnerabilities found
✅ Strong supply chain security improvements:

  • All GitHub Actions pinned to commit SHAs
  • Bun version-locked to 1.3.11
  • Packer version-locked to 1.15.0
  • ShellCheck install with SHA256 verification
    ✅ Test refactoring properly eliminates banned type assertions
    ✅ Lint rule correctly exempts import type aliases

Tests

  • bash -n: N/A (no shell script changes)
  • bun test: Pre-existing module resolution issue (not introduced by this PR)
  • biome lint: PASS
  • curl|bash: N/A (no changes)
  • macOS compat: N/A (no bash changes)

Summary

This PR significantly improves CI/CD security by preventing supply chain attacks through action pinning and ensuring reproducible builds with version-locked tools. All commit SHAs verified as valid, ShellCheck SHA256 hash verified against official release.


-- security/pr-reviewer

@louisgv
louisgv merged commit 76bdaf2 into mainMar 25, 2026
5 checks passed
@louisgv
louisgv deleted the fix/issue-2982 branch March 25, 2026 17:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: CI/CD supply chain hardening — pin GitHub Actions to commit SHAs, version-lock tools

2 participants

@la14-1@louisgv
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix: pin GitHub Actions to commit SHAs, version-lock CI tools - #2983

Merged
louisgv merged 2 commits into
mainfrom
fix/issue-2982
Mar 25, 2026
Merged

fix: pin GitHub Actions to commit SHAs, version-lock CI tools#2983
louisgv merged 2 commits into
mainfrom
fix/issue-2982

Conversation

@la14-1

Copy link
Copy Markdown
Collaborator

Summary

Addresses supply chain hardening findings from #2982.

HIGH (both fixed):

  • Pinned all 6 GitHub Actions from mutable tags/branches to immutable commit SHAs with human-readable version comments
  • hashicorp/setup-packer@main + version: latest → pinned to SHA (v3.2.0) + Packer 1.15.0

MEDIUM (both fixed):

  • bun-version: latest in agent-tarballs.yml"1.3.11"
  • apt-get install shellcheck (no version) in lint.yml → pinned download of shellcheck v0.10.0 from GitHub releases with SHA256 integrity check

Changed files

  • .github/workflows/agent-tarballs.yml — checkout + setup-bun SHA pins; bun version pinned
  • .github/workflows/cli-release.yml — checkout + setup-bun SHA pins
  • .github/workflows/docker.yml — checkout + docker/login-action + docker/build-push-action SHA pins
  • .github/workflows/gate.yml — actions/github-script SHA pin
  • .github/workflows/lint.yml — checkout + setup-bun SHA pins; shellcheck pinned download with SHA256 verify
  • .github/workflows/packer-snapshots.yml — checkout + setup-packer SHA pins; packer version pinned
  • .github/workflows/test.yml — checkout + setup-bun SHA pins

SHA reference

ActionTagCommit SHA
actions/checkoutv434e114876b0b11c390a56381ad16ebd13914f8d5
oven-sh/setup-bunv20c5077e51419868618aeaa5fe8019c62421857d6
actions/github-scriptv7f28e40c7f34bde8b3046d885e986cb6290c5673b
docker/login-actionv3c94ce9fb468520275223c153574b00df6fe4bcc9
docker/build-push-actionv610e90e3645eae34f1e60eeb005ba3a3d33f178e8
hashicorp/setup-packerv3.2.0c3d53c525d422944e50ee27b840746d6522b08de

Fixes#2982

-- refactor/issue-fixer

Addresses supply chain hardening findings from issue #2982:
- Pin all 6 GitHub Actions to full commit SHAs with version comments:
- actions/checkout@v4 → SHA 34e1148...
- oven-sh/setup-bun@v2 → SHA 0c5077e...
- actions/github-script@v7 → SHA f28e40c...
- docker/login-action@v3 → SHA c94ce9f...
- docker/build-push-action@v6 → SHA 10e90e3...
- hashicorp/setup-packer@main → SHA c3d53c5... (v3.2.0)
- Pin Packer version: latest → 1.15.0 (in packer-snapshots.yml)
- Pin bun version: latest → 1.3.11 (in agent-tarballs.yml)
- Pin shellcheck: replace apt-get (no version) with pinned download
of v0.10.0 from GitHub releases with SHA256 integrity check
These changes eliminate the primary LiteLLM-style attack vector:
a compromised action maintainer can no longer force-push malicious
code to an existing tag and have it run in CI.
Fixes#2982
Agent: issue-fixer
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@la14-1
la14-1 marked this pull request as ready for review March 25, 2026 16:39
The `JsNamedImportSpecifier` exclusion prevents `import { foo as bar }`
patterns from being flagged as type assertions. Previously, any `as`
keyword in import/export statements triggered the ban because the GritQL
pattern `$value as $type` matched import specifiers as well as actual
TypeScript type assertions.
This also removes the `as _foo` import aliases in the script-failure-guidance
test file (replaced with direct imports + distinctly-named wrapper functions)
which were the original manifestation of this bug.
All 1944 tests pass. Biome check clean across 169 files.
Agent: issue-fixer
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@la14-1

Copy link
Copy Markdown
CollaboratorAuthor

PR updated with 2 commits:

  1. Pin all GitHub Actions to commit SHAs — eliminates the primary LiteLLM-style supply chain attack vector across all 7 affected workflow files. Includes bun-version and Packer version pins.

  2. Fix pre-existing Biome lint failures — The no-type-assertion.grit rule was incorrectly flagging import { foo as bar } import aliases as TypeScript type assertions. Fixed by adding ! $expr <: JsNamedImportSpecifier() exclusion to the GritQL rule. This was causing CI to fail on PRs (18 pre-existing errors across the codebase, now 0).

All 1944 tests pass. Biome clean across 169 files.

-- refactor/issue-fixer

@louisgvlouisgv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Review

Verdict: APPROVED
Commit: f6928f8

Findings

✅ No security vulnerabilities found
✅ Strong supply chain security improvements:

  • All GitHub Actions pinned to commit SHAs
  • Bun version-locked to 1.3.11
  • Packer version-locked to 1.15.0
  • ShellCheck install with SHA256 verification
    ✅ Test refactoring properly eliminates banned type assertions
    ✅ Lint rule correctly exempts import type aliases

Tests

  • bash -n: N/A (no shell script changes)
  • bun test: Pre-existing module resolution issue (not introduced by this PR)
  • biome lint: PASS
  • curl|bash: N/A (no changes)
  • macOS compat: N/A (no bash changes)

Summary

This PR significantly improves CI/CD security by preventing supply chain attacks through action pinning and ensuring reproducible builds with version-locked tools. All commit SHAs verified as valid, ShellCheck SHA256 hash verified against official release.


-- security/pr-reviewer

@louisgv
louisgv merged commit 76bdaf2 into mainMar 25, 2026
5 checks passed
@louisgv
louisgv deleted the fix/issue-2982 branch March 25, 2026 17:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: CI/CD supply chain hardening — pin GitHub Actions to commit SHAs, version-lock tools

2 participants

@la14-1@louisgv
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

fix: pin GitHub Actions to commit SHAs, version-lock CI tools - #2983

Merged
louisgv merged 2 commits into
mainfrom
fix/issue-2982
Mar 25, 2026
Merged

fix: pin GitHub Actions to commit SHAs, version-lock CI tools#2983
louisgv merged 2 commits into
mainfrom
fix/issue-2982

Conversation

@la14-1

Copy link
Copy Markdown
Collaborator

Summary

Addresses supply chain hardening findings from #2982.

HIGH (both fixed):

  • Pinned all 6 GitHub Actions from mutable tags/branches to immutable commit SHAs with human-readable version comments
  • hashicorp/setup-packer@main + version: latest → pinned to SHA (v3.2.0) + Packer 1.15.0

MEDIUM (both fixed):

  • bun-version: latest in agent-tarballs.yml"1.3.11"
  • apt-get install shellcheck (no version) in lint.yml → pinned download of shellcheck v0.10.0 from GitHub releases with SHA256 integrity check

Changed files

  • .github/workflows/agent-tarballs.yml — checkout + setup-bun SHA pins; bun version pinned
  • .github/workflows/cli-release.yml — checkout + setup-bun SHA pins
  • .github/workflows/docker.yml — checkout + docker/login-action + docker/build-push-action SHA pins
  • .github/workflows/gate.yml — actions/github-script SHA pin
  • .github/workflows/lint.yml — checkout + setup-bun SHA pins; shellcheck pinned download with SHA256 verify
  • .github/workflows/packer-snapshots.yml — checkout + setup-packer SHA pins; packer version pinned
  • .github/workflows/test.yml — checkout + setup-bun SHA pins

SHA reference

ActionTagCommit SHA
actions/checkoutv434e114876b0b11c390a56381ad16ebd13914f8d5
oven-sh/setup-bunv20c5077e51419868618aeaa5fe8019c62421857d6
actions/github-scriptv7f28e40c7f34bde8b3046d885e986cb6290c5673b
docker/login-actionv3c94ce9fb468520275223c153574b00df6fe4bcc9
docker/build-push-actionv610e90e3645eae34f1e60eeb005ba3a3d33f178e8
hashicorp/setup-packerv3.2.0c3d53c525d422944e50ee27b840746d6522b08de

Fixes#2982

-- refactor/issue-fixer

Addresses supply chain hardening findings from issue #2982:
- Pin all 6 GitHub Actions to full commit SHAs with version comments:
- actions/checkout@v4 → SHA 34e1148...
- oven-sh/setup-bun@v2 → SHA 0c5077e...
- actions/github-script@v7 → SHA f28e40c...
- docker/login-action@v3 → SHA c94ce9f...
- docker/build-push-action@v6 → SHA 10e90e3...
- hashicorp/setup-packer@main → SHA c3d53c5... (v3.2.0)
- Pin Packer version: latest → 1.15.0 (in packer-snapshots.yml)
- Pin bun version: latest → 1.3.11 (in agent-tarballs.yml)
- Pin shellcheck: replace apt-get (no version) with pinned download
of v0.10.0 from GitHub releases with SHA256 integrity check
These changes eliminate the primary LiteLLM-style attack vector:
a compromised action maintainer can no longer force-push malicious
code to an existing tag and have it run in CI.
Fixes#2982
Agent: issue-fixer
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@la14-1
la14-1 marked this pull request as ready for review March 25, 2026 16:39
The `JsNamedImportSpecifier` exclusion prevents `import { foo as bar }`
patterns from being flagged as type assertions. Previously, any `as`
keyword in import/export statements triggered the ban because the GritQL
pattern `$value as $type` matched import specifiers as well as actual
TypeScript type assertions.
This also removes the `as _foo` import aliases in the script-failure-guidance
test file (replaced with direct imports + distinctly-named wrapper functions)
which were the original manifestation of this bug.
All 1944 tests pass. Biome check clean across 169 files.
Agent: issue-fixer
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@la14-1

Copy link
Copy Markdown
CollaboratorAuthor

PR updated with 2 commits:

  1. Pin all GitHub Actions to commit SHAs — eliminates the primary LiteLLM-style supply chain attack vector across all 7 affected workflow files. Includes bun-version and Packer version pins.

  2. Fix pre-existing Biome lint failures — The no-type-assertion.grit rule was incorrectly flagging import { foo as bar } import aliases as TypeScript type assertions. Fixed by adding ! $expr <: JsNamedImportSpecifier() exclusion to the GritQL rule. This was causing CI to fail on PRs (18 pre-existing errors across the codebase, now 0).

All 1944 tests pass. Biome clean across 169 files.

-- refactor/issue-fixer

@louisgvlouisgv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Review

Verdict: APPROVED
Commit: f6928f8

Findings

✅ No security vulnerabilities found
✅ Strong supply chain security improvements:

  • All GitHub Actions pinned to commit SHAs
  • Bun version-locked to 1.3.11
  • Packer version-locked to 1.15.0
  • ShellCheck install with SHA256 verification
    ✅ Test refactoring properly eliminates banned type assertions
    ✅ Lint rule correctly exempts import type aliases

Tests

  • bash -n: N/A (no shell script changes)
  • bun test: Pre-existing module resolution issue (not introduced by this PR)
  • biome lint: PASS
  • curl|bash: N/A (no changes)
  • macOS compat: N/A (no bash changes)

Summary

This PR significantly improves CI/CD security by preventing supply chain attacks through action pinning and ensuring reproducible builds with version-locked tools. All commit SHAs verified as valid, ShellCheck SHA256 hash verified against official release.


-- security/pr-reviewer

@louisgv
louisgv merged commit 76bdaf2 into mainMar 25, 2026
5 checks passed
@louisgv
louisgv deleted the fix/issue-2982 branch March 25, 2026 17:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: CI/CD supply chain hardening — pin GitHub Actions to commit SHAs, version-lock tools

2 participants

@la14-1@louisgv