fix(tarball): rewrite absolute /root symlinks after non-root extract - #3368

Merged
la14-1 merged 1 commit into
OpenRouterLabs:mainfrom
AhmedTMM:fix/sprite-no-tarball
Apr 29, 2026
Merged

fix(tarball): rewrite absolute /root symlinks after non-root extract#3368
la14-1 merged 1 commit into
OpenRouterLabs:mainfrom
AhmedTMM:fix/sprite-no-tarball

Conversation

@AhmedTMM

Copy link
Copy Markdown
Collaborator

Root cause

Tarballs are built on a CI VM running as root, so file layouts contain absolute symlinks like:

```
/root/.local/bin/claude -> /root/.claude/local/claude
```

When extracted on a non-root user (Sprite, scp-style installs without passwordless sudo), tar's `--transform "s|^root/|${HOME#/}/|"` rewrites file PATHS — so the file lands at `$HOME/.local/bin/claude` — but does not rewrite symlink TARGETS. The symlink still points to `/root/.claude/local/claude`, which doesn't exist.

User experience: `tryTarballInstall` returns `true` (the marker file extracts fine), the orchestrator logs "Agent installed from pre-built tarball" and proceeds to launch. Then:

```
/tmp/spawn_T6Gu8f.sh: line 4: claude: command not found
```

10 retries, exit 127, give up. Repro from a real session today on `spawn claude sprite` (no flags — fast_provision experiment had bucketed the user to test).

Fix

Post-extract, walk `$HOME` and rewrite any `/root/*` symlink targets to point under `$HOME`:

```bash
find "$HOME" -type l 2>/dev/null | while IFS= read -r _l; do
_t=$(readlink "$_l" 2>/dev/null) || continue
case "$_t" in
/root/*) ln -snf "$HOME${_t#/root}" "$_l" 2>/dev/null ;;
esac
done
```

Wired into the non-root branch of `extractCmd` in `shared/agent-tarball.ts`. Only runs when the transform extract succeeds; the sudo fallback (which extracts as root and doesn't need rewriting) is unchanged.

Why this is the right fix vs. alternatives

  • GNU tar `--transform "flags=rsh;..."` would rewrite symlink targets too, but only handles `^root/` (relative form) and would need a second rule for absolute `/root/`. Also relies on a relatively obscure GNU tar feature; the find walk is more portable.
  • Build tarballs as a non-root user would require duplicating the install pipeline. Out of scope.
  • Switch to relative symlinks at capture time would require knowing the layout each agent's installer produces. Brittle per-agent.

Test plan

  • `bunx @biomejs/biome check src/` — 0 errors
  • `bunx tsc --noEmit -p .` — 0 production errors
  • `bun test orchestrate.test.ts` — 41 pass
  • Smoke test: simulate post-transform extract layout in a temp dir with a dangling `/root/.claude/local/claude` symlink, run the fix loop, verify symlink resolves to `$HOME/.claude/local/claude` and `test -e` passes
  • End-to-end: `spawn claude sprite --beta tarball` + `which claude` returns a working path
  • End-to-end: `spawn openclaw sprite --beta tarball` + `openclaw --version` (separately, openclaw also has a config-validation issue surfacing in `Unrecognized key: "main"` — that's a different bug, not this PR)

Bumps CLI to 1.0.24.

🤖 Generated with Claude Code

Tarballs are built as root with absolute symlinks (e.g.
~/.local/bin/claude -> /root/.claude/local/claude). When extracted on
a non-root user (Sprite, scp-style installs without sudo), tar's
--transform rewrites file PATHS but not symlink TARGETS, so the
symlinks land in $HOME pointing at /root/... — which doesn't exist.
The agent binary appears installed but is a dangling link, and PATH
lookup fails with "command not found".
After the transform extract succeeds, walk $HOME for symlinks whose
target starts with /root/ and rewrite them to point under $HOME.
Idempotent (ln -snf), no-ops on healthy installs, cheap (one find on
a fresh VM's $HOME).
Bumps CLI to 1.0.24.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@la14-1

Copy link
Copy Markdown
Collaborator

Review

Diagnosis is exactly right: `tar --transform` rewrites file paths but not symlink targets, so every non-root extract on Sprite etc. has been silently dangling binary symlinks. Repro case in the description (`spawn claude sprite` → `command not found` → 10 retries → exit 127) is the classic signature.

Looks good

  • Scoped correctly: runs only in the non-root transform branch. Root-user extract and the sudo fallback are untouched.
  • Trailing `true` makes the subshell succeed even if individual `ln -snf` calls fail — without it, the outer `||` would fall through to `sudo tar` and double-extract on clouds that have sudo. Correct and defensive.
  • Shell-glob pattern `/root/*` matches `/root/foo` and `/root/x/y` but correctly does not match `/rooty` or a bare `/root` — target rewriting is narrowly scoped.
  • Uses `_l` / `_t` underscore-prefixed locals — won't clash with anything in the user's shell env.
  • `${_t#/root}` parameter expansion strips just the prefix, preserving the rest of the target path. Matches `$HOME${_t#/root}`.

Minor

  • Edge case: target is exactly `/root` (no trailing slash) — the `/root/` glob won't match. Unlikely in practice (agents always install under subdirs) but if it ever happens, the symlink stays dangling. Extending the case to `/root|/root/` would be a one-char fix.
  • `find "$HOME" -type l` walks the whole home. On a freshly-provisioned VM this is bounded by the tarball contents. Real users may have accumulated files, but we're running this inside the agent-install phase right after extract, so it's fine in practice.
  • No automated test. The PR mentions a manual smoke test in a temp dir — fair for a shell fragment, but this is the second tarball-extract bug this release (see also fix(packer): repair cursor tarball + hermes interactive install #3367). A unit test that asserts the generated `extractCmd` contains the fix loop + a shelled-out integration test with a crafted tarball would catch future regressions. Not blocking.

Alt-fix considered (and rejected correctly)

You considered `--transform "flags=rsh;..."` — that rewrites symlink targets but only matches the relative form `^root/` after tar's own stripping, not absolute `/root/`. A find-walk is more portable than relying on GNU-tar-specific flag syntax. Right call.

Nice-to-have (follow-up)

LGTM.

Reviewed by SPA

@la14-1la14-1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. See full review at #3368 (comment).

@la14-1
la14-1 merged commit 762508e into OpenRouterLabs:mainApr 29, 2026
6 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AhmedTMM@la14-1
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

fix(tarball): rewrite absolute /root symlinks after non-root extract - #3368

Merged
la14-1 merged 1 commit into
OpenRouterLabs:mainfrom
AhmedTMM:fix/sprite-no-tarball
Apr 29, 2026
Merged

fix(tarball): rewrite absolute /root symlinks after non-root extract#3368
la14-1 merged 1 commit into
OpenRouterLabs:mainfrom
AhmedTMM:fix/sprite-no-tarball

Conversation

@AhmedTMM

Copy link
Copy Markdown
Collaborator

Root cause

Tarballs are built on a CI VM running as root, so file layouts contain absolute symlinks like:

```
/root/.local/bin/claude -> /root/.claude/local/claude
```

When extracted on a non-root user (Sprite, scp-style installs without passwordless sudo), tar's `--transform "s|^root/|${HOME#/}/|"` rewrites file PATHS — so the file lands at `$HOME/.local/bin/claude` — but does not rewrite symlink TARGETS. The symlink still points to `/root/.claude/local/claude`, which doesn't exist.

User experience: `tryTarballInstall` returns `true` (the marker file extracts fine), the orchestrator logs "Agent installed from pre-built tarball" and proceeds to launch. Then:

```
/tmp/spawn_T6Gu8f.sh: line 4: claude: command not found
```

10 retries, exit 127, give up. Repro from a real session today on `spawn claude sprite` (no flags — fast_provision experiment had bucketed the user to test).

Fix

Post-extract, walk `$HOME` and rewrite any `/root/*` symlink targets to point under `$HOME`:

```bash
find "$HOME" -type l 2>/dev/null | while IFS= read -r _l; do
_t=$(readlink "$_l" 2>/dev/null) || continue
case "$_t" in
/root/*) ln -snf "$HOME${_t#/root}" "$_l" 2>/dev/null ;;
esac
done
```

Wired into the non-root branch of `extractCmd` in `shared/agent-tarball.ts`. Only runs when the transform extract succeeds; the sudo fallback (which extracts as root and doesn't need rewriting) is unchanged.

Why this is the right fix vs. alternatives

  • GNU tar `--transform "flags=rsh;..."` would rewrite symlink targets too, but only handles `^root/` (relative form) and would need a second rule for absolute `/root/`. Also relies on a relatively obscure GNU tar feature; the find walk is more portable.
  • Build tarballs as a non-root user would require duplicating the install pipeline. Out of scope.
  • Switch to relative symlinks at capture time would require knowing the layout each agent's installer produces. Brittle per-agent.

Test plan

  • `bunx @biomejs/biome check src/` — 0 errors
  • `bunx tsc --noEmit -p .` — 0 production errors
  • `bun test orchestrate.test.ts` — 41 pass
  • Smoke test: simulate post-transform extract layout in a temp dir with a dangling `/root/.claude/local/claude` symlink, run the fix loop, verify symlink resolves to `$HOME/.claude/local/claude` and `test -e` passes
  • End-to-end: `spawn claude sprite --beta tarball` + `which claude` returns a working path
  • End-to-end: `spawn openclaw sprite --beta tarball` + `openclaw --version` (separately, openclaw also has a config-validation issue surfacing in `Unrecognized key: "main"` — that's a different bug, not this PR)

Bumps CLI to 1.0.24.

🤖 Generated with Claude Code

Tarballs are built as root with absolute symlinks (e.g.
~/.local/bin/claude -> /root/.claude/local/claude). When extracted on
a non-root user (Sprite, scp-style installs without sudo), tar's
--transform rewrites file PATHS but not symlink TARGETS, so the
symlinks land in $HOME pointing at /root/... — which doesn't exist.
The agent binary appears installed but is a dangling link, and PATH
lookup fails with "command not found".
After the transform extract succeeds, walk $HOME for symlinks whose
target starts with /root/ and rewrite them to point under $HOME.
Idempotent (ln -snf), no-ops on healthy installs, cheap (one find on
a fresh VM's $HOME).
Bumps CLI to 1.0.24.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@la14-1

Copy link
Copy Markdown
Collaborator

Review

Diagnosis is exactly right: `tar --transform` rewrites file paths but not symlink targets, so every non-root extract on Sprite etc. has been silently dangling binary symlinks. Repro case in the description (`spawn claude sprite` → `command not found` → 10 retries → exit 127) is the classic signature.

Looks good

  • Scoped correctly: runs only in the non-root transform branch. Root-user extract and the sudo fallback are untouched.
  • Trailing `true` makes the subshell succeed even if individual `ln -snf` calls fail — without it, the outer `||` would fall through to `sudo tar` and double-extract on clouds that have sudo. Correct and defensive.
  • Shell-glob pattern `/root/*` matches `/root/foo` and `/root/x/y` but correctly does not match `/rooty` or a bare `/root` — target rewriting is narrowly scoped.
  • Uses `_l` / `_t` underscore-prefixed locals — won't clash with anything in the user's shell env.
  • `${_t#/root}` parameter expansion strips just the prefix, preserving the rest of the target path. Matches `$HOME${_t#/root}`.

Minor

  • Edge case: target is exactly `/root` (no trailing slash) — the `/root/` glob won't match. Unlikely in practice (agents always install under subdirs) but if it ever happens, the symlink stays dangling. Extending the case to `/root|/root/` would be a one-char fix.
  • `find "$HOME" -type l` walks the whole home. On a freshly-provisioned VM this is bounded by the tarball contents. Real users may have accumulated files, but we're running this inside the agent-install phase right after extract, so it's fine in practice.
  • No automated test. The PR mentions a manual smoke test in a temp dir — fair for a shell fragment, but this is the second tarball-extract bug this release (see also fix(packer): repair cursor tarball + hermes interactive install #3367). A unit test that asserts the generated `extractCmd` contains the fix loop + a shelled-out integration test with a crafted tarball would catch future regressions. Not blocking.

Alt-fix considered (and rejected correctly)

You considered `--transform "flags=rsh;..."` — that rewrites symlink targets but only matches the relative form `^root/` after tar's own stripping, not absolute `/root/`. A find-walk is more portable than relying on GNU-tar-specific flag syntax. Right call.

Nice-to-have (follow-up)

LGTM.

Reviewed by SPA

@la14-1la14-1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. See full review at #3368 (comment).

@la14-1
la14-1 merged commit 762508e into OpenRouterLabs:mainApr 29, 2026
6 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AhmedTMM@la14-1
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(tarball): rewrite absolute /root symlinks after non-root extract - #3368

Merged
la14-1 merged 1 commit into
OpenRouterLabs:mainfrom
AhmedTMM:fix/sprite-no-tarball
Apr 29, 2026
Merged

fix(tarball): rewrite absolute /root symlinks after non-root extract#3368
la14-1 merged 1 commit into
OpenRouterLabs:mainfrom
AhmedTMM:fix/sprite-no-tarball

Conversation

@AhmedTMM

Copy link
Copy Markdown
Collaborator

Root cause

Tarballs are built on a CI VM running as root, so file layouts contain absolute symlinks like:

```
/root/.local/bin/claude -> /root/.claude/local/claude
```

When extracted on a non-root user (Sprite, scp-style installs without passwordless sudo), tar's `--transform "s|^root/|${HOME#/}/|"` rewrites file PATHS — so the file lands at `$HOME/.local/bin/claude` — but does not rewrite symlink TARGETS. The symlink still points to `/root/.claude/local/claude`, which doesn't exist.

User experience: `tryTarballInstall` returns `true` (the marker file extracts fine), the orchestrator logs "Agent installed from pre-built tarball" and proceeds to launch. Then:

```
/tmp/spawn_T6Gu8f.sh: line 4: claude: command not found
```

10 retries, exit 127, give up. Repro from a real session today on `spawn claude sprite` (no flags — fast_provision experiment had bucketed the user to test).

Fix

Post-extract, walk `$HOME` and rewrite any `/root/*` symlink targets to point under `$HOME`:

```bash
find "$HOME" -type l 2>/dev/null | while IFS= read -r _l; do
_t=$(readlink "$_l" 2>/dev/null) || continue
case "$_t" in
/root/*) ln -snf "$HOME${_t#/root}" "$_l" 2>/dev/null ;;
esac
done
```

Wired into the non-root branch of `extractCmd` in `shared/agent-tarball.ts`. Only runs when the transform extract succeeds; the sudo fallback (which extracts as root and doesn't need rewriting) is unchanged.

Why this is the right fix vs. alternatives

  • GNU tar `--transform "flags=rsh;..."` would rewrite symlink targets too, but only handles `^root/` (relative form) and would need a second rule for absolute `/root/`. Also relies on a relatively obscure GNU tar feature; the find walk is more portable.
  • Build tarballs as a non-root user would require duplicating the install pipeline. Out of scope.
  • Switch to relative symlinks at capture time would require knowing the layout each agent's installer produces. Brittle per-agent.

Test plan

  • `bunx @biomejs/biome check src/` — 0 errors
  • `bunx tsc --noEmit -p .` — 0 production errors
  • `bun test orchestrate.test.ts` — 41 pass
  • Smoke test: simulate post-transform extract layout in a temp dir with a dangling `/root/.claude/local/claude` symlink, run the fix loop, verify symlink resolves to `$HOME/.claude/local/claude` and `test -e` passes
  • End-to-end: `spawn claude sprite --beta tarball` + `which claude` returns a working path
  • End-to-end: `spawn openclaw sprite --beta tarball` + `openclaw --version` (separately, openclaw also has a config-validation issue surfacing in `Unrecognized key: "main"` — that's a different bug, not this PR)

Bumps CLI to 1.0.24.

🤖 Generated with Claude Code

Tarballs are built as root with absolute symlinks (e.g.
~/.local/bin/claude -> /root/.claude/local/claude). When extracted on
a non-root user (Sprite, scp-style installs without sudo), tar's
--transform rewrites file PATHS but not symlink TARGETS, so the
symlinks land in $HOME pointing at /root/... — which doesn't exist.
The agent binary appears installed but is a dangling link, and PATH
lookup fails with "command not found".
After the transform extract succeeds, walk $HOME for symlinks whose
target starts with /root/ and rewrite them to point under $HOME.
Idempotent (ln -snf), no-ops on healthy installs, cheap (one find on
a fresh VM's $HOME).
Bumps CLI to 1.0.24.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@la14-1

Copy link
Copy Markdown
Collaborator

Review

Diagnosis is exactly right: `tar --transform` rewrites file paths but not symlink targets, so every non-root extract on Sprite etc. has been silently dangling binary symlinks. Repro case in the description (`spawn claude sprite` → `command not found` → 10 retries → exit 127) is the classic signature.

Looks good

  • Scoped correctly: runs only in the non-root transform branch. Root-user extract and the sudo fallback are untouched.
  • Trailing `true` makes the subshell succeed even if individual `ln -snf` calls fail — without it, the outer `||` would fall through to `sudo tar` and double-extract on clouds that have sudo. Correct and defensive.
  • Shell-glob pattern `/root/*` matches `/root/foo` and `/root/x/y` but correctly does not match `/rooty` or a bare `/root` — target rewriting is narrowly scoped.
  • Uses `_l` / `_t` underscore-prefixed locals — won't clash with anything in the user's shell env.
  • `${_t#/root}` parameter expansion strips just the prefix, preserving the rest of the target path. Matches `$HOME${_t#/root}`.

Minor

  • Edge case: target is exactly `/root` (no trailing slash) — the `/root/` glob won't match. Unlikely in practice (agents always install under subdirs) but if it ever happens, the symlink stays dangling. Extending the case to `/root|/root/` would be a one-char fix.
  • `find "$HOME" -type l` walks the whole home. On a freshly-provisioned VM this is bounded by the tarball contents. Real users may have accumulated files, but we're running this inside the agent-install phase right after extract, so it's fine in practice.
  • No automated test. The PR mentions a manual smoke test in a temp dir — fair for a shell fragment, but this is the second tarball-extract bug this release (see also fix(packer): repair cursor tarball + hermes interactive install #3367). A unit test that asserts the generated `extractCmd` contains the fix loop + a shelled-out integration test with a crafted tarball would catch future regressions. Not blocking.

Alt-fix considered (and rejected correctly)

You considered `--transform "flags=rsh;..."` — that rewrites symlink targets but only matches the relative form `^root/` after tar's own stripping, not absolute `/root/`. A find-walk is more portable than relying on GNU-tar-specific flag syntax. Right call.

Nice-to-have (follow-up)

LGTM.

Reviewed by SPA

@la14-1la14-1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. See full review at #3368 (comment).

@la14-1
la14-1 merged commit 762508e into OpenRouterLabs:mainApr 29, 2026
6 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AhmedTMM@la14-1
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(tarball): rewrite absolute /root symlinks after non-root extract - #3368

Merged
la14-1 merged 1 commit into
OpenRouterLabs:mainfrom
AhmedTMM:fix/sprite-no-tarball
Apr 29, 2026
Merged

fix(tarball): rewrite absolute /root symlinks after non-root extract#3368
la14-1 merged 1 commit into
OpenRouterLabs:mainfrom
AhmedTMM:fix/sprite-no-tarball

Conversation

@AhmedTMM

Copy link
Copy Markdown
Collaborator

Root cause

Tarballs are built on a CI VM running as root, so file layouts contain absolute symlinks like:

```
/root/.local/bin/claude -> /root/.claude/local/claude
```

When extracted on a non-root user (Sprite, scp-style installs without passwordless sudo), tar's `--transform "s|^root/|${HOME#/}/|"` rewrites file PATHS — so the file lands at `$HOME/.local/bin/claude` — but does not rewrite symlink TARGETS. The symlink still points to `/root/.claude/local/claude`, which doesn't exist.

User experience: `tryTarballInstall` returns `true` (the marker file extracts fine), the orchestrator logs "Agent installed from pre-built tarball" and proceeds to launch. Then:

```
/tmp/spawn_T6Gu8f.sh: line 4: claude: command not found
```

10 retries, exit 127, give up. Repro from a real session today on `spawn claude sprite` (no flags — fast_provision experiment had bucketed the user to test).

Fix

Post-extract, walk `$HOME` and rewrite any `/root/*` symlink targets to point under `$HOME`:

```bash
find "$HOME" -type l 2>/dev/null | while IFS= read -r _l; do
_t=$(readlink "$_l" 2>/dev/null) || continue
case "$_t" in
/root/*) ln -snf "$HOME${_t#/root}" "$_l" 2>/dev/null ;;
esac
done
```

Wired into the non-root branch of `extractCmd` in `shared/agent-tarball.ts`. Only runs when the transform extract succeeds; the sudo fallback (which extracts as root and doesn't need rewriting) is unchanged.

Why this is the right fix vs. alternatives

  • GNU tar `--transform "flags=rsh;..."` would rewrite symlink targets too, but only handles `^root/` (relative form) and would need a second rule for absolute `/root/`. Also relies on a relatively obscure GNU tar feature; the find walk is more portable.
  • Build tarballs as a non-root user would require duplicating the install pipeline. Out of scope.
  • Switch to relative symlinks at capture time would require knowing the layout each agent's installer produces. Brittle per-agent.

Test plan

  • `bunx @biomejs/biome check src/` — 0 errors
  • `bunx tsc --noEmit -p .` — 0 production errors
  • `bun test orchestrate.test.ts` — 41 pass
  • Smoke test: simulate post-transform extract layout in a temp dir with a dangling `/root/.claude/local/claude` symlink, run the fix loop, verify symlink resolves to `$HOME/.claude/local/claude` and `test -e` passes
  • End-to-end: `spawn claude sprite --beta tarball` + `which claude` returns a working path
  • End-to-end: `spawn openclaw sprite --beta tarball` + `openclaw --version` (separately, openclaw also has a config-validation issue surfacing in `Unrecognized key: "main"` — that's a different bug, not this PR)

Bumps CLI to 1.0.24.

🤖 Generated with Claude Code

Tarballs are built as root with absolute symlinks (e.g.
~/.local/bin/claude -> /root/.claude/local/claude). When extracted on
a non-root user (Sprite, scp-style installs without sudo), tar's
--transform rewrites file PATHS but not symlink TARGETS, so the
symlinks land in $HOME pointing at /root/... — which doesn't exist.
The agent binary appears installed but is a dangling link, and PATH
lookup fails with "command not found".
After the transform extract succeeds, walk $HOME for symlinks whose
target starts with /root/ and rewrite them to point under $HOME.
Idempotent (ln -snf), no-ops on healthy installs, cheap (one find on
a fresh VM's $HOME).
Bumps CLI to 1.0.24.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@la14-1

Copy link
Copy Markdown
Collaborator

Review

Diagnosis is exactly right: `tar --transform` rewrites file paths but not symlink targets, so every non-root extract on Sprite etc. has been silently dangling binary symlinks. Repro case in the description (`spawn claude sprite` → `command not found` → 10 retries → exit 127) is the classic signature.

Looks good

  • Scoped correctly: runs only in the non-root transform branch. Root-user extract and the sudo fallback are untouched.
  • Trailing `true` makes the subshell succeed even if individual `ln -snf` calls fail — without it, the outer `||` would fall through to `sudo tar` and double-extract on clouds that have sudo. Correct and defensive.
  • Shell-glob pattern `/root/*` matches `/root/foo` and `/root/x/y` but correctly does not match `/rooty` or a bare `/root` — target rewriting is narrowly scoped.
  • Uses `_l` / `_t` underscore-prefixed locals — won't clash with anything in the user's shell env.
  • `${_t#/root}` parameter expansion strips just the prefix, preserving the rest of the target path. Matches `$HOME${_t#/root}`.

Minor

  • Edge case: target is exactly `/root` (no trailing slash) — the `/root/` glob won't match. Unlikely in practice (agents always install under subdirs) but if it ever happens, the symlink stays dangling. Extending the case to `/root|/root/` would be a one-char fix.
  • `find "$HOME" -type l` walks the whole home. On a freshly-provisioned VM this is bounded by the tarball contents. Real users may have accumulated files, but we're running this inside the agent-install phase right after extract, so it's fine in practice.
  • No automated test. The PR mentions a manual smoke test in a temp dir — fair for a shell fragment, but this is the second tarball-extract bug this release (see also fix(packer): repair cursor tarball + hermes interactive install #3367). A unit test that asserts the generated `extractCmd` contains the fix loop + a shelled-out integration test with a crafted tarball would catch future regressions. Not blocking.

Alt-fix considered (and rejected correctly)

You considered `--transform "flags=rsh;..."` — that rewrites symlink targets but only matches the relative form `^root/` after tar's own stripping, not absolute `/root/`. A find-walk is more portable than relying on GNU-tar-specific flag syntax. Right call.

Nice-to-have (follow-up)

LGTM.

Reviewed by SPA

@la14-1la14-1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. See full review at #3368 (comment).

@la14-1
la14-1 merged commit 762508e into OpenRouterLabs:mainApr 29, 2026
6 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AhmedTMM@la14-1
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

fix(tarball): rewrite absolute /root symlinks after non-root extract - #3368

Merged
la14-1 merged 1 commit into
OpenRouterLabs:mainfrom
AhmedTMM:fix/sprite-no-tarball
Apr 29, 2026
Merged

fix(tarball): rewrite absolute /root symlinks after non-root extract#3368
la14-1 merged 1 commit into
OpenRouterLabs:mainfrom
AhmedTMM:fix/sprite-no-tarball

Conversation

@AhmedTMM

Copy link
Copy Markdown
Collaborator

Root cause

Tarballs are built on a CI VM running as root, so file layouts contain absolute symlinks like:

```
/root/.local/bin/claude -> /root/.claude/local/claude
```

When extracted on a non-root user (Sprite, scp-style installs without passwordless sudo), tar's `--transform "s|^root/|${HOME#/}/|"` rewrites file PATHS — so the file lands at `$HOME/.local/bin/claude` — but does not rewrite symlink TARGETS. The symlink still points to `/root/.claude/local/claude`, which doesn't exist.

User experience: `tryTarballInstall` returns `true` (the marker file extracts fine), the orchestrator logs "Agent installed from pre-built tarball" and proceeds to launch. Then:

```
/tmp/spawn_T6Gu8f.sh: line 4: claude: command not found
```

10 retries, exit 127, give up. Repro from a real session today on `spawn claude sprite` (no flags — fast_provision experiment had bucketed the user to test).

Fix

Post-extract, walk `$HOME` and rewrite any `/root/*` symlink targets to point under `$HOME`:

```bash
find "$HOME" -type l 2>/dev/null | while IFS= read -r _l; do
_t=$(readlink "$_l" 2>/dev/null) || continue
case "$_t" in
/root/*) ln -snf "$HOME${_t#/root}" "$_l" 2>/dev/null ;;
esac
done
```

Wired into the non-root branch of `extractCmd` in `shared/agent-tarball.ts`. Only runs when the transform extract succeeds; the sudo fallback (which extracts as root and doesn't need rewriting) is unchanged.

Why this is the right fix vs. alternatives

  • GNU tar `--transform "flags=rsh;..."` would rewrite symlink targets too, but only handles `^root/` (relative form) and would need a second rule for absolute `/root/`. Also relies on a relatively obscure GNU tar feature; the find walk is more portable.
  • Build tarballs as a non-root user would require duplicating the install pipeline. Out of scope.
  • Switch to relative symlinks at capture time would require knowing the layout each agent's installer produces. Brittle per-agent.

Test plan

  • `bunx @biomejs/biome check src/` — 0 errors
  • `bunx tsc --noEmit -p .` — 0 production errors
  • `bun test orchestrate.test.ts` — 41 pass
  • Smoke test: simulate post-transform extract layout in a temp dir with a dangling `/root/.claude/local/claude` symlink, run the fix loop, verify symlink resolves to `$HOME/.claude/local/claude` and `test -e` passes
  • End-to-end: `spawn claude sprite --beta tarball` + `which claude` returns a working path
  • End-to-end: `spawn openclaw sprite --beta tarball` + `openclaw --version` (separately, openclaw also has a config-validation issue surfacing in `Unrecognized key: "main"` — that's a different bug, not this PR)

Bumps CLI to 1.0.24.

🤖 Generated with Claude Code

Tarballs are built as root with absolute symlinks (e.g.
~/.local/bin/claude -> /root/.claude/local/claude). When extracted on
a non-root user (Sprite, scp-style installs without sudo), tar's
--transform rewrites file PATHS but not symlink TARGETS, so the
symlinks land in $HOME pointing at /root/... — which doesn't exist.
The agent binary appears installed but is a dangling link, and PATH
lookup fails with "command not found".
After the transform extract succeeds, walk $HOME for symlinks whose
target starts with /root/ and rewrite them to point under $HOME.
Idempotent (ln -snf), no-ops on healthy installs, cheap (one find on
a fresh VM's $HOME).
Bumps CLI to 1.0.24.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@la14-1

Copy link
Copy Markdown
Collaborator

Review

Diagnosis is exactly right: `tar --transform` rewrites file paths but not symlink targets, so every non-root extract on Sprite etc. has been silently dangling binary symlinks. Repro case in the description (`spawn claude sprite` → `command not found` → 10 retries → exit 127) is the classic signature.

Looks good

  • Scoped correctly: runs only in the non-root transform branch. Root-user extract and the sudo fallback are untouched.
  • Trailing `true` makes the subshell succeed even if individual `ln -snf` calls fail — without it, the outer `||` would fall through to `sudo tar` and double-extract on clouds that have sudo. Correct and defensive.
  • Shell-glob pattern `/root/*` matches `/root/foo` and `/root/x/y` but correctly does not match `/rooty` or a bare `/root` — target rewriting is narrowly scoped.
  • Uses `_l` / `_t` underscore-prefixed locals — won't clash with anything in the user's shell env.
  • `${_t#/root}` parameter expansion strips just the prefix, preserving the rest of the target path. Matches `$HOME${_t#/root}`.

Minor

  • Edge case: target is exactly `/root` (no trailing slash) — the `/root/` glob won't match. Unlikely in practice (agents always install under subdirs) but if it ever happens, the symlink stays dangling. Extending the case to `/root|/root/` would be a one-char fix.
  • `find "$HOME" -type l` walks the whole home. On a freshly-provisioned VM this is bounded by the tarball contents. Real users may have accumulated files, but we're running this inside the agent-install phase right after extract, so it's fine in practice.
  • No automated test. The PR mentions a manual smoke test in a temp dir — fair for a shell fragment, but this is the second tarball-extract bug this release (see also fix(packer): repair cursor tarball + hermes interactive install #3367). A unit test that asserts the generated `extractCmd` contains the fix loop + a shelled-out integration test with a crafted tarball would catch future regressions. Not blocking.

Alt-fix considered (and rejected correctly)

You considered `--transform "flags=rsh;..."` — that rewrites symlink targets but only matches the relative form `^root/` after tar's own stripping, not absolute `/root/`. A find-walk is more portable than relying on GNU-tar-specific flag syntax. Right call.

Nice-to-have (follow-up)

LGTM.

Reviewed by SPA

@la14-1la14-1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. See full review at #3368 (comment).

@la14-1
la14-1 merged commit 762508e into OpenRouterLabs:mainApr 29, 2026
6 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AhmedTMM@la14-1
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(tarball): rewrite absolute /root symlinks after non-root extract - #3368

Merged
la14-1 merged 1 commit into
OpenRouterLabs:mainfrom
AhmedTMM:fix/sprite-no-tarball
Apr 29, 2026
Merged

fix(tarball): rewrite absolute /root symlinks after non-root extract#3368
la14-1 merged 1 commit into
OpenRouterLabs:mainfrom
AhmedTMM:fix/sprite-no-tarball

Conversation

@AhmedTMM

Copy link
Copy Markdown
Collaborator

Root cause

Tarballs are built on a CI VM running as root, so file layouts contain absolute symlinks like:

```
/root/.local/bin/claude -> /root/.claude/local/claude
```

When extracted on a non-root user (Sprite, scp-style installs without passwordless sudo), tar's `--transform "s|^root/|${HOME#/}/|"` rewrites file PATHS — so the file lands at `$HOME/.local/bin/claude` — but does not rewrite symlink TARGETS. The symlink still points to `/root/.claude/local/claude`, which doesn't exist.

User experience: `tryTarballInstall` returns `true` (the marker file extracts fine), the orchestrator logs "Agent installed from pre-built tarball" and proceeds to launch. Then:

```
/tmp/spawn_T6Gu8f.sh: line 4: claude: command not found
```

10 retries, exit 127, give up. Repro from a real session today on `spawn claude sprite` (no flags — fast_provision experiment had bucketed the user to test).

Fix

Post-extract, walk `$HOME` and rewrite any `/root/*` symlink targets to point under `$HOME`:

```bash
find "$HOME" -type l 2>/dev/null | while IFS= read -r _l; do
_t=$(readlink "$_l" 2>/dev/null) || continue
case "$_t" in
/root/*) ln -snf "$HOME${_t#/root}" "$_l" 2>/dev/null ;;
esac
done
```

Wired into the non-root branch of `extractCmd` in `shared/agent-tarball.ts`. Only runs when the transform extract succeeds; the sudo fallback (which extracts as root and doesn't need rewriting) is unchanged.

Why this is the right fix vs. alternatives

  • GNU tar `--transform "flags=rsh;..."` would rewrite symlink targets too, but only handles `^root/` (relative form) and would need a second rule for absolute `/root/`. Also relies on a relatively obscure GNU tar feature; the find walk is more portable.
  • Build tarballs as a non-root user would require duplicating the install pipeline. Out of scope.
  • Switch to relative symlinks at capture time would require knowing the layout each agent's installer produces. Brittle per-agent.

Test plan

  • `bunx @biomejs/biome check src/` — 0 errors
  • `bunx tsc --noEmit -p .` — 0 production errors
  • `bun test orchestrate.test.ts` — 41 pass
  • Smoke test: simulate post-transform extract layout in a temp dir with a dangling `/root/.claude/local/claude` symlink, run the fix loop, verify symlink resolves to `$HOME/.claude/local/claude` and `test -e` passes
  • End-to-end: `spawn claude sprite --beta tarball` + `which claude` returns a working path
  • End-to-end: `spawn openclaw sprite --beta tarball` + `openclaw --version` (separately, openclaw also has a config-validation issue surfacing in `Unrecognized key: "main"` — that's a different bug, not this PR)

Bumps CLI to 1.0.24.

🤖 Generated with Claude Code

Tarballs are built as root with absolute symlinks (e.g.
~/.local/bin/claude -> /root/.claude/local/claude). When extracted on
a non-root user (Sprite, scp-style installs without sudo), tar's
--transform rewrites file PATHS but not symlink TARGETS, so the
symlinks land in $HOME pointing at /root/... — which doesn't exist.
The agent binary appears installed but is a dangling link, and PATH
lookup fails with "command not found".
After the transform extract succeeds, walk $HOME for symlinks whose
target starts with /root/ and rewrite them to point under $HOME.
Idempotent (ln -snf), no-ops on healthy installs, cheap (one find on
a fresh VM's $HOME).
Bumps CLI to 1.0.24.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@la14-1

Copy link
Copy Markdown
Collaborator

Review

Diagnosis is exactly right: `tar --transform` rewrites file paths but not symlink targets, so every non-root extract on Sprite etc. has been silently dangling binary symlinks. Repro case in the description (`spawn claude sprite` → `command not found` → 10 retries → exit 127) is the classic signature.

Looks good

  • Scoped correctly: runs only in the non-root transform branch. Root-user extract and the sudo fallback are untouched.
  • Trailing `true` makes the subshell succeed even if individual `ln -snf` calls fail — without it, the outer `||` would fall through to `sudo tar` and double-extract on clouds that have sudo. Correct and defensive.
  • Shell-glob pattern `/root/*` matches `/root/foo` and `/root/x/y` but correctly does not match `/rooty` or a bare `/root` — target rewriting is narrowly scoped.
  • Uses `_l` / `_t` underscore-prefixed locals — won't clash with anything in the user's shell env.
  • `${_t#/root}` parameter expansion strips just the prefix, preserving the rest of the target path. Matches `$HOME${_t#/root}`.

Minor

  • Edge case: target is exactly `/root` (no trailing slash) — the `/root/` glob won't match. Unlikely in practice (agents always install under subdirs) but if it ever happens, the symlink stays dangling. Extending the case to `/root|/root/` would be a one-char fix.
  • `find "$HOME" -type l` walks the whole home. On a freshly-provisioned VM this is bounded by the tarball contents. Real users may have accumulated files, but we're running this inside the agent-install phase right after extract, so it's fine in practice.
  • No automated test. The PR mentions a manual smoke test in a temp dir — fair for a shell fragment, but this is the second tarball-extract bug this release (see also fix(packer): repair cursor tarball + hermes interactive install #3367). A unit test that asserts the generated `extractCmd` contains the fix loop + a shelled-out integration test with a crafted tarball would catch future regressions. Not blocking.

Alt-fix considered (and rejected correctly)

You considered `--transform "flags=rsh;..."` — that rewrites symlink targets but only matches the relative form `^root/` after tar's own stripping, not absolute `/root/`. A find-walk is more portable than relying on GNU-tar-specific flag syntax. Right call.

Nice-to-have (follow-up)

LGTM.

Reviewed by SPA

@la14-1la14-1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. See full review at #3368 (comment).

@la14-1
la14-1 merged commit 762508e into OpenRouterLabs:mainApr 29, 2026
6 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AhmedTMM@la14-1
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(tarball): rewrite absolute /root symlinks after non-root extract - #3368

Merged
la14-1 merged 1 commit into
OpenRouterLabs:mainfrom
AhmedTMM:fix/sprite-no-tarball
Apr 29, 2026
Merged

fix(tarball): rewrite absolute /root symlinks after non-root extract#3368
la14-1 merged 1 commit into
OpenRouterLabs:mainfrom
AhmedTMM:fix/sprite-no-tarball

Conversation

@AhmedTMM

Copy link
Copy Markdown
Collaborator

Root cause

Tarballs are built on a CI VM running as root, so file layouts contain absolute symlinks like:

```
/root/.local/bin/claude -> /root/.claude/local/claude
```

When extracted on a non-root user (Sprite, scp-style installs without passwordless sudo), tar's `--transform "s|^root/|${HOME#/}/|"` rewrites file PATHS — so the file lands at `$HOME/.local/bin/claude` — but does not rewrite symlink TARGETS. The symlink still points to `/root/.claude/local/claude`, which doesn't exist.

User experience: `tryTarballInstall` returns `true` (the marker file extracts fine), the orchestrator logs "Agent installed from pre-built tarball" and proceeds to launch. Then:

```
/tmp/spawn_T6Gu8f.sh: line 4: claude: command not found
```

10 retries, exit 127, give up. Repro from a real session today on `spawn claude sprite` (no flags — fast_provision experiment had bucketed the user to test).

Fix

Post-extract, walk `$HOME` and rewrite any `/root/*` symlink targets to point under `$HOME`:

```bash
find "$HOME" -type l 2>/dev/null | while IFS= read -r _l; do
_t=$(readlink "$_l" 2>/dev/null) || continue
case "$_t" in
/root/*) ln -snf "$HOME${_t#/root}" "$_l" 2>/dev/null ;;
esac
done
```

Wired into the non-root branch of `extractCmd` in `shared/agent-tarball.ts`. Only runs when the transform extract succeeds; the sudo fallback (which extracts as root and doesn't need rewriting) is unchanged.

Why this is the right fix vs. alternatives

  • GNU tar `--transform "flags=rsh;..."` would rewrite symlink targets too, but only handles `^root/` (relative form) and would need a second rule for absolute `/root/`. Also relies on a relatively obscure GNU tar feature; the find walk is more portable.
  • Build tarballs as a non-root user would require duplicating the install pipeline. Out of scope.
  • Switch to relative symlinks at capture time would require knowing the layout each agent's installer produces. Brittle per-agent.

Test plan

  • `bunx @biomejs/biome check src/` — 0 errors
  • `bunx tsc --noEmit -p .` — 0 production errors
  • `bun test orchestrate.test.ts` — 41 pass
  • Smoke test: simulate post-transform extract layout in a temp dir with a dangling `/root/.claude/local/claude` symlink, run the fix loop, verify symlink resolves to `$HOME/.claude/local/claude` and `test -e` passes
  • End-to-end: `spawn claude sprite --beta tarball` + `which claude` returns a working path
  • End-to-end: `spawn openclaw sprite --beta tarball` + `openclaw --version` (separately, openclaw also has a config-validation issue surfacing in `Unrecognized key: "main"` — that's a different bug, not this PR)

Bumps CLI to 1.0.24.

🤖 Generated with Claude Code

Tarballs are built as root with absolute symlinks (e.g.
~/.local/bin/claude -> /root/.claude/local/claude). When extracted on
a non-root user (Sprite, scp-style installs without sudo), tar's
--transform rewrites file PATHS but not symlink TARGETS, so the
symlinks land in $HOME pointing at /root/... — which doesn't exist.
The agent binary appears installed but is a dangling link, and PATH
lookup fails with "command not found".
After the transform extract succeeds, walk $HOME for symlinks whose
target starts with /root/ and rewrite them to point under $HOME.
Idempotent (ln -snf), no-ops on healthy installs, cheap (one find on
a fresh VM's $HOME).
Bumps CLI to 1.0.24.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@la14-1

Copy link
Copy Markdown
Collaborator

Review

Diagnosis is exactly right: `tar --transform` rewrites file paths but not symlink targets, so every non-root extract on Sprite etc. has been silently dangling binary symlinks. Repro case in the description (`spawn claude sprite` → `command not found` → 10 retries → exit 127) is the classic signature.

Looks good

  • Scoped correctly: runs only in the non-root transform branch. Root-user extract and the sudo fallback are untouched.
  • Trailing `true` makes the subshell succeed even if individual `ln -snf` calls fail — without it, the outer `||` would fall through to `sudo tar` and double-extract on clouds that have sudo. Correct and defensive.
  • Shell-glob pattern `/root/*` matches `/root/foo` and `/root/x/y` but correctly does not match `/rooty` or a bare `/root` — target rewriting is narrowly scoped.
  • Uses `_l` / `_t` underscore-prefixed locals — won't clash with anything in the user's shell env.
  • `${_t#/root}` parameter expansion strips just the prefix, preserving the rest of the target path. Matches `$HOME${_t#/root}`.

Minor

  • Edge case: target is exactly `/root` (no trailing slash) — the `/root/` glob won't match. Unlikely in practice (agents always install under subdirs) but if it ever happens, the symlink stays dangling. Extending the case to `/root|/root/` would be a one-char fix.
  • `find "$HOME" -type l` walks the whole home. On a freshly-provisioned VM this is bounded by the tarball contents. Real users may have accumulated files, but we're running this inside the agent-install phase right after extract, so it's fine in practice.
  • No automated test. The PR mentions a manual smoke test in a temp dir — fair for a shell fragment, but this is the second tarball-extract bug this release (see also fix(packer): repair cursor tarball + hermes interactive install #3367). A unit test that asserts the generated `extractCmd` contains the fix loop + a shelled-out integration test with a crafted tarball would catch future regressions. Not blocking.

Alt-fix considered (and rejected correctly)

You considered `--transform "flags=rsh;..."` — that rewrites symlink targets but only matches the relative form `^root/` after tar's own stripping, not absolute `/root/`. A find-walk is more portable than relying on GNU-tar-specific flag syntax. Right call.

Nice-to-have (follow-up)

LGTM.

Reviewed by SPA

@la14-1la14-1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. See full review at #3368 (comment).

@la14-1
la14-1 merged commit 762508e into OpenRouterLabs:mainApr 29, 2026
6 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AhmedTMM@la14-1
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

fix(tarball): rewrite absolute /root symlinks after non-root extract - #3368

Merged
la14-1 merged 1 commit into
OpenRouterLabs:mainfrom
AhmedTMM:fix/sprite-no-tarball
Apr 29, 2026
Merged

fix(tarball): rewrite absolute /root symlinks after non-root extract#3368
la14-1 merged 1 commit into
OpenRouterLabs:mainfrom
AhmedTMM:fix/sprite-no-tarball

Conversation

@AhmedTMM

Copy link
Copy Markdown
Collaborator

Root cause

Tarballs are built on a CI VM running as root, so file layouts contain absolute symlinks like:

```
/root/.local/bin/claude -> /root/.claude/local/claude
```

When extracted on a non-root user (Sprite, scp-style installs without passwordless sudo), tar's `--transform "s|^root/|${HOME#/}/|"` rewrites file PATHS — so the file lands at `$HOME/.local/bin/claude` — but does not rewrite symlink TARGETS. The symlink still points to `/root/.claude/local/claude`, which doesn't exist.

User experience: `tryTarballInstall` returns `true` (the marker file extracts fine), the orchestrator logs "Agent installed from pre-built tarball" and proceeds to launch. Then:

```
/tmp/spawn_T6Gu8f.sh: line 4: claude: command not found
```

10 retries, exit 127, give up. Repro from a real session today on `spawn claude sprite` (no flags — fast_provision experiment had bucketed the user to test).

Fix

Post-extract, walk `$HOME` and rewrite any `/root/*` symlink targets to point under `$HOME`:

```bash
find "$HOME" -type l 2>/dev/null | while IFS= read -r _l; do
_t=$(readlink "$_l" 2>/dev/null) || continue
case "$_t" in
/root/*) ln -snf "$HOME${_t#/root}" "$_l" 2>/dev/null ;;
esac
done
```

Wired into the non-root branch of `extractCmd` in `shared/agent-tarball.ts`. Only runs when the transform extract succeeds; the sudo fallback (which extracts as root and doesn't need rewriting) is unchanged.

Why this is the right fix vs. alternatives

  • GNU tar `--transform "flags=rsh;..."` would rewrite symlink targets too, but only handles `^root/` (relative form) and would need a second rule for absolute `/root/`. Also relies on a relatively obscure GNU tar feature; the find walk is more portable.
  • Build tarballs as a non-root user would require duplicating the install pipeline. Out of scope.
  • Switch to relative symlinks at capture time would require knowing the layout each agent's installer produces. Brittle per-agent.

Test plan

  • `bunx @biomejs/biome check src/` — 0 errors
  • `bunx tsc --noEmit -p .` — 0 production errors
  • `bun test orchestrate.test.ts` — 41 pass
  • Smoke test: simulate post-transform extract layout in a temp dir with a dangling `/root/.claude/local/claude` symlink, run the fix loop, verify symlink resolves to `$HOME/.claude/local/claude` and `test -e` passes
  • End-to-end: `spawn claude sprite --beta tarball` + `which claude` returns a working path
  • End-to-end: `spawn openclaw sprite --beta tarball` + `openclaw --version` (separately, openclaw also has a config-validation issue surfacing in `Unrecognized key: "main"` — that's a different bug, not this PR)

Bumps CLI to 1.0.24.

🤖 Generated with Claude Code

Tarballs are built as root with absolute symlinks (e.g.
~/.local/bin/claude -> /root/.claude/local/claude). When extracted on
a non-root user (Sprite, scp-style installs without sudo), tar's
--transform rewrites file PATHS but not symlink TARGETS, so the
symlinks land in $HOME pointing at /root/... — which doesn't exist.
The agent binary appears installed but is a dangling link, and PATH
lookup fails with "command not found".
After the transform extract succeeds, walk $HOME for symlinks whose
target starts with /root/ and rewrite them to point under $HOME.
Idempotent (ln -snf), no-ops on healthy installs, cheap (one find on
a fresh VM's $HOME).
Bumps CLI to 1.0.24.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@la14-1

Copy link
Copy Markdown
Collaborator

Review

Diagnosis is exactly right: `tar --transform` rewrites file paths but not symlink targets, so every non-root extract on Sprite etc. has been silently dangling binary symlinks. Repro case in the description (`spawn claude sprite` → `command not found` → 10 retries → exit 127) is the classic signature.

Looks good

  • Scoped correctly: runs only in the non-root transform branch. Root-user extract and the sudo fallback are untouched.
  • Trailing `true` makes the subshell succeed even if individual `ln -snf` calls fail — without it, the outer `||` would fall through to `sudo tar` and double-extract on clouds that have sudo. Correct and defensive.
  • Shell-glob pattern `/root/*` matches `/root/foo` and `/root/x/y` but correctly does not match `/rooty` or a bare `/root` — target rewriting is narrowly scoped.
  • Uses `_l` / `_t` underscore-prefixed locals — won't clash with anything in the user's shell env.
  • `${_t#/root}` parameter expansion strips just the prefix, preserving the rest of the target path. Matches `$HOME${_t#/root}`.

Minor

  • Edge case: target is exactly `/root` (no trailing slash) — the `/root/` glob won't match. Unlikely in practice (agents always install under subdirs) but if it ever happens, the symlink stays dangling. Extending the case to `/root|/root/` would be a one-char fix.
  • `find "$HOME" -type l` walks the whole home. On a freshly-provisioned VM this is bounded by the tarball contents. Real users may have accumulated files, but we're running this inside the agent-install phase right after extract, so it's fine in practice.
  • No automated test. The PR mentions a manual smoke test in a temp dir — fair for a shell fragment, but this is the second tarball-extract bug this release (see also fix(packer): repair cursor tarball + hermes interactive install #3367). A unit test that asserts the generated `extractCmd` contains the fix loop + a shelled-out integration test with a crafted tarball would catch future regressions. Not blocking.

Alt-fix considered (and rejected correctly)

You considered `--transform "flags=rsh;..."` — that rewrites symlink targets but only matches the relative form `^root/` after tar's own stripping, not absolute `/root/`. A find-walk is more portable than relying on GNU-tar-specific flag syntax. Right call.

Nice-to-have (follow-up)

LGTM.

Reviewed by SPA

@la14-1la14-1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. See full review at #3368 (comment).

@la14-1
la14-1 merged commit 762508e into OpenRouterLabs:mainApr 29, 2026
6 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AhmedTMM@la14-1