Uh oh!
There was an error while loading. Please reload this page.
test(export): e2e test for redact pass bash execution - #3387
Conversation
la14-1
commented
May 5, 2026
Status check (2026-05-05):
This PR is green and ready for security review. The e2e tests exercise the generated bash redact loop against a real temp git directory covering all 8 SECRET_REGEX families. -- refactor/pr-maintainer |
a692a84 to
ee83585Comparela14-1
commented
May 10, 2026
Status: branch is current with main, all CI checks pass, mergeable. Ready for review. -- refactor/pr-maintainer |
la14-1
commented
May 11, 2026
Test Review: PR #3387Issues found:
Recommendation: Refactor to test -- refactor/test-engineer |
d2ff8f7 to
9a8d8a9CompareUse URL-based mock dispatch instead of sequential callCount thresholds to prevent telemetry flush from injecting spurious fetch calls that shift the mock response sequence. Agent: pr-maintainer Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
la14-1
commented
May 14, 2026
Fixed failing Mock Tests — all checks passing now. -- refactor/pr-maintainer |
la14-1
commented
May 18, 2026
Verified on current main (2026-05-18): lint clean (0 errors), 2209 pass / 1 fail (pre-existing: applySpawnMdSetup base64 — fails on main too). Branch is mergeable with no conflicts. Ready for review. -- refactor/pr-maintainer |
Exercises the generated sed-based redact loop against a real temp git repo to catch runtime quoting/escaping bugs like the sed delimiter regression in #3384. Tests all 8 SECRET_REGEX families, innocent content preservation, multi-secret lines, and PEM with algorithm prefix. Fixes#3385 Agent: test-engineer Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Use URL-based mock dispatch instead of sequential callCount thresholds to prevent telemetry flush from injecting spurious fetch calls that shift the mock response sequence. Agent: pr-maintainer Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
f1a59f7 to
34cd19bCompare
Why: The redact pass is the last line of defense before a potentially public
gh repo create --push.bash -nonly checks syntax — this test catches runtime quoting/escaping bugs like the sed delimiter regression in #3384.Summary
git initdirectoryBEGIN RSA PRIVATE KEY) are matchedTest plan
bun test packages/cli/src/__tests__/export.test.ts— 43 pass, 0 failbunx @biomejs/biome check— 0 errorsbun test— no regressions from this changeFixes#3385
-- refactor/test-engineer