Uh oh!
There was an error while loading. Please reload this page.
fix(hermes): probe for dashboard subcommand before launching - #3415
Closed
la14-1 wants to merge 2 commits into
Closed
fix(hermes): probe for dashboard subcommand before launching#3415la14-1 wants to merge 2 commits into
la14-1 wants to merge 2 commits into
Conversation
The root cause of issue #3407 is that some hermes installs (older versions or partial installs on DigitalOcean) lack the `dashboard` subcommand entirely. The previous code launched `hermes dashboard` unconditionally and waited 60s for a timeout, producing a confusing argparse error. Add a capability probe (`hermes --help | grep dashboard`) before attempting the launch. If the subcommand is missing, bail immediately with a clear message instead of waiting for the timeout. Also surface the actual error message from runServer failures in the warning. Fixes#3407 Agent: code-health Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…oss test files The digitalocean-token and hetzner-cov tests used callCount-based fetch mock routing, which broke when concurrent test files shared globalThis.fetch. Switch to URL-based routing so mock responses are determined by the request URL, not the order of all fetch calls across the process. Agent: code-health Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
la14-1
commented
May 18, 2026
CollaboratorAuthor
Verified on current main (2026-05-18): lint clean (0 errors), all CI checks passing (ShellCheck, Mock Tests, Biome Lint, Unit Tests, macOS Compatibility). Branch is mergeable with no conflicts. Ready for review. -- refactor/pr-maintainer |
la14-1
commented
May 18, 2026
CollaboratorAuthor
Closing in favor of #3413, which provides the comprehensive diagnostic approach. The earlier probe-only PR #3410 was already closed in favor of #3413's diagnostic block — this PR implements essentially the same probe approach and would conflict on -- refactor/community-coordinator |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: On DigitalOcean (and potentially other clouds), older hermes installs lack the
dashboardsubcommand. The previous code launchedhermes dashboardunconditionally and waited 60s for a timeout, producing a confusing argparse error that users reported in #3407.Changes
hermes --help | grep dashboard) before attempting the dashboard launchrunServererror message in the warning (was previously swallowed behind a generic message)Relationship to #3413
PR #3413 adds diagnostic output (binary location, version, log tail) for debugging. This PR fixes the root cause by detecting the missing subcommand upfront. They are complementary — this one should land first since it prevents the 60s timeout entirely.
Fixes#3407
Agent: code-health
-- spawn-refactor/code-health