Uh oh!
There was an error while loading. Please reload this page.
Conversation
Tests cover parseAuthEnvVars, hasCloudCredentials, cloud sorting by detected credentials, mapToSelectOptions with hintOverrides, getAuthHint, getImplementedClouds, and the full interactive picker prioritization flow. Agent: test-engineer Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
la14-1
commented
Feb 12, 2026
la14-1
left a comment
CollaboratorAuthor
There was a problem hiding this comment.
Self-review by test-engineer: Adds 57 tests covering credential-based cloud prioritization (PR #752). Tests parseAuthEnvVars, hasCloudCredentials, cloud sorting, mapToSelectOptions with hintOverrides, getAuthHint, getImplementedClouds, and full integration flow. All tests pass. No production code changes.
louisgv
approved these changes
Feb 12, 2026
louisgv
left a comment
Collaborator
There was a problem hiding this comment.
Security Review
Verdict: APPROVED
Findings
No security issues found.
This PR adds a single test file (cli/src/__tests__/credential-prioritization.test.ts) with 57 tests covering credential-based cloud prioritization logic. No production code is modified.
- No hardcoded real credentials (only test placeholders like "test-token")
- Environment variables properly saved/restored in afterEach hooks
- No shell commands, file operations, or network calls
- No eval, source, or unsafe patterns
Tests
- bash -n: N/A (no shell scripts changed)
- bun test: PASS (57 pass, 0 fail)
- curl|bash pattern: N/A
- macOS compat: N/A
Automated security review by spawn security team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cli/src/__tests__/credential-prioritization.test.tscovering the credential-based cloud prioritization feature from PR feat: prioritize clouds with detected credentials in interactive mode #752parseAuthEnvVars(19 tests): env var extraction from auth strings including single-var, multi-var, edge cases (short names, lowercase, digits, CLI-based auth)hasCloudCredentials(11 tests): checking if auth env vars are set, empty strings, partial multi-var authmapToSelectOptionswithhintOverrides(7 tests): the new parameter added in PR feat: prioritize clouds with detected credentials in interactive mode #752getImplementedClouds(4 tests): filtering by matrix implementation statusgetAuthHintintegration (5 tests): building auth hint strings for error messagesTest plan
Agent: test-engineer