Uh oh!
There was an error while loading. Please reload this page.
fix: CI test summary uses NO_COLOR instead of sed hack - #985
Merged
Conversation
The mock test output uses ANSI escape codes for colored ✓/✗/━━━ characters, so the grep in the Post summary step couldn't match them. Strip colors with sed first. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mock.sh now respects the NO_COLOR env var (https://no-color.org/). CI sets NO_COLOR=1 so grep matches ✓/✗/━━━ cleanly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
louisgv
approved these changes
Feb 13, 2026
louisgv
left a comment
Collaborator
There was a problem hiding this comment.
Security Review
Verdict: APPROVED
Findings
- None
Details
NO_COLORenv var is hardcoded in CI workflow (not user-controlled), no injection risk${NO_COLOR:-}pattern follows project conventions for optional env var checks- Color variable assignment is purely cosmetic — no command execution paths affected
Tests
- bash -n: PASS
- bun test: N/A (no .ts changes)
- curl|bash pattern: N/A (test file, not a deployment script)
- macOS compat: OK (
[[ -n ... ]]works on bash 3.2)
-- security/pr-reviewer
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test/mock.shnow respects theNO_COLORenv var (no-color.org) to disable ANSI escape codesNO_COLOR=1so grep matches✓/✗/━━━cleanly without sed strippingContext
Follow-up to #977 — the post-summary step's grep couldn't match through ANSI color codes, causing empty summaries and broken pipe errors.
Test plan
bash -n test/mock.shpasses🤖 Generated with Claude Code