Fix RPM download link to match actual Tauri-generated filename

[AnthonyRonning]

Fixes the RPM download link on the downloads page to match the actual filename generated by Tauri.

Changes

• Updated RPM filename pattern from Maple-{version}-1.x86_64.rpm to Maple_{version}_x86_64.rpm
• Fixed both fallback URL in downloads page and dynamic URL generation

Why

The GitHub Actions release workflow uses assetNamePattern: '[name]_[version]_[arch].[ext]' which generates filenames with underscores, not dashes. The -1 suffix was from an older Tauri version.

Fixes#303

Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
  • Corrected Linux RPM download URL format to ensure proper package retrieval and installation.

[coderabbitai]

Walkthrough

Two frontend download files updated: the fallback RPM URL pattern and the GitHub release RPM URL pattern both changed from hyphen-based naming (Maple-${version}-1.x86_64.rpm) to underscore-based naming (Maple_${version}_x86_64.rpm) to align with actual GitHub release asset names.

Changes

Cohort / File(s)	Summary
RPM download URL pattern updates frontend/src/routes/downloads.tsx, frontend/src/utils/githubRelease.ts	Updated linuxRpm download URL format from hyphen-separated pattern Maple-${version}-1.x86_64.rpm to underscore-separated pattern Maple_${version}_x86_64.rpm in both fallback URLs and GitHub release download URLs

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

• Both changes are identical string constant updates with no logic modifications
• Direct mapping to issue #303 requirement for correcting RPM filename patterns

Possibly related PRs

• Make Android APK downloads use dynamic GitHub release URLs #264: Modifies the same download URL structures (FALLBACK_URLS and downloadUrls) across both affected files
• feat: use GitHub API for desktop download links #91: Adjusts the Linux RPM download URL construction logic in the same source files
• Add download page #52: Originally introduced the downloads page infrastructure that these PRs modify

Poem

🐰 A rabbit hops through URLs with care,
Where underscores dance and hyphens fair—
From dashes old to underscores new,
The assets now align in view! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Linked Issues check	⚠️ Warning	The PR partially addresses issue #303 by fixing the downloads page RPM URLs but does not verify GitHub Actions, Tauri auto-updater, or ensure all three components use consistent filename patterns.	Verify and document that GitHub Actions release workflow and Tauri auto-updater also use the updated filename pattern (Maple_{version}_x86_64.rpm) to ensure full consistency across all three components.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: updating RPM download links to match Tauri-generated filenames with underscores instead of dashes and removing the -1 suffix.
Out of Scope Changes check	✅ Passed	All changes are within scope: only RPM filename patterns in the downloads page and release URL generation are modified, directly addressing issue #303's reported problem.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch claude/issue-303-20251111-2008

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 24002d3 and b544136.

📒 Files selected for processing (2)

• frontend/src/routes/downloads.tsx (1 hunks)
• frontend/src/utils/githubRelease.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.{ts,tsx,js,jsx}: Use 2-space indentation, double quotes, and a 100-character line limit for formatting
Use camelCase for variable and function names
Use try/catch with specific error types for error handling

Files:

• frontend/src/routes/downloads.tsx
• frontend/src/utils/githubRelease.ts

**/*.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

Use strict TypeScript typing and avoid any when possible

Files:

• frontend/src/routes/downloads.tsx
• frontend/src/utils/githubRelease.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)

• GitHub Check: build-android
• GitHub Check: build-linux
• GitHub Check: build-macos (universal-apple-darwin)
• GitHub Check: build-ios
• GitHub Check: Cloudflare Pages

🔇 Additional comments (2)

frontend/src/utils/githubRelease.ts (1)

74-74: LGTM! Dynamic RPM URL now consistent with fallback and actual assets.

The change correctly updates the RPM filename pattern to use underscores and removes the -1 suffix, matching the fallback URL in downloads.tsx and aligning with the GitHub Actions asset naming convention.

frontend/src/routes/downloads.tsx (1)

28-28: LGTM! RPM filename pattern now matches GitHub release assets.

The fallback RPM URL correctly uses underscore separators and removes the -1 suffix, aligning with the other download URLs (macOS, AppImage, deb) and the GitHub Actions assetNamePattern. Verification confirms actual release assets (Maple_1.99.5_x86_64.rpm) match the pattern exactly.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[greptile-apps]

Greptile Overview

Greptile Summary

Fixed RPM download link to match the actual filename generated by Tauri's build process.

• Changed RPM filename pattern from Maple-{version}-1.x86_64.rpm to Maple_{version}_x86_64.rpm
• Updated both the fallback URL in downloads.tsx:28 and dynamic URL in githubRelease.ts:74
• The fix aligns with the GitHub Actions release workflow configuration that uses assetNamePattern: '[name]_[version]_[arch].[ext]' (.github/workflows/release.yml:103)
• The -1 suffix was from an older Tauri version and is no longer generated

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• The changes are simple string replacements that fix a broken download link. The new filename pattern matches exactly what Tauri generates according to the GitHub Actions workflow configuration. Both locations (fallback and dynamic URL generation) have been updated consistently, and no other references to the old pattern exist in the codebase.
• No files require special attention

Important Files Changed

File Analysis

Filename	Score	Overview
frontend/src/routes/downloads.tsx	5/5	Updated fallback RPM URL pattern from Maple-{version}-1.x86_64.rpm to Maple_{version}_x86_64.rpm to match Tauri output
frontend/src/utils/githubRelease.ts	5/5	Updated dynamic RPM URL pattern from Maple-{version}-1.x86_64.rpm to Maple_{version}_x86_64.rpm to match Tauri output

Sequence Diagram

sequenceDiagram
participant User
participant DownloadsPage as Downloads Page
participant GitHubAPI as GitHub API
participant GitHubRelease as githubRelease.ts
participant TauriAction as Tauri Build Action
participant GitHubReleases as GitHub Releases
Note over TauriAction,GitHubReleases: Build & Release Process
TauriAction->>GitHubReleases: Build with assetNamePattern: '[name]_[version]_[arch].[ext]'
GitHubReleases-->>GitHubReleases: Store as Maple_{version}_x86_64.rpm
Note over User,DownloadsPage: User Downloads Flow
User->>DownloadsPage: Visit /downloads
DownloadsPage->>GitHubRelease: getLatestDownloadInfo()
GitHubRelease->>GitHubAPI: Fetch latest release
GitHubAPI-->>GitHubRelease: Return release data
GitHubRelease->>GitHubRelease: Build URL: Maple_{version}_x86_64.rpm
GitHubRelease-->>DownloadsPage: Return download URLs
alt API Success
DownloadsPage->>User: Display dynamic URL
else API Fails
DownloadsPage->>User: Display fallback URL: Maple_{version}_x86_64.rpm
end
User->>GitHubReleases: Click download link
GitHubReleases-->>User: Download Maple_{version}_x86_64.rpm

Loading

[greptile-apps]

_{2 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}