ci: quote and group GITHUB_ENV writes

[AnthonyRonning]

Quotes "$GITHUB_ENV" and groups redirects for env writes across workflows (avoids ShellCheck SC2086/SC2129).

---

Summary by CodeRabbit

• Chores
  • Consolidated environment variable writes across CI workflows to append grouped assignments in a single operation, reducing repeated I/O.
  • Standardized quoting and shell grouping for safer, more atomic environment file handling.
  • No changes to build outputs or runtime behavior; functional results remain unchanged.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

Multiple GitHub Actions workflows were edited to consolidate separate environment-variable echo/appends into single grouped blocks and to quote the environment file path (e.g., "$GITHUB_ENV"/"$GITHUB_OUTPUT"); functionality and step ordering remain unchanged.

Changes

Cohort / File(s)	Summary
Environment variable consolidation .github/workflows/... /.github/workflows/android-build.yml, /.github/workflows/claude.yml, /.github/workflows/release.yml, /.github/workflows/rust-tests.yml	Replaced multiple echo ... >> $GITHUB_ENV lines with a single grouped block that echoes several environment assignments and appends them once to "$GITHUB_ENV".
Environment file path quoting /.github/workflows/mobile-build.yml, /.github/workflows/testflight-on-comment.yml	Changed >> $GITHUB_ENV to >> "$GITHUB_ENV" (quoted) when writing an environment variable path.
Mixed consolidation and quoting /.github/workflows/desktop-build.yml	Multiple sccache/configure steps updated: grouped multi-line env writes into single block appends to "$GITHUB_ENV", and some occurrences of CERT_ID and other vars now use the quoted env path.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• Optimize GitHub Actions cache with sccache #308: Modifies the same "Configure sccache" environment-write patterns (consolidating echo lines and quoting "$GITHUB_ENV"), indicating a direct overlap in edits.

Poem

🐰 I hop through CI with nimble feet,
Grouping echoes into tidy sheets,
Quoted paths keep troubles at bay,
One write at once—neat as play.
Hooray for cleaner workflow treats! 🎉

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'ci: quote and group GITHUB_ENV writes' accurately summarizes the main changes: quoting GITHUB_ENV variables and grouping multiple echo commands into single blocks across workflow files.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cloudflare-workers-and-pages]

Deploying maple with Cloudflare Pages

Latest commit:	8cba5a2
Status:	✅ Deploy successful!
Preview URL:	https://5cf3b601.maple-ca8.pages.dev
Branch Preview URL:	https://chore-github-env-redirects.maple-ca8.pages.dev

View logs

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional flag.

[greptile-apps]

Greptile Overview

Greptile Summary

Fixed ShellCheck warnings SC2086 and SC2129 across all GitHub Actions workflows by quoting "$GITHUB_ENV" and "$GITHUB_OUTPUT" variables and grouping multiple echo redirects using brace syntax.

Changes made:

• Quoted $GITHUB_ENV to prevent word splitting issues if the variable contains spaces
• Grouped multiple environment variable writes using { echo ...; } >> "$GITHUB_ENV" syntax to reduce file I/O operations
• Applied the same fix to $GITHUB_OUTPUT in release.yml
• No functional changes - purely improves shell script safety and follows ShellCheck best practices

Confidence Score: 5/5

• This PR is completely safe to merge with no risk
• The changes are purely syntactic improvements to shell scripts that fix ShellCheck warnings. The modifications (quoting variables and grouping redirects) follow shell scripting best practices and have no impact on functionality. All changes are consistent and correctly applied across all workflow files.
• No files require special attention

Important Files Changed

Filename	Overview
.github/workflows/android-build.yml	Grouped sccache environment variable writes and quoted $GITHUB_ENV
.github/workflows/claude.yml	Grouped sccache environment variable writes and quoted $GITHUB_ENV
.github/workflows/desktop-build.yml	Grouped sccache environment variable writes and quoted $GITHUB_ENV in multiple jobs
.github/workflows/mobile-build.yml	Quoted $GITHUB_ENV for Apple API key path variable
.github/workflows/release.yml	Grouped sccache writes, quoted $GITHUB_ENV and $GITHUB_OUTPUT
.github/workflows/rust-tests.yml	Grouped sccache environment variable writes and quoted $GITHUB_ENV
.github/workflows/testflight-on-comment.yml	Quoted $GITHUB_ENV for Apple API key path variable

Sequence Diagram

sequenceDiagram
participant GHA as GitHub Actions
participant Shell as Shell Script
participant ENV as GITHUB_ENV File
Note over GHA,ENV: Before PR (Multiple Writes)
GHA->>Shell: Execute Configure sccache step
Shell->>ENV: echo "RUSTC_WRAPPER=sccache" >> $GITHUB_ENV
Shell->>ENV: echo "SCCACHE_DIR=$HOME/.cache/sccache" >> $GITHUB_ENV
Shell->>ENV: echo "SCCACHE_CACHE_SIZE=2G" >> $GITHUB_ENV
Note over Shell,ENV: ⚠️ Unquoted variable + 3 separate file operations
Note over GHA,ENV: After PR (Grouped & Quoted)
GHA->>Shell: Execute Configure sccache step
Shell->>ENV: { echo statements } >> "$GITHUB_ENV"
Note over Shell,ENV: ✅ Quoted variable + single grouped operation
ENV->>GHA: Environment variables available for next steps

Loading