Agent Mode: add trusted local skills support

[AnthonyRonning]

Summary

• register Goose’s first-class SkillsClient in every Agent Mode session, exposing the exact load_skill tool and personal skills from ~/.agents/skills
• discover project .agents/skills only after a one-time, account-scoped Trust this folder? decision; persist both trust and decline decisions by canonical folder path
• keep the Skills client transient so trust-filtered discovery state is never reconstructed from persisted Goose extension config
• render expandable timeline cards only for actual load_skill calls, with Loading, Loaded, and Couldn’t load outcome-aware titles
• preserve the existing Maple permission flow for every action a skill requests; only the instruction-loading load_skill call is always allowed

Trust and compatibility

• untrusted or unreadable project roots fail closed to an account-owned inert discovery directory while personal skills remain available
• offline historical folders remain loadable without prompting
• canonical paths make symlink aliases share one decision
• a user MCP server named skills coexists with Maple’s unprefixed Skills client
• the runtime-only registration key is longer than Maple’s existing MCP name limit, so no previously valid MCP configuration becomes reserved or unrecoverable

Validation

• cargo test --all-targets --locked — 128 passed
• cargo clippy --lib -- -D warnings
• cargo fmt --check
• bun run format:check
• bun run lint — 0 errors; 12 existing warnings outside this change
• bun run typecheck
• bun test — 131 passed
• bun run build
• nix flake check
• packaged a debug Maple.app and exercised Agent Mode against the local OpenSecret/billing/Continuum stack

Packaged-app coverage included trusting a project, loading a project skill, declining a different project, confirming a declined project skill is unavailable, loading a personal skill from the declined project, verifying decisions survive new sessions and app restarts, and checking successful and failed skill timeline cards.

Three independent review passes covered backend security/trust boundaries, Goose integration and persistence, and frontend UX/accessibility. All validated findings were fixed and the reviewers reported no remaining actionable issues.

---

Summary by CodeRabbit

• New Features
  • Added a project “skills trust” workflow to control whether a selected folder’s AI skills are trusted or isolated.
  • Trust is persisted per folder and treated as a one-time choice.
  • While trust status is loading or awaiting confirmation, agent settings and related controls are temporarily disabled.
• Bug Fixes
  • Updated the skill-loading timeline titles to reflect the selected load_skill argument (loading/success/failure).
  • Strengthened reserved-name validation for MCP servers to avoid Maple skill naming conflicts.
• Documentation
  • Expanded the MCP persistence/security guidance for additional reserved-name and validation rules.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e0c6d585-a9e7-4858-b588-eca827e77957

📥 Commits

Reviewing files that changed from the base of the PR and between f1e1974 and d044be9.

📒 Files selected for processing (2)

• frontend/src-tauri/src/agent.rs
• frontend/src/components/AgentMode.tsx

🚧 Files skipped from review as they are similar to previous changes (2)

• frontend/src/components/AgentMode.tsx
• frontend/src-tauri/src/agent.rs

---

📝 Walkthrough

Walkthrough

Adds per-project Maple Skills trust decisions, restricted handling for untrusted folders, transient SkillsClient lifecycle management, argument-aware load_skill timeline titles, and shared MCP reserved-key validation.

Changes

Project skills trust and Maple Skills

Layer / File(s)	Summary
Trust contract and prompt workflow frontend/src-tauri/src/agent.rs, frontend/src-tauri/src/lib.rs, frontend/src/services/agentRuntimeService.ts, frontend/src/components/AgentMode.tsx	Adds persisted trust types, Tauri commands, runtime service methods, and an Agent Mode dialog for selecting and saving a folder decision.
Transient Maple Skills client lifecycle frontend/src-tauri/src/agent.rs	Registers Maple Skills tools, selects trusted or restricted working directories, and reattaches the transient client around session and MCP extension mutations.
Argument-aware load-skill timeline frontend/src-tauri/src/agent.rs	Uses the requested skill name in timeline titles and merges loading, success, and failure states without overwriting the argument-aware title.
MCP reservation and compatibility validation frontend/src-tauri/src/agent.rs, docs/agent-mode-mcp.md	Centralizes Maple-reserved MCP key checks and updates related registration, permission, migration, documentation, and compatibility tests.

Estimated code review effort: 4 (Complex) | ~60 minutes

Sequence Diagram(s)

sequenceDiagram
participant AgentMode
participant agentRuntimeService
participant TauriAgent
participant AgentConfig
AgentMode->>agentRuntimeService: request project skills trust
agentRuntimeService->>TauriAgent: invoke trust command
TauriAgent->>AgentConfig: read or persist canonical path decision
AgentConfig-->>TauriAgent: return trust status
TauriAgent-->>agentRuntimeService: return status
agentRuntimeService-->>AgentMode: display or close trust dialog

Loading

Possibly related PRs

• OpenSecretCloud/Maple#627: Both changes update Agent Mode MCP reserved-name validation and related wiring.

Poem

I’m a rabbit guarding skills at night,
Trust the path, or keep it out of sight.
Maple tools hop in with care,
Titles bloom in timeline air.
Reserved names stay in their burrow tight.

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: trusted local skills support in Agent Mode.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex-maple-agent-skills-mvp-maple

---

_{Comment @coderabbitai help to get the list of available commands.}

[cloudflare-workers-and-pages]

Deploying maple with Cloudflare Pages

Latest commit:	d044be9
Status:	✅ Deploy successful!
Preview URL:	https://5deb4c69.maple-ca8.pages.dev
Branch Preview URL:	https://codex-maple-agent-skills-mvp.maple-ca8.pages.dev

View logs

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

[AnthonyRonning]

Non-blocking follow-up reminder: Maple currently inherits Goose compiled-in skills, including goose-doc-guide. We may want an upstream option to exclude Goose built-ins while retaining all filesystem-discovered project/global skills.

Relevant Goose code at Maple current pin: discover_skills appends builtin::get_all(), and SkillsClient uses that discovery for both instructions and tool loading. No Maple change is planned in this PR.