Uh oh!
There was an error while loading. Please reload this page.
Merge pull request #2705 from nxglabs/sync-to-public_repo-31391986146 - #2231
Merged
Conversation
Merge pull request #2704 from nxglabs/raktima-patch-main-7
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Pull request overview
This PR appears to sync/merge upstream changes into the public repository, primarily updating Node/JS dependencies (including security-focused overrides) and expanding the PDF request/signing flow UI logic (public template + access-code/OTP related behavior), along with i18n string updates.
Changes:
- Bump/downgrade several dependencies (e.g., axios, parse/parse-server, multer) and add multiple
overridesentries in both server and client packages. - Add substantial logic to
PdfRequestFiles.jsxaround template fetching, subscription checks, OTP handling, and access-code verification. - Update access-code related translations across locales (min length wording + new show/hide strings in EN).
Reviewed changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/OpenSignServer/package.json | Dependency and overrides updates impacting runtime/toolchain requirements. |
| apps/OpenSignServer/package-lock.json | Lockfile updates reflecting new dependency graph and engine constraints. |
| apps/OpenSign/src/pages/PdfRequestFiles.jsx | Large behavioral changes for public template/signing flow, OTP, and access-code verification. |
| apps/OpenSign/src/components/pdf/SignerListPlace.jsx | Minor formatting-only change. |
| apps/OpenSign/public/locales/*/translation.json | Access-code text updates (min length wording), plus EN show/hide labels. |
| apps/OpenSign/package.json | Client dependency bumps and new overrides entries. |
Files not reviewed (1)
- apps/OpenSignServer/package-lock.json: Generated file
Suppressed comments (3)
apps/OpenSign/src/pages/PdfRequestFiles.jsx:304
handleNavigationis defined with no parameters, but it's being called withres.planhere. If the plan is not used for navigation, call the function without arguments (or updatehandleNavigationto accept/use the plan).
handleNavigation(res.plan);
apps/OpenSignServer/package.json:88
parse@8.1.0(and the new overrides likeundici@7.29.0/brace-expansion@5.x) require Node >= 20, but this package still declares support for Node 18. This mismatch can lead to installs/builds failing or runtime incompatibilities for Node 18 users.
"overrides": {
"brace-expansion": ">=2.1.2",
"ws": "$ws",
"parse": "$parse",
"form-data": "$form-data",
"@parse/push-adapter": "$@parse/push-adapter",
"fast-xml-builder": "1.2.0",
"protobufjs": ">=7.6.3",
"tmp": ">=0.2.7",
"decompress": "npm:@xhmikosr/decompress@^11.1.4",
"tar": "^7.5.19",
"websocket-driver": ">=0.7.5",
"js-yaml": "^3.15.0",
"lodash": "^4.18.0",
"undici": "^7.29.0"
},
"engines": {
"node": "18 || 20 || 22"
}
apps/OpenSign/package.json:161
- This app depends on
parse@^8.1.0and overridesundici@^7.29.0, which require Node >= 20, butengines.nodestill lists Node 18. That can break local dev/CI environments that follow the declared Node 18 support.
"overrides": {
"brace-expansion": ">=2.1.2",
"tmp": "$tmp",
"react": "$react",
"react-dom": "$react-dom",
"form-data": ">=4.0.6",
"js-yaml": "^3.15.0",
"undici": "^7.29.0",
"fast-uri": "^3.1.5"
},
"engines": {
"node": "18 || 20 || 22"
}
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+233
to
+257
| if (!docId || !signerObjId) { | ||
| throw new Error(t("something-went-wrong-mssg")); | ||
| } | ||
| const res = await Parse.Cloud.run("verifyAccessCode", { | ||
| docId, | ||
| signerObjId, | ||
| code | ||
| }); | ||
| if (res?.verified) { | ||
| setAccessCodeVerified(true); | ||
| setAccessCodeRequired(false); | ||
| return true; | ||
| } | ||
| throw new Error(t("access-code-invalid")); | ||
| } catch (err) { | ||
| // Re-throw so the modal can render the message inline. | ||
| throw new Error( | ||
| err?.message === "Incorrect access code." | ||
| ? t("access-code-invalid") | ||
| : err?.message || t("access-code-invalid") | ||
| ); | ||
| } finally { | ||
| setAccessCodeLoader(false); | ||
| } | ||
| }; |
Comment on lines
+1775
to
+1798
| } | ||
| setIsUiLoading(false); | ||
| } catch (e) { | ||
| console.log("e", e); | ||
| if ( | ||
| e?.response?.data?.error === "Insufficient Credit" || | ||
| e?.response?.data?.error === "Plan expired" | ||
| ) { | ||
| handleCloseOtp(); | ||
| setIsAlert({ | ||
| title: t("insufficient-credits-title"), | ||
| isShow: true, | ||
| alertMessage: t("insufficient-credits-mssg", { appName }) | ||
| }); | ||
| } else { | ||
| handleCloseOtp(); | ||
| setIsAlert({ | ||
| title: "Error", | ||
| isShow: true, | ||
| alertMessage: t("something-went-wrong-mssg") | ||
| }); | ||
| } | ||
| } | ||
| }; |
| if (isGuestSign) { | ||
| setIsSubscriptionExpired(true); | ||
| } else { | ||
| handleNavigation(plan); |
Comment on lines
+331
to
+332
| //function for get document details for perticular signer with signer'object id | ||
| //whenever change anything in this function check react/angular packages also in plan js |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge pull request #2704 from nxglabs/raktima-patch-main-7