Uh oh!
There was an error while loading. Please reload this page.
Merge pull request #2709 from nxglabs/sync-to-public_repo-31486925834 - #2234
Merged
Conversation
Merge pull request #2708 from nxglabs/raktima-patch-main-7
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR appears to be a sync/merge update that primarily adjusts backend dependency lockfiles and updates frontend i18n strings related to “access code” UX (now emphasizing numeric/digit-only access codes and paid-plan messaging), with a small formatting-only tweak in one React component.
Changes:
- Updated
apps/OpenSignServerdependency versions and refreshedpackage-lock.jsonaccordingly (notablymulter,parse,parse-server). - Updated multiple locale
translation.jsonfiles to reflect “access code” being digit-based, add a numeric-only validation message, and add paid-plan upgrade/show/hide strings. - Minor whitespace-only change in
SignerListPlace.jsx.
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/OpenSignServer/package.json | Adjusts server dependency version ranges (multer/parse/parse-server). |
| apps/OpenSignServer/package-lock.json | Updates lockfile to match the dependency changes (including transitive package versions). |
| apps/OpenSign/src/components/pdf/SignerListPlace.jsx | Whitespace-only formatting change. |
| apps/OpenSign/public/locales/kr/translation.json | Updates Korean access-code strings and adds new access-code messages. |
| apps/OpenSign/public/locales/it/translation.json | Updates Italian access-code strings and adds new access-code messages. |
| apps/OpenSign/public/locales/hi/translation.json | Updates Hindi access-code strings and adds new access-code messages. |
| apps/OpenSign/public/locales/fr/translation.json | Updates French access-code strings and adds new access-code messages. |
| apps/OpenSign/public/locales/es/translation.json | Updates Spanish access-code strings and adds new access-code messages. |
| apps/OpenSign/public/locales/en/translation.json | Updates English access-code strings and adds new access-code messages. |
| apps/OpenSign/public/locales/de/translation.json | Updates German access-code strings and adds new access-code messages. |
Files not reviewed (1)
- apps/OpenSignServer/package-lock.json: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "access-code-required": "Der Absender hat diesem Empfänger einen Zugangscode zugewiesen. Geben Sie ihn ein, um fortzufahren.", | ||
| "access-code-invalid": "Falscher Zugangscode. Bitte beim Absender nachfragen.", | ||
| "access-code-too-short": "Der Zugangscode muss mindestens 4 Zeichen lang sein.", | ||
| "access-code-too-short": "Der Zugangscode muss mindestens 6 Zeichen lang sein.", |
Comment on lines
+1613
to
+1614
| "show-access-code": "액세스 코드 표시", | ||
| "hide-access-code": "액세스 코드 숨기기", |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge pull request #2708 from nxglabs/raktima-patch-main-7