Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 134
Logical Lanes in OSI#599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
stefancyliax
merged 37 commits into
OpenSimulationInterface:master
from
tbleher:logical-lanesMar 31, 2022
Uh oh!
There was an error while loading. Please reload this page.
Merged
Logical Lanes in OSI #599
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
808f3e6
Draft for discussion: Logical Lanes in OSI
tbleher 4b317f1
Fix a spelling error in osi_logicallane.proto
tbleher 96b8618
Adaptations from first round of review
tbleher 836b859
Update osi_logicallane.proto: fix wrong mention of "road" instead of …
tbleher f31bf82
Logical Lanes: add a few refers_to rules
tbleher 4ceb1a2
LogicalLaneBoundary: reference LaneBoundary, and add PassingRule
tbleher 731b295
Move ReferenceLine to separate file
tbleher e1998cd
Rework PassingRule enum, based on review in working group
tbleher 7291e91
Clarify physical_boundary_id example a bit
tbleher 3b8198d
Update Doxygen documentation
tbleher 03bd76d
Clarify when objects should be assigned to lanes.
tbleher 7d3f631
Add own type for logical lanes
tbleher df07a01
Allow a logical lane to reference several physical lanes
tbleher e2f1863
Allow logical boundaries to extend beyond the logical lane
tbleher 987ecee
Small doc update
tbleher eb0dff7
Improve LogicalLane documentation, add two example images.
tbleher cbdc34a
Extend documentation on reference line
tbleher 35b87b5
Clarify when lanes should share a reference line
tbleher 674315c
Make example regarding difference between Lane and LogicalLane more g…
tbleher b29338f
Limit allowed Z error to 2cm
tbleher 365e515
Move PASSING_RULE_OTHER to the top, according to OSI convention.
tbleher ba2fbe9
Explain a bit where overlapping_lane should be filled
tbleher c7634c8
Consistently use "intersection" instead of "junction"
tbleher 7ffc417
Better explain where TYPE_BIKING and TYPE_SIDEWALK should be used
tbleher 28375fb
Add TYPE_RAIL and TYPE_TRAM
tbleher 1d84acb
Add note that PASSING_RULE_OTHER should be used between non-drivable …
tbleher 83ac8e1
Clarify merging of lanes
tbleher 37bcd27
Expand explanation on predecessor and successor
tbleher d54a599
Support bidirectional lanes
tbleher 62df899
Remove LogicalLaneAssignment from non-Groundtruth objects
tbleher 065aaa5
Add new files to setup.py
tbleher a911992
Remove tabs
tbleher d2048d8
Move LogicalLaneAssignment to Classification
tbleher e73cd47
Fix test_brief_necessity errors
tbleher 34484f4
Add a small note on the heights of the boundary.
tbleher c3c0244
Add a note on how to create reference lines for map formats without r…
tbleher c7dc6ea
Explain how curbs are handled
tbleher File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -338,6 +338,55 @@ message Spherical3d | ||
| optional double elevation = 3; | ||
| } | ||
| // | ||
| // \brief Assignment of an object to a logical lane | ||
| // | ||
| // An object is assigned to a logical lane if it overlaps the logical lane. | ||
| // Assignment happens even if the reference point is outside the lane, and only | ||
| // a part of the object overlaps (any object overlapping the lane more than 5cm | ||
| // has to be assigned to the lane). | ||
| // | ||
| // As an exception to this, \c TrafficSign and \c TrafficLight are assigned to | ||
| // a logical lane if they control traffic on that lane. For \c TrafficSign and | ||
| // \c TrafficLight , #s_position refers to the position where the sign or light | ||
| // is valid (e.g. where vehicles should stop in case of a red traffic light), | ||
| // not the physical position (where the sign or light is in the world). | ||
| // Typically, t_position and angle_to_lane do not have any meaning in this | ||
| // case, and will be 0. | ||
| // | ||
| message LogicalLaneAssignment | ||
| { | ||
| // ID of the LogicalLane the object is assigned to. | ||
| // | ||
| // \rules | ||
| // refers_to: LogicalLane | ||
| // \endrules | ||
| // | ||
| optional Identifier assigned_lane_id = 1; | ||
| // S position of the object reference point on the lane, in the ST | ||
| // coordinate system of the lane. | ||
| // | ||
| // #s_position might be outside [s_start,s_end] of the lane (and even | ||
| // outside [startS,endS] of the reference line) if the reference point is | ||
| // outside the lane, but the object overlaps the lane or a TrafficSign or | ||
| // TrafficLight is assigned to a lane. | ||
| // | ||
| optional double s_position = 2; | ||
| // T position of the object reference point on the lane, in the ST | ||
| // coordinate system of the lane. | ||
tbleher marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| // | ||
| optional double t_position = 3; | ||
| // Angle of the object relative to the lane. | ||
| // See the ReferenceLine description how the angle is calculated. | ||
| // | ||
| // Unit: rad | ||
| // | ||
| optional double angle_to_lane = 4; | ||
| } | ||
| // | ||
| // \brief The base attributes of a stationary object or entity. | ||
| // | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -9,6 +9,8 @@ import "osi_trafficsign.proto"; | ||
| import "osi_trafficlight.proto"; | ||
| import "osi_roadmarking.proto"; | ||
| import "osi_lane.proto"; | ||
| import "osi_logicallane.proto"; | ||
| import "osi_referenceline.proto"; | ||
| import "osi_object.proto"; | ||
| import "osi_occupant.proto"; | ||
| @@ -171,4 +173,16 @@ message GroundTruth | ||
| // derives street geometries automatically from a map reference. | ||
| // | ||
| optional string model_reference = 16; | ||
| // Reference lines used by LogicalLane | ||
| // | ||
| repeated ReferenceLine reference_line = 17; | ||
| // Logical lane boundaries used by LogicalLane | ||
| // | ||
| repeated LogicalLaneBoundary logical_lane_boundary = 18; | ||
| // Logical lanes used e.g. by traffic agents | ||
| // | ||
| repeated LogicalLane logical_lane = 19; | ||
tbleher marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| } | ||
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.