Skip to content

Draft for discussion: Surface lines to model road shapes and heights - #619

Draft
arnedueselder wants to merge 14 commits into
OpenSimulationInterface:masterfrom
arnedueselder:master
Draft

Draft for discussion: Surface lines to model road shapes and heights#619
arnedueselder wants to merge 14 commits into
OpenSimulationInterface:masterfrom
arnedueselder:master

Conversation

@arnedueselder

@arnedueselderarnedueselder commented Mar 13, 2022•
edited
Loading

Copy link
Copy Markdown

This is the new draft for the surfacelines from the ASAM OSI Road Network Model Group. The current version includes all feedback so far and will enable OSI to model various road shapes and heights along a lane.

As discussed, the approach follows the concept of Vector3D line segments that form a lane and are used to retrieve height information at different parts of that lane. Speed bumps etc. could be modeled with more points, while almost flat surfaces would require almost none surface lines at all.

Height information of lane boundaries should be also included. The concept should only be used for a very rough description of the height profile and not used for a very detailed description of the road surface.
It would replace the currently implemented centerline for now (but not necessarily). The intend is to separate physical properties from logical information. It would still be possible though to place a surface line in the center of the lane to keep that information.

Concept will be expanded to be used in junctions, but is still open for discussion within the concept group.

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

  • My suggestion follows the style and contributors guidelines.
  • I have taken care about the documentation.
  • I have done the DCO signoff.
  • My changes generate no errors when passing CI tests.
  • I have successfully implemented and tested my fix/feature locally.
  • Appropriate reviewer(s) are assigned.

If you can’t check all of them, please explain why.
If all boxes are checked or commented and you have achieved at least one positive review, you can assign the label ReadyForCCBReview!

@arnedueselder
Added images for surfacelines
84b6151
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
@arnedueselder
Added first version of osi_surfacelines.proto
c7ac49b
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
@arnedueselder
Update osi_lane.proto
4415cae
Added the surfaceline message to OSI_Lane.proto
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
@clemenshabedankclemenshabedank added the RoadModel4.0 A label to collect road model topics for OSI 4.0 label Mar 14, 2022
clemenshabedank
clemenshabedank reviewed Mar 14, 2022
View reviewed changes
Comment threadosi_lane.proto Outdated
@arnedueselder
Update osi_lane.proto
ff00302
Updated explanation why surfacelines are not defined for lanes of TYPE_INTERSECTION yet.
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
@arnedueselder
Update osi_lane.proto
efe4ed9
Edited description of is_at_left_lane_boundary and is_at_right_lane_boundary to clarify intended usage.
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
@arnedueselder
Delete osi_surfaceline.proto
5b1bd52
Deleted obsolete osi_surfaceline.proto since it has been incorporated into osi_lane.proto
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
@arnedueselder
Update osi_lane.proto
09852ac
Adjusted description for surfacelines not defined in TYPE_INTERSECTION
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
This was referenced Mar 16, 2022
Closed
Closed
@clemenshabedankclemenshabedank added this to the V3.5.0 milestone Mar 21, 2022
@arnedueselder
Update osi_lane.proto
13072e5
Changed variables of is_at_left_lane_boundary/is_at_right_lane_boundary, since a surfaceline can only describe any one LaneBoundary, regardless wether it is located left or right of that Lane.
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
@arnedueselder
Delete OSI_LaneBoundaries_And_SurfaceLines.svg
3510036
Will upload updated version
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
@arnedueselder
Updated version of surfaceline examples
316c10b
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
@tblehertbleher mentioned this pull request Mar 24, 2022
Merged
clemenshabedank
clemenshabedank reviewed Mar 28, 2022
View reviewed changes
Comment threadosi_lane.proto Outdated
clemenshabedank
clemenshabedank reviewed Mar 28, 2022
View reviewed changes
Comment threadosi_lane.proto Outdated
clemenshabedank
clemenshabedank reviewed Mar 28, 2022
View reviewed changes
Comment threadosi_lane.proto Outdated
clemenshabedank
clemenshabedank reviewed Mar 28, 2022
View reviewed changes
Comment threadosi_lane.proto Outdated
clemenshabedank
clemenshabedank reviewed Mar 28, 2022
View reviewed changes
Comment threadosi_lane.proto Outdated
clemenshabedank
clemenshabedank reviewed Mar 28, 2022
View reviewed changes
Comment threadosi_lane.proto Outdated
clemenshabedank
clemenshabedank reviewed Mar 28, 2022
View reviewed changes
Comment threadosi_lane.proto Outdated
clemenshabedank
clemenshabedank reviewed Mar 28, 2022
View reviewed changes
Comment threadosi_lane.proto Outdated
clemenshabedank
clemenshabedank reviewed Mar 28, 2022
View reviewed changes
Comment threadosi_lane.proto Outdated
clemenshabedank
clemenshabedank reviewed Mar 28, 2022
View reviewed changes
Comment threadosi_lane.proto
clemenshabedank
clemenshabedank reviewed Mar 28, 2022
View reviewed changes
Comment threadosi_lane.proto
@arnedueselder
Update osi_lane.proto
1d4133f
Moved surfaceline_is_centerline outside of Surfaceline message to directly access it from Lane.
Also fixed typos and descriptions.
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
@arnedueselder
Update osi_lane.proto
4cded4a
Changed explanation of center_surfaceline_id
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
@arnedueselder
Delete strassenquerschnitt_surfacelines.png
bd779dc
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
@arnedueselder
Adjusted strassenquerschnitt_surfacelines
57c4854
Added surfacelines at lane boundaries in picture
Signed-off-by: Arne Düselder <60253650+arnedueselder@users.noreply.github.com>
@clemenshabedankclemenshabedank added ReadyForCCBReview Indicates that this PR is ready for a final review and merge by the CCB. labels Mar 30, 2022
@clemenshabedank

clemenshabedank commented Mar 30, 2022

Copy link
Copy Markdown
Contributor

ReadyForCCBReview label in order to get a preliminary review on the approach.
Still open:

  • surface lines or similar on intersections
  • handling curbs properly

@clemenshabedank

clemenshabedank commented Mar 30, 2022

Copy link
Copy Markdown
Contributor

Feedback CCB:

  • Curbs and intersections must also be described.
  • Unclear how to interpolate between points to get a unambigous height at any point of the road.
  • Efficient implementation should be possible.

Current use case: update valid positions in TrafficUpdate, only based on OSI.

No Blocker but needs further thoughts regarding HIL/SIL use cases / configurations regarding real time requirements etc. -> but separate discussion.

@clemenshabedankclemenshabedank removed the ReadyForCCBReview Indicates that this PR is ready for a final review and merge by the CCB. label Mar 30, 2022
@clemenshabedank

clemenshabedank commented Apr 13, 2022

Copy link
Copy Markdown
Contributor

Status from the Road Model group: Wait a couple of weeks on OpenDRIVE concepts to progress. Next meeting May 2nd.

@clemenshabedankclemenshabedank modified the milestones: V3.5.0, V4.0.0May 9, 2022
@yash-shah-asam

yash-shah-asam commented Apr 10, 2025

Copy link
Copy Markdown
Member

ASAM OSI CCB 2025-04-10: Await outcome of concept Project: ASAM OpenDRIVE with CityGML

@yash-shah-asamyash-shah-asam added the Broad Discussion Use this label to indicate more people are needed to reach a decision label Apr 10, 2025
@asadekasam

asadekasam commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

ASAM OSI CCB 2026-08-13: Await further steps of concept Project: ASAM OpenDRIVE with CityGML

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clemenshabedankclemenshabedankclemenshabedank left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Broad DiscussionUse this label to indicate more people are needed to reach a decisionRoadModel4.0A label to collect road model topics for OSI 4.0

Projects

None yet

Milestone

V4.x

Development

Successfully merging this pull request may close these issues.

4 participants

@arnedueselder@clemenshabedank@yash-shah-asam@asadekasam