Skip to content

Concretize lane boundary modelling for lanes at different heights - #634

Merged
pmai merged 2 commits into
OpenSimulationInterface:masterfrom
FabianPfeufferCAP:update/lane/lane_boundary_doc
May 30, 2022
Merged

Concretize lane boundary modelling for lanes at different heights#634
pmai merged 2 commits into
OpenSimulationInterface:masterfrom
FabianPfeufferCAP:update/lane/lane_boundary_doc

Conversation

@FabianPfeufferCAP

@FabianPfeufferCAPFabianPfeufferCAP commented May 20, 2022

Copy link
Copy Markdown

Add a description

Added additional documentation on how the boundary between lanes at different heights should be modeled.

Some questions to ask:
What is this change?

  • Additional documentation.

What does it fix?

  • Missing documentation on how to model lane boundaries.

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

  • My suggestion follows the style and contributors guidelines.
  • I have taken care about the documentation.
  • I have done the DCO signoff.
  • My changes generate no errors when passing CI tests.
  • I have successfully implemented and tested my fix/feature locally.
  • Appropriate reviewer(s) are assigned.

stefancyliax
stefancyliax reviewed May 30, 2022
View reviewed changes
Comment threadosi_lane.proto Outdated
@stefancyliaxstefancyliax added this to the V3.5.0 milestone May 30, 2022
@stefancyliaxstefancyliax added the ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB. label May 30, 2022
@stefancyliax

stefancyliax commented May 30, 2022

Copy link
Copy Markdown
Contributor

OSI CCB 30.05.2022:

  • Content is fine. Will be merged and included in 3.5.

@clemenshabedankclemenshabedank mentioned this pull request May 30, 2022
Closed
6 tasks
@clemenshabedankclemenshabedank added the RoadModel4.0 A label to collect road model topics for OSI 4.0 label May 30, 2022
Fabian Pfeufferand others added 2 commits May 30, 2022 16:51
Fabian Pfeuffer@pmai
Concretize lane boundary modelling for lanes at different heights
9217548
* Added additional documentation on how the boundary between lanes at
different heights should be modeled.
Signed-off-by: Fabian Pfeuffer <Fabian.Pfeuffer@partner.bmw.de>
@pmaiStefan Cyliax
Remove comments on height attribute for lane boundaries
9a02801
Co-authored-by: Stefan Cyliax <stefan.cyliax@asam.net>
Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
@pmai
pmaiforce-pushed the update/lane/lane_boundary_doc branch from a6e057c to 9a02801CompareMay 30, 2022 14:52
@pmai
pmai merged commit f836f2a into OpenSimulationInterface:masterMay 30, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pmaipmaipmai approved these changes
+1 more reviewer
@stefancyliaxstefancyliaxstefancyliax left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ReadyToMergeThis PR has been approved to merge and will be merged by a member of the CCB.RoadModel4.0A label to collect road model topics for OSI 4.0

Projects

None yet

Milestone

V3.5.0

Development

Successfully merging this pull request may close these issues.

4 participants

@FabianPfeufferCAP@stefancyliax@pmai@clemenshabedank