Uh oh!
There was an error while loading. Please reload this page.
Move sensor specifics to DetectedItemHeader - #708
Open
thomassedlmayer wants to merge 1 commit into
Open
Conversation
yash-shah-asam
commented
Apr 10, 2025
Member
@thomassedlmayer could you please handle this as the part of 23150 project. |
thomassedlmayer
commented
Apr 10, 2025
ContributorAuthor
As discussed in the last sensor modeling project meeting, we agreed that I will modify this PR to only deprecate certain fields instead of removing in order to be backwards compatible (minor release) but also already pave the way for a potential major release. Before merging anything though, we need to check how this is done in the new ISO23150 release as soon as we get access. |
Signed-off-by: Thomas Sedlmayer <tsedlmayer@pmsfit.de>
thomassedlmayerforce-pushed
the
feature/sm/sensor-specifics-to-header
branch
from
April 30, 2025 09:58
2ecae31 to
413a9d4Comparethomassedlmayer
marked this pull request as ready for review
April 30, 2025 10:01
PhRosenberger
approved these changes
May 5, 2025
PhRosenberger
left a comment
Contributor
There was a problem hiding this comment.
No further comments from my side.
asadekasam
commented
Aug 13, 2026
Contributor
OSI CCB 2026.08.13: It needs to be checked against the latest ISO 23150. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Thomas Sedlmayer tsedlmayer@pmsfit.de
This addresses #462. The PR introduces sensor-specifics in DetectedItemHeader and deprecates all sensor-specific fields that are located in DetectedMovingObject and DetectedStationaryObject directly.
This also should be discussed in terms of harmonization with ISO23150.
Resolves#462