Skip to content

Add protobuf linter - #776

Draft
ClemensLinnhoff wants to merge 16 commits into
masterfrom
775-use-protobuf-linter-in-ci-pipeline
Draft

Add protobuf linter#776
ClemensLinnhoff wants to merge 16 commits into
masterfrom
775-use-protobuf-linter-in-ci-pipeline

Conversation

@ClemensLinnhoff

@ClemensLinnhoffClemensLinnhoff commented Feb 12, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Reference to a related issue in the repository

#775

Add a description

  • Add a protobuf linter to check for style violations in PRs
  • Add spell check

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

@ClemensLinnhoff
Add buf-lint action
7af97ec
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoffClemensLinnhoff linked an issue Feb 12, 2024 that may be closed by this pull request
Use Protobuf linter in CI pipeline #775
Open
ClemensLinnhoffand others added 15 commits February 12, 2024 17:10
@ClemensLinnhoff
Fix workflow file
5fec885
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff
Fix workflow file
af08dd0
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff
Move linter
f678347
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff
Change to reviewdog-action-protolint
0fe23e9
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff
Test without github_token
5a49c62
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff
Change reporter type
f06e8ad
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff
Add test cases
d202af5
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff
Add GitHub token
a018ef0
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff
Try different settings for Linter
01fbf1d
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff
Put linter to separate job and add protolint config
617b54d
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff
Remove same number test case
01bcdbf
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff
Disable enum suffix rule
7f65485
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff
Disable message names prepositions
d52a8c7
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff
Remove linter from build job
21013d9
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@jdsika
Merge branch 'master' into 775-use-protobuf-linter-in-ci-pipeline
6068864
@jdsikajdsika added this to the V3.7.0 milestone Apr 25, 2024
@jdsika

jdsika commented Apr 25, 2024

Copy link
Copy Markdown
Contributor

@ClemensLinnhoff what is your status here? Should this be ready for next CCB?

@jdsikajdsika linked an issue Apr 25, 2024 that may be closed by this pull request
OSI violates several Protobuf Style Guide rules #711
Open
@pmai

pmai commented Apr 26, 2024

Copy link
Copy Markdown
Contributor

OSI 3.7.0 is feature-closed, only review-feedback relevant PRs and/or bugs are in the pipeline for now.

@pmaipmai removed this from the V3.7.0 milestone Apr 26, 2024
@ClemensLinnhoffClemensLinnhoff added this to the V3.8.0 milestone May 2, 2024
@jdsikajdsika modified the milestones: V3.8.0, V3.7.1Jul 30, 2024
@pmaipmai self-assigned this Apr 10, 2025
@pmaipmai added the OSIMaintenance Issues to be evaluated in the OSI CCB label Apr 10, 2025
@yash-shah-asam

yash-shah-asam commented Apr 10, 2025

Copy link
Copy Markdown
Member

@pmai could you please look into it?

@pmaipmai removed this from the V3.7.1 milestone Jul 16, 2026
@pmaipmai added this to the V3.8.1 milestone Jul 16, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@pmaipmai

@ClemensLinnhoffClemensLinnhoff

Labels

OSIMaintenanceIssues to be evaluated in the OSI CCB

Projects

None yet

Milestone

V3.8.1

Development

Successfully merging this pull request may close these issues.

Use Protobuf linter in CI pipeline OSI violates several Protobuf Style Guide rules

4 participants

@ClemensLinnhoff@jdsika@pmai@yash-shah-asam