Uh oh!
There was an error while loading. Please reload this page.
Add PersonSkeleton common type and skeleton field for Occupant - #899
Add PersonSkeleton common type and skeleton field for Occupant#899jdsika wants to merge 1 commit into
Conversation
pmai
commented
Apr 24, 2026
Would it not be easier to just re-use either PersonAttributes or PersonAttributes::Bone directly for now? This should be possible, as we have done so in the past. Maybe cannot be done in osi_common (potential circular includes, I would imagine), but directly in osi_occupant this should be possible... |
Add Occupant.Skeleton message in osi_occupant.proto that reuses MovingObject.PedestrianAttributes.Bone for occupant pose representation. The skeleton root is anchored via bbcenter_to_root relative to the vehicle bounding box center. Add migration notes on PedestrianAttributes documenting the plan to introduce a common skeleton type in OSI 4. Add .github/copilot-instructions.md for Copilot context. Signed-off-by: Carlo van Driesten <carlo.van-driesten@bmw.de>
3e38540 to
1e2335fCompareClemensLinnhoff
commented
May 7, 2026
Looks good to me. As the bone definitions of the pedestrian are harmonized with ASAM OpenMATERIAL 3D, the occupant could potentially also be referenced. Then we would need a model_reference parameter in the Occupant message analog to the model_reference of moving or stationary objects. What do you think @LudwigFriedmann? |
There was a problem hiding this comment.
I would remove this from the PR as it has nothing to do with the skeleton field.
Reference to a related issue in the repository
Extends the Occupant message to support skeleton/posture data for vehicle occupants (e.g. for driver monitoring / DCAS use cases).
Add a description
What is this change?
Adds an \Occupant.Skeleton\ message in \osi_occupant.proto\ that reuses \MovingObject.PedestrianAttributes.Bone\ directly, giving occupants a skeleton representation analogous to what pedestrians already have.
Changes:
epeated MovingObject.PedestrianAttributes.Bone skeleton_bone. New import of \osi_object.proto.
Does it break any existing functionality?
No. All changes are purely additive. Zero type duplication — \PedestrianAttributes.Bone\ is referenced directly.
How has it been tested?
Checklist