setProperty returns a promise, like getProperty - #41

Draft

k2d222 wants to merge 1 commit into

OpenSpace:masterfrom

k2d222:setprop-async

k2d222 commented Oct 7, 2025

setProperty now returns a promise. It's helpful:

for state synchronization: OpenSpace ack that the call was handled.
ideally, when an OpenSpace API call fails it should reject() which can then be caught by the client. It is not the case currently, and the lua API does not always propagate errors anyway.

setProperty returns a promise, like getProperty

1d33b3a

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); })();

setProperty returns a promise, like getProperty - #41

Draft

k2d222 wants to merge 1 commit into

OpenSpace:masterfrom

k2d222:setprop-async

k2d222 commented Oct 7, 2025

setProperty now returns a promise. It's helpful:

for state synchronization: OpenSpace ack that the call was handled.
ideally, when an OpenSpace API call fails it should reject() which can then be caught by the client. It is not the case currently, and the lua API does not always propagate errors anyway.

setProperty returns a promise, like getProperty

1d33b3a

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment