Uh oh!
There was an error while loading. Please reload this page.
Add Platform target with cross-platform logging support - #201
Merged
Conversation
Add a Platform C target (derived from Compute) providing platform_log_t abstraction. On Darwin, this wraps os_log; on other platforms, it uses syslog. Update OAG::misc_log() and OAG::error_log() to use platform_log_t, enabling logging on non-Darwin platforms. Also rename openAttributeGraphSPITarget to openAttributeGraphCxxTarget and sharedCXXSettings to sharedCxxSettings.
Reorder target declarations so dependencies use .target(name: xxTarget.name) instead of duplicating name strings. Also separate plugin into its own section.
Kyle-Yeforce-pushed
the
feature/platform-log
branch
from
February 24, 2026 09:48
745ae13 to
8699fafCompareCodecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #201 +/- ##
=======================================
Coverage 10.12% 10.12% =======================================
Files 28 28 Lines 820 820 =======================================
Hits 83 83 Misses 737 737 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Document that Swift headers must be cloned before building, either manually via clone-swift.sh or using --disable-sandbox. Update build.sh to use --disable-sandbox so the CloneSwiftPlugin can fetch headers.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PlatformC target (derived from Compute) providingplatform_log_tabstraction — wrapsos_logon Darwin, uses syslog on other platformsOAG::misc_log()andOAG::error_log()to useplatform_log_t, enabling logging on non-Darwin platformsopenAttributeGraphSPITarget→openAttributeGraphCxxTargetandsharedCXXSettings→sharedCxxSettings.target(name: xxTarget.name)references instead of string literals in Package.swiftTest plan
swift buildpasses on macOS