Skip to content

Replace LIB_SWIFT_PATH with bundled SwiftCorelibs headers - #205

Merged
Kyle-Ye merged 8 commits into
mainfrom
feature/remove_cf_env
Feb 24, 2026
Merged

Replace LIB_SWIFT_PATH with bundled SwiftCorelibs headers#205
Kyle-Ye merged 8 commits into
mainfrom
feature/remove_cf_env

Conversation

@Kyle-Ye

Copy link
Copy Markdown
Member

Summary

  • Remove libSwiftPath and __COREFOUNDATION_FORSWIFTFOUNDATIONONLY__ from Package.swift, replacing them with bundled system SDK headers under Sources/SwiftCorelibs
  • Rename SwiftCorelibsCoreFoundation module to SwiftCorelibs with headers exposed via -isystem include path instead of a module dependency (avoids clang explicit module issues)
  • Add dispatch and os headers from swift-corelibs-libdispatch for non-Darwin platforms
  • Extract SwiftBridging into its own standalone target
  • Support LIB_SWIFT_PATH env variable as an alternative to override bundled headers
  • Update README and add per-target READMEs

Test plan

  • macOS build passes
  • Ubuntu build passes
  • Verify LIB_SWIFT_PATH override works on Linux

Allow overriding bundled SwiftCorelibs headers via the LIB_SWIFT_PATH
environment variable for non-Darwin platforms. Update README to document
the new directory structure and the alternative configuration.
@github-actionsgithub-actionsBot added enhancement New feature or request build issue platform: Linux platform: macOS documentation Improvements or additions to documentation labels Feb 24, 2026
@augmentcode

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: This PR switches non-Darwin builds from relying on an external Swift toolchain header path to using bundled SwiftCorelibs headers checked into the repository.

Changes:

  • Remove the computed libSwiftPath logic and stop injecting -I include paths for toolchain headers.
  • Add a bundled Sources/SwiftCorelibs/include header set (CoreFoundation + dispatch + os) and include it via -isystem on non-Darwin platforms.
  • Extract SwiftBridging into its own include target and add it to the shared system include paths.
  • Drop the SwiftCorelibsCoreFoundation target/module dependency and rely on headers via include paths instead (avoids explicit module issues).
  • Rename the OpenAttributeGraphCxx umbrella header used by the module map.
  • Update top-level and per-target READMEs to reflect the new layout and override mechanism.

Technical Notes:OPENATTRIBUTEGRAPH_LIB_SWIFT_PATH can still be used to override the bundled headers when a system toolchain/SDK layout is preferred.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcodeaugmentcodeBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment threadPackage.swift
Comment threadSources/OpenAttributeGraphCxx/include/module.modulemap
@codecov

codecovBot commented Feb 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 10.12%. Comparing base (acae877) to head (9f09011).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #205 +/- ##
=======================================
Coverage 10.12% 10.12% =======================================
Files 28 28 Lines 820 820 =======================================
Hits 83 83 Misses 737 737 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye
Kyle-Ye merged commit d6910f8 into mainFeb 24, 2026
3 of 4 checks passed
@Kyle-Ye
Kyle-Ye deleted the feature/remove_cf_env branch February 24, 2026 18:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build issuedocumentationImprovements or additions to documentationenhancementNew feature or requestplatform: Linuxplatform: macOS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Kyle-Ye