Skip to content

Add Compute source build support - #214

Merged
Kyle-Ye merged 5 commits into
mainfrom
feature/compute_source_support
Feb 25, 2026
Merged

Add Compute source build support#214
Kyle-Ye merged 5 commits into
mainfrom
feature/compute_source_support

Conversation

@Kyle-Ye

Copy link
Copy Markdown
Member

Summary

  • Add Compute source dependency support alongside existing binary xcframework path
  • Rename targets PlatformOpenAttributeGraphPlatform and UtilitiesOpenAttributeGraphUtilities to avoid name collisions with Compute package
  • Default to source build (COMPUTE_BINARY=0), with binary still available via env var
  • Add -lswiftDemangle linker setting required by Compute
  • Enable Ubuntu CI for Compute source builds (Swift 6.2, libssl-dev, -Xcc -Wno-elaborated-enum-base)
  • Simplify OpenAttributeGraphShims product target list

Test plan

  • Ubuntu: OPENATTRIBUTEGRAPH_OPENATTRIBUTESHIMS_COMPUTE=1 OPENATTRIBUTEGRAPH_OPENATTRIBUTESHIMS_COMPUTE_BINARY=0 swift build (source)
  • macOS/iOS: OPENATTRIBUTEGRAPH_OPENATTRIBUTESHIMS_COMPUTE_BINARY=1 swift build (binary)
  • CI workflows validate both paths

@augmentcode

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: Adds support for building against the Compute package from source in addition to the existing binary XCFramework path.

Changes:

  • Introduces a source-vs-binary selection via OPENATTRIBUTEGRAPH_OPENATTRIBUTESHIMS_COMPUTE_BINARY (defaulting to source builds).
  • Renames internal Platform/Utilities targets to avoid collisions when Compute is present.
  • Adds Compute build settings on OpenAttributeGraphShims, including linking -lswiftDemangle.
  • Simplifies the OpenAttributeGraphShims product to only include the shims target.
  • Updates CI to enable Ubuntu Compute source builds and explicitly uses binary Compute on macOS/iOS.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcodeaugmentcodeBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment threadPackage.swift
@codecov

codecovBot commented Feb 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 32.08%. Comparing base (370c3ac) to head (6d0cd14).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #214 +/- ##
===========================================
+ Coverage 17.26% 32.08% +14.82% 
===========================================
Files 72 70 -2 Lines 4883 2596 -2287 ===========================================
- Hits 843 833 -10 + Misses 4040 1763 -2277 
FlagCoverage Δ
ios32.10% <ø> (ø)
macos9.95% <ø> (+6.46%)⬆️
ubuntu0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye
Kyle-Ye requested a review from jcmoscFebruary 25, 2026 15:29
@Kyle-Ye
Kyle-Yeforce-pushed the feature/compute_source_support branch from 635cfd7 to 6d0cd14CompareFebruary 25, 2026 16:47
@Kyle-Ye
Kyle-Ye merged commit e9e235f into mainFeb 25, 2026
9 checks passed
@Kyle-Ye
Kyle-Ye deleted the feature/compute_source_support branch February 25, 2026 16:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Kyle-Ye