Skip to content

Add oagBinary support - #215

Merged
Kyle-Ye merged 5 commits into
mainfrom
feature/oag-binary-target
Feb 25, 2026
Merged

Add oagBinary support#215
Kyle-Ye merged 5 commits into
mainfrom
feature/oag-binary-target

Conversation

@Kyle-Ye

Copy link
Copy Markdown
Member

No description provided.

@augmentcode

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: This PR adds an option to consume OpenAttributeGraph as a prebuilt binary (xcframework) and restructures the SwiftPM manifest to make OpenAttributeGraphShims the default product.

Changes:

  • Renamed internal targets to Platform and Utilities
  • Made OpenAttributeGraphShims the only always-declared product/target, appending other targets/products conditionally
  • Added OPENATTRIBUTESHIMS_OAG_USE_BINARY support to pull OpenAttributeGraph from a release xcframework
  • Adjusted Compute binary env keys and wiring
  • Moved swift-numerics to a conditional dependency (and updated the version) and updated Package.resolved accordingly

🤖 Was this summary useful? React with 👍 or 👎

@augmentcodeaugmentcodeBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment threadPackage.swift Outdated
Comment threadPackage.swift
@codecov

codecovBot commented Feb 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 32.08%. Comparing base (e9e235f) to head (76e602f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #215 +/- ##
=======================================
Coverage 32.08% 32.08% =======================================
Files 70 70 Lines 2596 2596 =======================================
Hits 833 833 Misses 1763 1763 
FlagCoverage Δ
ios32.10% <ø> (ø)
macos9.95% <ø> (ø)
ubuntu0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- Remove unnecessary OPENATTRIBUTESHIMS_ATTRIBUTEGRAPH and
COMPATIBILITY_TEST env vars from CI workflows
- Fix Compute binary iOS build scheme name to match simplified package
- Guard compatibilityTestCondition on buildForDarwinPlatform
- Fix OAG binary URL env var key name
@Kyle-Ye
Kyle-Yeforce-pushed the feature/oag-binary-target branch from 7c65c6d to 7641b0dCompareFebruary 25, 2026 18:47
@Kyle-Ye
Kyle-Yeforce-pushed the feature/oag-binary-target branch from 7641b0d to 04e9984CompareFebruary 25, 2026 18:52
@Kyle-Ye
Kyle-Ye merged commit e970392 into mainFeb 25, 2026
9 checks passed
@Kyle-Ye
Kyle-Ye deleted the feature/oag-binary-target branch February 25, 2026 19:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Kyle-Ye