Add dev/prod environment support for cloud API to main - #507
Merged
Merged
Conversation
dblizinski
enabled auto-merge (squash)
September 15, 2026 14:40
dblizinski
approved these changes
Sep 15, 2026
Signed-off-by: Seemal Tahir <stahir@openwater.cc>
Signed-off-by: Ebrahim Ebrahim <ebrahim.ebrahim@kitware.com>
ebrahimebrahim
force-pushed
the
cloud-dev-prod-env
branch
from
September 15, 2026 16:03
ec51301 to
172c58f
Compare
Collaborator
|
I added validation so only "dev" and "prod" are accepted. Previously, a typo such as "deev" silently selected production, which could send development sync traffic to the production service. |
ebrahimebrahim
approved these changes
Sep 15, 2026
ebrahimebrahim
disabled auto-merge
September 15, 2026 16:04
ebrahimebrahim
enabled auto-merge (rebase)
September 15, 2026 16:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Licensing layer
license-manifestchange process (and board approval for anything leaving the core). Link the approval.Checklist
git commit -sSPDX-License-Identifierfor their layerCODEOWNERSreview requestedNotes for reviewers
Restores dev/prod environment selection for the cloud sync Cloud class. This was originally added on the add-cloud-dev-prod-environment-support branch (commit 04fd1f8) but never merged into main. That branch is now ~70 commits stale, so this PR cherry-picks that commit onto current main rather than merging the branch directly. Cloud.init gains an optional environment parameter (defaults to "prod", unchanged from current behavior) that selects between API_URL_PROD and the newly added API_URL_DEV.