Make k-wave-python a direct dependency - #78
Conversation
Closes #7 It was previously indirect becasue of a windows issue in the main codebase that had yet to be released. The new release is said to support MacOS so we open that up for testing in the CI.
peterhollender
left a comment
There was a problem hiding this comment.
Could we configure the project so that it runs an import kwave as part of the installation process, which will trigger the download of the binaries if they aren't found on the system? That way the dependency gets fully installed.
something like:
python -c "import logging; logging.basicConfig(level=logging.INFO); import kwave"
Great idea. As I look into it, it seems not as straightforward as I thought. Let me keep digging for a bit |
|
Will continue looking into this, but if we decide that it should be an issue on k-wave-python then we can also open that issue and merge this PR. Let me know |
|
I think we open the issue on k-wave-python for more verbose communication during first time download, and solve this during custom app deployment for ours. We can resolve this issue. |
Closes #7
It was previously indirect becasue of a windows issue in the main codebase that had yet to be released.
The new release is said to support MacOS so we open that up for testing in the CI.