Skip to content

Make k-wave-python a direct dependency - #78

Merged
ebrahimebrahim merged 1 commit into
mainfrom
issue_7
Jul 11, 2024
Merged

ebrahimebrahim merged 1 commit into
mainfrom
issue_7

Conversation

@ebrahimebrahim

Copy link
Copy Markdown
Collaborator

Closes #7

It was previously indirect becasue of a windows issue in the main codebase that had yet to be released.

The new release is said to support MacOS so we open that up for testing in the CI.

Closes #7

It was previously indirect becasue of a windows issue in the main
codebase that had yet to be released.

The new release is said to support MacOS so we open that up for
testing in the CI.

@peterhollender peterhollender left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we configure the project so that it runs an import kwave as part of the installation process, which will trigger the download of the binaries if they aren't found on the system? That way the dependency gets fully installed.

something like:
python -c "import logging; logging.basicConfig(level=logging.INFO); import kwave"

@ebrahimebrahim

Copy link
Copy Markdown
Collaborator Author

Could we configure the project so that it runs an import kwave as part of the installation process, which will trigger the download of the binaries if they aren't found on the system? That way the dependency gets fully installed.

something like: python -c "import logging; logging.basicConfig(level=logging.INFO); import kwave"

Great idea. As I look into it, it seems not as straightforward as I thought. Let me keep digging for a bit

@ebrahimebrahim

Copy link
Copy Markdown
Collaborator Author

Will continue looking into this, but if we decide that it should be an issue on k-wave-python then we can also open that issue and merge this PR. Let me know

@peterhollender

Copy link
Copy Markdown
Contributor

I think we open the issue on k-wave-python for more verbose communication during first time download, and solve this during custom app deployment for ours. We can resolve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

k-wave-python specific branch needed

2 participants