Uh oh!
There was an error while loading. Please reload this page.
Feature/implement flask admin - #403
Conversation
fumblehool
commented
Oct 19, 2020
@aaron-suarez this PR contains the admin routes and the access control but some UI related things like - login page UI, logout page routing is remaining. |
aaron-junot
commented
Oct 19, 2020
@fumblehool Thanks so much for your contribution! I haven't pulled it down to run it just yet, but I'd like to give it a really thorough review because it changes the models. I think that this is also going to require a migration file to update the database, right? Can we get that added and the conflicts resolved and then I'll give it a really good review? Thanks! |
fumblehool
commented
Oct 20, 2020
@aaron-suarez I've pushed the migrations + fixed the lint issues. |
fumblehool
commented
Oct 27, 2020
@aaron-suarez have you tried it locally? |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
aaron-junot
commented
Oct 27, 2020
So locally, I got it running in the flask shell, but I'm a bit unclear as to the interface for creating a new user and assigning roles. Would you mind commenting with an example of how to add an admin user so I can do that locally and ensure that everything works as expected? I'm sure it's in the Thanks again for this contribution, it's looking good so far, just gotta go through the flow to make sure everything works 😄 |
aaron-junot
commented
Oct 28, 2020
Also, please rebase to resolve conflicts |
aaron-junot
commented
Oct 29, 2020
I ran it and navigated to Let me know when you're ready for another review (because I assume you're still trying to work this out). If you need help, feel free to hit me up on slack. |
…into feature/implement-flask-admin
fumblehool
commented
Oct 30, 2020
@aaron-suarez I've fixed the issues -
|
aaron-junot
commented
Oct 30, 2020
In order for the tests to pass, we'll probably need a default |
aaron-junot
commented
Oct 30, 2020
Other than that, it looks like it works at a first pass. I'll do some more extensive testing later, but I really appreciate the effort here! |
fumblehool
commented
Oct 31, 2020
@aaron-suarez I've added default values for |
Uh oh!
There was an error while loading. Please reload this page.
fumblehool
commented
Nov 7, 2020
@aaron-suarez I've resolved the comment. Please review, Thanks 😄 |
fixes#134